[Bug 875856] New: Review Request: ip-info - read/flash IP address info on a system with no monitor

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=875856

Bug ID: 875856
        QA Contact: [e-mail]
          Severity: medium
           Version: rawhide
          Priority: medium
                CC: [e-mail],
                    [e-mail]
          Assignee: [e-mail]
           Summary: Review Request: ip-info - read/flash IP address info
                    on a system with no monitor
        Regression: ---
      Story Points: ---
    Classification: Fedora
                OS: Linux
          Reporter: [e-mail]
              Type: ---
     Documentation: ---
          Hardware: All
        Mount Type: ---
            Status: NEW
         Component: Package Review
           Product: Fedora

Spec URL:
http://england.proximity.on.ca/chris/package-review/ip-info/ip-info.spec
SRPM URL:
http://england.proximity.on.ca/chris/package-review/ip-info/ip-info-0.1-3.fc...
Description: 
ip-info is a simple software package for determining IP address
information without using a video monitor. The IP address can be
displayed as flashes on the system LED or read over the system
speakers using espeak.

Fedora Account System Username: ctyler

[Bug 875856] Review Request: ip-info - read/flash IP address info on a system with no monitor

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=875856

--- Comment #1 from Chris Tyler  ---
Additional info:

- This package is targeted at systems such as the Raspberry Pi and Pandaboard,
which may or may not have a monitor attached

- This package successfully builds on Koji (scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=4679675)

- rpmlint output:

$ rpmlint ip-info.spec ip-info-0.1-3.fc16.src.rpm ip-info-0.1-3.fc16.noarch.rpm
ip-info.src: W: spelling-error %description -l en_US espeak -> speak, bespeak,
e speak
2 packages and 1 specfiles checked; 0 errors, 1 warnings.

[Bug 875856] Review Request: ip-info - read/flash IP address info on a system with no monitor

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=875856

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Petr Pisar  ---
Could you sub-package the ip-read tool not to force people to install espeak
and all the audio subsystem if they do not have audio hardware?

[Bug 875856] Review Request: ip-info - read/flash IP address info on a system with no monitor

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=875856

--- Comment #3 from Petr Pisar  ---
The systemd unit files have to be (de-)configured properly
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd.

Also you should run-require: sed, grep, coreutils, and net-tools for tools you
call from the bash scripts.

[Bug 875856] Review Request: ip-info - read/flash IP address info on a system with no monitor

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=875856

--- Comment #4 from Petr Pisar  ---
One functional issue: If the default-on trigger is compiled as module and not
loaded, then it's not available. It would be good to check `default-on' is
listed in the trigger at the beginning. Maybe the unit file could try to load
the module (or what's the correct way how to load modules with systemd).

[Bug 875856] Review Request: ip-info - read/flash IP address info on a system with no monitor

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=875856

--- Comment #5 from Chris Tyler  ---
Updated package.

Spec URL:
http://england.proximity.on.ca/chris/package-review/ip-info/0.2-1/ip-info.sp...
SRPM URL:
http://england.proximity.on.ca/chris/package-review/ip-info/0.2-1/ip-info-0....

Changes:
- systemd scriptlets added
- updated scripts to use 'ip addr' instead of 'ifconfig' on F18+
- fixed up dependencies

[Bug 875856] Review Request: ip-info - read/flash IP address info on a system with no monitor

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=875856

Antonio Trande  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Antonio Trande  ---
(In reply to Chris Tyler from comment #5)
> Updated package.
>
> Spec URL:
> http://england.proximity.on.ca/chris/package-review/ip-info/0.2-1/ip-info.
> spec
> SRPM URL:
> http://england.proximity.on.ca/chris/package-review/ip-info/0.2-1/ip-info-0.
> 2-1.fc18.src.rpm

Hi Chris.

Source0 link is uncomplete, its extension (tar.gz) is missing. 
Please, remove %defattr(-,root,root,-).

[Bug 875856] Review Request: ip-info - read/flash IP address info on a system with no monitor

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=875856

Miroslav Suchý  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
                 CC|                            |[e-mail]
         Resolution|---                         |INSUFFICIENT_DATA
        Last Closed|                            |2015-08-21 05:23:39

--- Comment #7 from Miroslav Suchý  ---
No response for years. Closing. Feel free to reopen if you want to continue.