[Bug 1450723] New: Review Request: nodejs-babel-polyfill - Provides polyfills necessary for a full ES2015+ environment

https://bugzilla.redhat.com/show_bug.cgi?id=1450723

Bug ID: 1450723
           Summary: Review Request: nodejs-babel-polyfill - Provides
                    polyfills necessary for a full ES2015+ environment
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
http://pnemade.fedorapeople.org/fedora-work/nodejs-babel-polyfill.spec
SRPM URL:
http://pnemade.fedorapeople.org/fedora-work/nodejs-babel-polyfill-6.23.0-1.f...

Description:
Functions to make sure the new buffer methods work in older browsers.

[Bug 1450723] Review Request: nodejs-babel-polyfill - Provides polyfills necessary for a full ES2015+ environment

https://bugzilla.redhat.com/show_bug.cgi?id=1450723

Parag Nemade  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1317317

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1317317
[Bug 1317317] nodejs-readable-stream-2.2.9 is available

[Bug 1450723] Review Request: nodejs-babel-polyfill - Provides polyfills necessary for a full ES2015+ environment

https://bugzilla.redhat.com/show_bug.cgi?id=1450723

Parag Nemade  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |956806 (nodejs-reviews)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker

[Bug 1450723] Review Request: nodejs-babel-polyfill - Provides polyfills necessary for a full ES2015+ environment

https://bugzilla.redhat.com/show_bug.cgi?id=1450723

Stephen Gallagher  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]
              Flags|                            |needinfo?([e-mail]
                   |                            |m)

--- Comment #1 from Stephen Gallagher  ---
This spec doesn't currently build in Fedora, as there is no npm(babel-runtime)
or npm(regenerator-runtime) in the distribution.

[Bug 1450723] Review Request: nodejs-babel-polyfill - Provides polyfills necessary for a full ES2015+ environment

https://bugzilla.redhat.com/show_bug.cgi?id=1450723

Parag Nemade  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |1444560, 1442275
              Flags|needinfo?([e-mail] |
                   |m)                          |

--- Comment #2 from Parag Nemade  ---
Sorry missed to add the dependencies.

Please note that npm(regenerator-runtime) is provided by subpackage
nodejs-regenerator-runtime from nodejs-regenerator package. See bug 1444560

I am still waiting for Jared Smith to finish importing and building
nodejs-babel-runtime package in Fedora. See bug 1442275

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1442275
[Bug 1442275] Review Request: nodejs-babel-runtime - The babel
selfContained runtime
https://bugzilla.redhat.com/show_bug.cgi?id=1444560
[Bug 1444560] Review Request: nodejs-regenerator-runtime - Runtime for
Regenerator-compiled generator and async functions

[Bug 1450723] Review Request: nodejs-babel-polyfill - Provides polyfills necessary for a full ES2015+ environment

https://bugzilla.redhat.com/show_bug.cgi?id=1450723
Bug 1450723 depends on bug 1442275, which changed state.

Bug 1442275 Summary: Review Request: nodejs-babel-runtime - The babel selfContained runtime
https://bugzilla.redhat.com/show_bug.cgi?id=1442275

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |RAWHIDE

[Bug 1450723] Review Request: nodejs-babel-polyfill - Provides polyfills necessary for a full ES2015+ environment

https://bugzilla.redhat.com/show_bug.cgi?id=1450723

--- Comment #3 from Parag Nemade  ---
I am still waiting for someone to review this. The nodejs-readable-stream
update got stuck due to this dependency.

[Bug 1450723] Review Request: nodejs-babel-polyfill - Provides polyfills necessary for a full ES2015+ environment

https://bugzilla.redhat.com/show_bug.cgi?id=1450723

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         Depends On|                            |1400600
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #4 from Robert-André Mauchin  ---
Hello,

- Please bump to the latest revision:

Version:    6.26.0

- Please switch
BuildRequires:  npm(regenerator-runtime)

to

BuildRequires:  npm(regenerator)

as specified by https://bugzilla.redhat.com/show_bug.cgi?id=1444560

It also require a more recent version of npm(regenerator), see bug #1400600,
nodejs-babel-runtime 6.26.0, and nodejs-core-js >= 2.5.0

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1400600
[Bug 1400600] nodejs-regenerator-0.10.1 is available

[Bug 1450723] Review Request: nodejs-babel-polyfill - Provides polyfills necessary for a full ES2015+ environment

https://bugzilla.redhat.com/show_bug.cgi?id=1450723

--- Comment #5 from Robert-André Mauchin  ---
Oops, please disregard my comment about npm(regenerator), I was wrong and
forgot to erase it.

[Bug 1450723] Review Request: nodejs-babel-polyfill - Provides polyfills necessary for a full ES2015+ environment

https://bugzilla.redhat.com/show_bug.cgi?id=1450723

--- Comment #6 from Parag Nemade  ---
Let's wait first for nodejs-regenerator updated to 0.10.0 version.

[Bug 1450723] Review Request: nodejs-babel-polyfill - Provides polyfills necessary for a full ES2015+ environment

https://bugzilla.redhat.com/show_bug.cgi?id=1450723

--- Comment #7 from Robert-André Mauchin  ---
Don't hesitate to bug me on IRC (eclipseo) when this is through.

[Bug 1450723] Review Request: nodejs-babel-polyfill - Provides polyfills necessary for a full ES2015+ environment

https://bugzilla.redhat.com/show_bug.cgi?id=1450723

Parag Nemade  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |NOTABUG
        Last Closed|                            |2018-07-23 23:33:22

--- Comment #8 from Parag Nemade  ---
Sorry but I don't have time to continue with this review. Hence closing this
review. Any other contributor can submit this package as a new bugzilla request
if needed.

Thank you zebob.m for your review comments.

[Bug 1450723] Review Request: nodejs-babel-polyfill - Provides polyfills necessary for a full ES2015+ environment

https://bugzilla.redhat.com/show_bug.cgi?id=1450723

Parag Nemade  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |