https://bugzilla.redhat.com/show_bug.cgi?id=1037427
Bug ID: 1037427 Summary: Review Request: kdeneur - KDE frontend for X Neural Switcher (xneur) Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: pahan@hubbitus.info QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raw.github.com/Hubbitus/Fedora-packaging/d95d58e54a3a12c5284b2cd826e... SRPM URL: http://hubbitus.info/rpm/Fedora20/kdeneur/kdeneur-0.17.0-1.fc21.src.rpm Description: KDE front-end for X Neural Switcher (xneur) Fedora Account System Username: hubbitus Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6248472
https://bugzilla.redhat.com/show_bug.cgi?id=1037427
Pavel Alexeev (aka Pahan-Hubbitus) pahan@hubbitus.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |kdeneur
https://bugzilla.redhat.com/show_bug.cgi?id=1037427
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@math.unl.edu Blocks| |656997 (kde-reviews)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1037427
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |201449 (FE-DEADREVIEW)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1037427
Pavel Alexeev pahan@hubbitus.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|201449 (FE-DEADREVIEW) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1037427
--- Comment #1 from Pavel Alexeev pahan@hubbitus.info --- Hi!
Why FE-DEADREVIEW?? I'm here and want import package in Fedora. Do you willing review it?
https://bugzilla.redhat.com/show_bug.cgi?id=1037427
--- Comment #2 from Pavel Alexeev pahan@hubbitus.info --- I ready also swap reviews.
https://bugzilla.redhat.com/show_bug.cgi?id=1037427
--- Comment #3 from Pavel Alexeev pahan@hubbitus.info --- Update to version 0.19.0
Changes: https://github.com/Hubbitus/Fedora-packaging/commit/fafd7f402df63c3a7bf47026... Spec: https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/fafd7f402df63c3a... Srpm: http://rpm.hubbitus.info/Fedora25/kdeneur/kdeneur-0.19.0-1.fc26.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1037427
Wolnei Junior e@wolnei.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |e@wolnei.com.br
--- Comment #4 from Wolnei Junior e@wolnei.com.br --- Some recommendations:
1. Update to version 0.20.0.
2. Prefer github source: Source0: https://github.com/AndrewCrewKuznetsov/xneur-devel/blob/master/dists/%%7Bver...
3. Pack versions with patch appliqued instead of you patch in your build.
4. Review your %build section to version 0.20.0
5. Use %autosetup instead of %setup -q
https://bugzilla.redhat.com/show_bug.cgi?id=1037427
--- Comment #5 from Wolnei Junior e@wolnei.com.br --- After run fedora-review tool:
[!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://launchpad.net/~andrew-crew- kuznetsov/+archive/xneur-stable/+files/kdeneur_0.19.0.orig.tar.gz See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[!]: %check is not present.
Full results in: https://wolnei.fedorapeople.org/rpm/kdeneur/review.txt
https://bugzilla.redhat.com/show_bug.cgi?id=1037427
--- Comment #6 from Pavel Alexeev pahan@hubbitus.info --- Hello Wolnei Junior. Thank you for the notes. Ok.
Changes: https://github.com/Hubbitus/rpm-kdeneur/commit/32b59fe7df44bac8837eccef345a1... Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=23086185 Spec: https://raw.githubusercontent.com/Hubbitus/rpm-kdeneur/32b59fe7df44bac8837ec... Srpm: http://rpm.hubbitus.info/Fedora27/kdeneur/kdeneur-0.20.0-1.fc28.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1037427
Iwicki Artur fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@svgames.pl
--- Comment #7 from Iwicki Artur fedora@svgames.pl ---
Group: User Interface/Desktops
This should be dropped. https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
%doc COPYING
This should probably be marked as %license.
https://bugzilla.redhat.com/show_bug.cgi?id=1037427
--- Comment #8 from Pavel Alexeev pahan@hubbitus.info --- Ok thanks.
Changes: https://github.com/Hubbitus/rpm-kdeneur/commit/bca45a3d9e1fcf91e7cff34f59759... Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=23163949 Spec: https://raw.githubusercontent.com/Hubbitus/rpm-kdeneur/bca45a3d9e1fcf91e7cff... Srpm: http://rpm.hubbitus.info/Fedora27/kdeneur/kdeneur-0.20.0-2.fc28.src.rpm
package-review@lists.fedoraproject.org