[Bug 1572287] New: Review Request: nodejs-istanbul-lib-hook - Hooks for require, vm and script used in istanbul - package-review

List overview All Threads
Download

newer

[Bug 1572287] New: Review Request: nodejs-istanbul-lib-hook - Hooks for require, vm and script used in istanbul

older

[Bug 1534052] New: Review...

[Bug 1218779] New: Review Request:...

bugzilla＠redhat.com

26 Apr 2018 26 Apr '18

10:56 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1572287

Bug ID: 1572287 Summary: Review Request: nodejs-istanbul-lib-hook - Hooks for require, vm and script used in istanbul Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: jsmith.fedora@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Blocks: 956806 (nodejs-reviews), 1269538 (IoT)

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-istanbul-lib-hook/nodejs-is... SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-istanbul-lib-hook/nodejs-is... Description: Hooks for require, vm and script used in istanbul Fedora Account System Username: jsmith

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by date

bugzilla＠redhat.com

26 Apr 26 Apr

12:50 p.m.

New subject: [Bug 1572287] Review Request: nodejs-istanbul-lib-hook - Hooks for require , vm and script used in istanbul

https://bugzilla.redhat.com/show_bug.cgi?id=1572287

Robert-André Mauchin zebob.m@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com

--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - You seem to have forgotten to add the test dependencies:

Exécution_de(%check) : /bin/sh -e /var/tmp/rpm-tmp.E6jeb5 + umask 022 + cd /builddir/build/BUILD + cd package + /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check + /usr/bin/node -e 'require("./")' BUILDSTDERR: module.js:549 BUILDSTDERR: throw err; BUILDSTDERR: ^ BUILDSTDERR: Error: Cannot find module 'append-transform'

Exécution_de(%check) : /bin/sh -e /var/tmp/rpm-tmp.0TN5X6 + umask 022 + cd /builddir/build/BUILD + cd package + /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check + /usr/bin/node -e 'require("./")' + NODE_ENV=test + /usr/bin/mocha -R spec BUILDSTDERR: module.js:549 BUILDSTDERR: throw err; BUILDSTDERR: ^ BUILDSTDERR: Error: Cannot find module 'chai'

Add them:

%if 0%{?enable_tests} BuildRequires: mocha BuildRequires: npm(append-transform) BuildRequires: npm(chai) %endif

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

bugzilla＠redhat.com

2 May 2 May

1:27 p.m.

New subject: [Bug 1572287] Review Request: nodejs-istanbul-lib-hook - Hooks for require , vm and script used in istanbul

https://bugzilla.redhat.com/show_bug.cgi?id=1572287

Jared Smith jsmith.fedora@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED

--- Comment #2 from Jared Smith jsmith.fedora@gmail.com --- Could you please test again? It's possible I had an old version of the files uploaded to my web server.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

bugzilla＠redhat.com

1:43 p.m.

New subject: [Bug 1572287] Review Request: nodejs-istanbul-lib-hook - Hooks for require , vm and script used in istanbul

https://bugzilla.redhat.com/show_bug.cgi?id=1572287

Robert-André Mauchin zebob.m@gmail.com changed:

--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- - Latest version packaged - License ok - Builds in Mock - No rpmlint errors - Conforms to the Packaging Guidelines

Package approved.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

bugzilla＠redhat.com

1:50 p.m.

New subject: [Bug 1572287] Review Request: nodejs-istanbul-lib-hook - Hooks for require , vm and script used in istanbul

https://bugzilla.redhat.com/show_bug.cgi?id=1572287

Jared Smith jsmith.fedora@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED

--- Comment #4 from Jared Smith jsmith.fedora@gmail.com --- Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/6414.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

bugzilla＠redhat.com

2:55 p.m.

New subject: [Bug 1572287] Review Request: nodejs-istanbul-lib-hook - Hooks for require , vm and script used in istanbul

https://bugzilla.redhat.com/show_bug.cgi?id=1572287

--- Comment #5 from Jared Smith jsmith.fedora@gmail.com --- Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/6416.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

bugzilla＠redhat.com

5:32 p.m.

New subject: [Bug 1572287] Review Request: nodejs-istanbul-lib-hook - Hooks for require , vm and script used in istanbul

https://bugzilla.redhat.com/show_bug.cgi?id=1572287

--- Comment #6 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-istanbul-lib-hook

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

bugzilla＠redhat.com

10 May 10 May

4:58 a.m.

New subject: [Bug 1572287] Review Request: nodejs-istanbul-lib-hook - Hooks for require , vm and script used in istanbul

https://bugzilla.redhat.com/show_bug.cgi?id=1572287

Peter Robinson pbrobinson@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks|1269538 (IoT) |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

bugzilla＠redhat.com

4:59 a.m.

New subject: [Bug 1572287] Review Request: nodejs-istanbul-lib-hook - Hooks for require , vm and script used in istanbul

https://bugzilla.redhat.com/show_bug.cgi?id=1572287

Peter Robinson pbrobinson@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1572709 (mozgw)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1572709 [Bug 1572709] Tracker for Mozilla IoT Gateway on Fedora

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

bugzilla＠redhat.com

11 May 11 May

8:38 a.m.

New subject: [Bug 1572287] Review Request: nodejs-istanbul-lib-hook - Hooks for require , vm and script used in istanbul

https://bugzilla.redhat.com/show_bug.cgi?id=1572287

Jared Smith jsmith.fedora@gmail.com changed:

--- Comment #7 from Jared Smith jsmith.fedora@gmail.com --- Packaged in Rawhide, closing this issue

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

2629

Age (days ago)

2644

Last active (days ago)

package-review@lists.fedoraproject.org

9 comments

1 participants

tags (0)

participants (1)

bugzilla＠redhat.com