[Bug 878556] New: Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9 - package-review

List overview All Threads
Download

newer

[Bug 878556] New: Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

older

[Bug 996489] New: Review Request:...

[Bug 834127] New: Review Request:...

Red Hat Bugzilla

20 Nov 2012 20 Nov '12

10:55 a.m.

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

Bug ID: 878556 Summary: Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9 Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: tdawson@redhat.com Type: ---

Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov.spec SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov-0.7.1-1.fc18.src.... Description: Code coverage for Ruby 1.9 with a powerful configuration library and automatic merging of coverage across test suites Fedora Account System Username: tdawson

RPMLINT OUTPUT: $ rpmlint rubygem-simplecov.spec rubygem-simplecov-0.7.1-1.fc18.src.rpm rubygem-simplecov-0.7.1-1.fc18.noarch.rpm rubygem-simplecov-doc-0.7.1-1.fc18.noarch.rpm 3 packages and 1 specfiles checked; 0 errors, 0 warnings.

-- You are receiving this mail because: You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

20 Nov 20 Nov

11:32 a.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

Troy Dawson tdawson@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends On| |878515

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

28 Nov 28 Nov

11:27 a.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

Miroslav Suchý msuchy@redhat.com changed:

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

11:57 a.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

--- Comment #1 from Miroslav Suchý msuchy@redhat.com --- Can you please explain?: # Not doing tests, missing config file

Requires should be (to comply with ~> operator):

Requires: rubygem(multi_json) => 1.0 Requires: rubygem(multi_json) < 2.0 Requires: rubygem(simplecov-html) => %{version} Requires: rubygem(simplecov-html) < 0.8

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

5:47 p.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

--- Comment #2 from Troy Dawson tdawson@redhat.com --- I originally was intending to to the tests and made sure all the dependencies were there so the tests would run. But I couldn't ever get it to build in the mock areas or with a regular rpm -ba It would always fail on the tests with No SimpleCov config file found!

I then tried on a regular Fedora 18, installing using just gems, and still couldn't get the test to run without the error

I guess if I just removed all references to the tests, that would be cleaner.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

29 Nov 29 Nov

3:23 a.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

--- Comment #3 from Miroslav Suchý msuchy@redhat.com --- According the code, it is expecting file "simplecov_config". Please contact upstream what should be in that file. And either create it yourself and add it as Source1 or ask upstream to include it in gem.

If tests are provided with gem, they should be run. And I would say this is blocker for this review.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

3:50 p.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

Troy Dawson tdawson@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends On| |878500

--- Comment #4 from Troy Dawson tdawson@redhat.com --- Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov.spec SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov-0.7.1-1.fc18.src....

Turns out I was just running the tests in the wrong directory and they can be run without the configuration file.

Of course, now this depends on a package still under review, rubygem-appraisal. https://bugzilla.redhat.com/show_bug.cgi?id=878500

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

30 Nov 30 Nov

2:35 a.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

--- Comment #5 from Miroslav Suchý msuchy@redhat.com ---

...

%check cd %{buildroot}%{gem_instdir} testrb2 -Ilib test

It is prefered to do: %check pushd .%{gem_instdir} testrb2 -Ilib test popd

Because if that test accidentally change something in files which will land in package, then if you are running the test in %{buildroot}%{gem_instdir}, this change will land in package as will. But if you run it in .%{gem_instdir}, then such accidential change will be isolated. This is behavior "just-in-case".

It is very good habbit to bump up release number for every change of spec.... Ah, you put here wrong link. Ok I deducted: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov-0.7.1-2.fc18.src....

Again: export CONFIGURE_ARGS="--with-cflags='%{optflags}'" # gem install compiles any C extensions and installs into a directory does not have sense here.

Please fix that directory in %check again, and that will be all.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

9:26 a.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

Vít Ondruch vondruch@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com

--- Comment #6 from Vít Ondruch vondruch@redhat.com --- (In reply to comment #4)

...

Of course, now this depends on a package rubygem-appraisal.

Are you sure? I would agree if you are using Rake to execute the test suite, but you aren't.

I did not tried, just asking, because I did similar experience with rubygem-audited.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

10:49 a.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

Troy Dawson tdawson@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends On|878500 |

--- Comment #7 from Troy Dawson tdawson@redhat.com --- Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov.spec SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov-0.7.1-4.fc18.src....

Vit, you are correct. I did a scratch build without rubygem-appraisal and it passed it's tests.

Removed rubygem-appraisal dependancy Removed unneeded C extensions stuff from spec Use pushd and popd in %check section

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

3 Dec 3 Dec

9:55 a.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

--- Comment #8 from Miroslav Suchý msuchy@redhat.com --- Looks much better. But what about license? It seems to me that upstream is using MIT, while you claim GPL or Ruby.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

10:09 a.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

--- Comment #9 from Troy Dawson tdawson@redhat.com --- Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov.spec SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-simplecov-0.7.1-5.fc18.src....

Good catch. Since the rubygems.org page didn't have it listed, I left it at the default until I was able to look at the file. Then it left my mind and I forgot. I have fixed the License to now say MIT.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

12:03 p.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

Miroslav Suchý msuchy@redhat.com changed:

--- Comment #10 from Miroslav Suchý msuchy@redhat.com --- I see no other problem, so: APPROVED.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

1:22 p.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

Troy Dawson tdawson@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #11 from Troy Dawson tdawson@redhat.com --- New Package SCM Request ======================= Package Name: rubygem-simplecov Short Description: Code coverage analysis tool for Ruby 1.9 Owners: tdawson Branches: f18 f17 InitialCC:

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

1:28 p.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

--- Comment #12 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

2:51 p.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

2:51 p.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- rubygem-simplecov-0.7.1-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-simplecov-0.7.1-5.fc18

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

4 Dec 4 Dec

3:15 p.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

3:15 p.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- rubygem-simplecov-0.7.1-5.fc18 has been pushed to the Fedora 18 testing repository.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

7 Dec 7 Dec

10:29 p.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

Bug 878556 depends on bug 878515, which changed state.

Bug 878515 Summary: Review Request: rubygem-simplecov-html - Default HTML formatter for SimpleCov https://bugzilla.redhat.com/show_bug.cgi?id=878515

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UBOnD98d4O&a=cc_unsubscribe

Red Hat Bugzilla

11 Dec 11 Dec

6:29 p.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

Fedora Update System updates@fedoraproject.org changed:

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Mq23msWBJn&a=cc_unsubscribe

Red Hat Bugzilla

6:29 p.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878556

--- Comment #15 from Fedora Update System updates@fedoraproject.org --- rubygem-simplecov-0.7.1-5.fc18 has been pushed to the Fedora 18 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WsDtoAKSpY&a=cc_unsubscribe

Red Hat Bugzilla

3 Nov 3 Nov

12:55 p.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

https://bugzilla.redhat.com/show_bug.cgi?id=878556

Jan Klepek jan.klepek@gmail.com changed:

--- Comment #16 from Jan Klepek jan.klepek@gmail.com --- New Package SCM Request ======================= Package Name: rubygem-simplecov Short Description: Code coverage analysis tool for Ruby 1.9 Owners: hpejakle Branches: el5 el6 InitialCC: tdawson

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

4 Nov 4 Nov

2:38 a.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

https://bugzilla.redhat.com/show_bug.cgi?id=878556

Miroslav Suchý msuchy@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |

--- Comment #17 from Miroslav Suchý msuchy@redhat.com --- You can not request additional branches using new package request. You have to use "change request". See: http://fedoraproject.org/wiki/Package_SCM_admin_requests#Package_Change_Requ...

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2:53 a.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

https://bugzilla.redhat.com/show_bug.cgi?id=878556

Jan Klepek jan.klepek@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #18 from Jan Klepek jan.klepek@gmail.com --- Package SCM Request ======================= Package Name: rubygem-simplecov Short Description: Code coverage analysis tool for Ruby 1.9 Owners: hpejakle Branches: el5 el6 InitialCC: tdawson

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:02 a.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

https://bugzilla.redhat.com/show_bug.cgi?id=878556

--- Comment #19 from Jan Klepek jan.klepek@gmail.com --- Package Change Request ====================== Package Name: rubygem-simplecov Short Description: Code coverage analysis tool for Ruby 1.9 Owners: hpejakle Branches: el5 el6 InitialCC: tdawson

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:43 a.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

https://bugzilla.redhat.com/show_bug.cgi?id=878556

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:44 a.m.

New subject: [Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

https://bugzilla.redhat.com/show_bug.cgi?id=878556

--- Comment #20 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

Correctly formatted branches.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

4278

Age (days ago)

4627

Last active (days ago)

package-review@lists.fedoraproject.org

27 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla