[Bug 490204] New: Review Request: mingw32-qt-qmake - build environment for Qt for MinGW applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: mingw32-qt-qmake - build environment for Qt for MinGW applications
Alias: mingw32-qt-qmake

https://bugzilla.redhat.com/show_bug.cgi?id=490204

Summary: Review Request: mingw32-qt-qmake - build environment
                    for Qt for MinGW applications
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
            Blocks: 490132
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://sailer.fedorapeople.org/mingw32-qt-qmake.spec
SRPM URL: http://sailer.fedorapeople.org/mingw32-qt-qmake-4.5.0-1.fc11.src.rpm
Description:
MinGW Qt library Build Environment (qmake config).

Approved MinGW packaging guidelines are here:
http://fedoraproject.org/wiki/Packaging/MinGW

It has been suggested in bug #490132 that the qmake config files, which are
installed to %{_libdir}, should be factored out into a separate package, to
keep the huge mingw32-qt noarch. This is the factored-out package.

[Bug 490204] Review Request: mingw32-qt-qmake - build environment for Qt for MinGW applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=490204

Richard W.M. Jones  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 490204] Review Request: mingw32-qt-qmake - build environment for Qt for MinGW applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=490204

Richard W.M. Jones  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

--- Comment #1 from Richard W.M. Jones   2009-03-13 15:53:40 EDT ---
Taking for review.

[Bug 490204] Review Request: mingw32-qt-qmake - build environment for Qt for MinGW applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=490204

--- Comment #2 from Richard W.M. Jones   2009-03-13 15:54:49 EDT ---
auto-buildrequires looks OK:

BuildRequires: binutils = 2.19.51.0.2.16.fc11.x86_64
BuildRequires: coreutils = 7.1.6.fc11.x86_64
BuildRequires: diffutils = 2.8.1.23.fc11.x86_64
BuildRequires: findutils = 1:4.4.0.2.fc11.x86_64
BuildRequires: grep = 2.5.3.4.fc11.x86_64
BuildRequires: mingw32-filesystem = 49.3.fc11.noarch
BuildRequires: sed = 4.1.5.12.fc11.x86_64

[Bug 490204] Review Request: mingw32-qt-qmake - build environment for Qt for MinGW applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=490204

--- Comment #3 from Richard W.M. Jones   2009-03-13 15:56:04 EDT ---
rpmlint says:

mingw32-qt-qmake.x86_64: W: no-documentation

Consider adding %doc, although I won't disapprove the review
for lack of this.

mingw32-qt-qmake.x86_64: E: devel-dependency qt-devel

This is OK.

mingw32-qt-qmake.x86_64: E: no-binary

Also OK.

mingw32-qt-qmake.x86_64: E: only-non-binary-in-usr-lib

Also OK (in this case).

[Bug 490204] Review Request: mingw32-qt-qmake - build environment for Qt for MinGW applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=490204

Richard W.M. Jones  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Richard W.M. Jones   2009-03-13 15:58:01 EDT ---
This is an extremely simple package which just installs
two %{SOURCE*} files into a specific location, as required
by the mingw32-qt.noarch package.

The package complies with Fedora packaging guidelines, and
is APPROVED by rjones.

[Bug 490204] Review Request: mingw32-qt-qmake - build environment for Qt for MinGW applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=490204

Thomas Sailer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #5 from Thomas Sailer   2009-03-13 16:05:00 EDT ---
New Package CVS Request
=======================
Package Name: mingw32-qt-qmake
Short Description: Qt for MinGW32 Build Environment
Owners: sailer rjones
Branches: 
InitialCC:

[Bug 490204] Review Request: mingw32-qt-qmake - build environment for Qt for MinGW applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=490204

--- Comment #6 from Thomas Sailer   2009-03-13 16:06:25 EDT ---
Thanks!

Hm, what documentation would you expect? I'm having troubles coming up with
reasonable documentation for this package...

Or should I put an AUTHORS file in there containing RMW Jones? :)

[Bug 490204] Review Request: mingw32-qt-qmake - build environment for Qt for MinGW applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=490204

--- Comment #7 from Richard W.M. Jones   2009-03-13 16:18:26 EDT ---
Normally you'd just put a license file there.

I "wrote" this, but in fact I derived it from existing files
in the Qt distribution, so the correct way to do this is to
add the license file from Qt here.

[Bug 490204] Review Request: mingw32-qt-qmake - build environment for Qt for MinGW applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=490204

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #8 from Kevin Fenzi   2009-03-15 22:00:19 EDT ---
cvs done.

[Bug 490204] Review Request: mingw32-qt-qmake - build environment for Qt for MinGW applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=490204

Thomas Sailer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #9 from Thomas Sailer   2009-03-15 23:10:11 EDT ---
License file put into the package, and built for rawhide.