[Bug 540653] New: Review Request: jazzy - Java-based spell checker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: jazzy - Java-based spell checker

https://bugzilla.redhat.com/show_bug.cgi?id=540653

Summary: Review Request: jazzy - Java-based spell checker
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

SPEC: http://v3.sk/~lkundrak/SPECS/jazzy.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/jazzy-0.5.2-1.fc13.src.rpm
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1825998

Description:

Jazzy is a pure Java library implementing a spell checking algorithm
similar to aspell. It may be used to spell check a variety of sources.

[Bug 540653] Review Request: jazzy - Java-based spell checker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=540653

--- Comment #1 from Lubomir Rintel   2009-11-23 16:40:13 EDT ---
RPMlint mostly silent, only complains about "aspell" not being correct en_US.

[Bug 540653] Review Request: jazzy - Java-based spell checker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=540653

Lubomir Rintel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |F13FeatureIDEA

[Bug 540653] Review Request: jazzy - Java-based spell checker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=540653

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 540653] Review Request: jazzy - Java-based spell checker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=540653

--- Comment #2 from Alexander Kurtakov   2009-11-26 08:04:18 EDT ---
First sight:
You need to change  
VER=$(echo $BASE |sed 's/.jar$/%{version}.jar/') to
VER=$(echo $BASE |sed 's/.jar$/-%{version}.jar/') 
Note the dash before version it is needed to be that way to keep jpackage
scripts differentiating versioned and non-versioned jars.

[Bug 540653] Review Request: jazzy - Java-based spell checker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=540653

--- Comment #3 from Alexander Kurtakov   2009-11-30 06:14:12 EDT ---
OK: rpmlint must be run on every package. The output should be posted in the
review.
OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. 
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license. 
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English. 
OK: The spec file for the package MUST be legible. 
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. 
OK: All build dependencies must be listed in BuildRequires
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory. 
OK: A Fedora package must not list a file more than once in the spec file's
%files listings. 
OK: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK: Each package must have a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). 
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content. 
OK: Large documentation files must go in a -doc subpackage. 
OK: If a package includes something as %doc, it must not affect the runtime of
the application. To summarize: If it is in %doc, the program must run properly
if it is not present. 
OK: Packages must not own files or directories already owned by other packages.
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT). [26]
OK: All filenames in rpm packages must be valid UTF-8. [27]

Once the issue in comment #2 is fixed package is APPROVED.

[Bug 540653] Review Request: jazzy - Java-based spell checker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=540653

--- Comment #4 from Lubomir Rintel   2009-11-30 07:04:20 EDT ---
Thank you. New package:

SPEC: http://v3.sk/~lkundrak/SPECS/jazzy.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/jazzy-0.5.2-2.fc12.src.rpm

[Bug 540653] Review Request: jazzy - Java-based spell checker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=540653

Alexander Kurtakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #5 from Alexander Kurtakov   2009-11-30 07:16:26 EDT ---
Thanks, APPROVED.

[Bug 540653] Review Request: jazzy - Java-based spell checker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=540653

Lubomir Rintel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #6 from Lubomir Rintel   2009-11-30 08:03:38 EDT ---
New Package CVS Request
=======================
Package Name: jazzy
Short Description: Java-based spellchecker
Owners: lkundrak
Branches: F-11 F-12 EL-5

[Bug 540653] Review Request: jazzy - Java-based spell checker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=540653

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #7 from Kevin Fenzi   2009-12-03 01:40:21 EDT ---
cvs done.

[Bug 540653] Review Request: jazzy - Java-based spell checker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=540653

Lubomir Rintel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #8 from Lubomir Rintel   2009-12-03 04:56:55 EDT ---
Imported and built.
Thanks for review and cvs!