Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202670
Summary: Review Request: bygfoot - Football Manager Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mr.ecik@gmail.com QAContact: fedora-package-review@redhat.com
Spec URL: http://ecik.zspswidwin.pl/bygfoot/bygfoot.spec SRPM URL: http://ecik.zspswidwin.pl/bygfoot/bygfoot-2.0.0-1.src.rpm Description: Bygfoot is a small and simple graphical football (a.k.a. soccer) manager game featuring many international leagues and cups.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bygfoot - Football Manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202670
paul@all-the-johnsons.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |paul@all-the-johnsons.co.uk
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bygfoot - Football Manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202670
paul@all-the-johnsons.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-08-15 16:26 EST ------- I'll give this a look over :-)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bygfoot - Football Manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202670
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-08-17 17:32 EST ------- Good
Software works! rpmlint is clean on all packages and subpackages builds cleanly in mock no duplicates in the rpm consistent use of macros in the spec file spec file is in american english upstream version same as this version md5sums match no ownership problems correct use of scripts Docs okay
Needs work
%files %{_bindir}/*
If you change this to %{_bindir}/bygfoot*
then I'm happy to FE-APPROVE this
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bygfoot - Football Manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202670
------- Additional Comments From mr.ecik@gmail.com 2006-08-17 17:43 EST ------- Corrected SPEC file: http://ecik.zspswidwin.pl/bygfoot/bygfoot.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bygfoot - Football Manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202670
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-08-17 18:01 EST ------- What is pkgconfig in there for?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bygfoot - Football Manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202670
------- Additional Comments From mr.ecik@gmail.com 2006-08-17 18:05 EST ------- (In reply to comment #4)
What is pkgconfig in there for?
I don't know, but it is needed for fine mock build.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bygfoot - Football Manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202670
paul@all-the-johnsons.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-08-17 18:12 EST ------- Wierd!
I've checked in mock and you're right.
APPROVED
Don't forget to close the bug and set it as NEXT-RELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bygfoot - Football Manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202670
------- Additional Comments From paul@city-fan.org 2006-08-18 03:33 EST ------- (In reply to comment #5)
(In reply to comment #4)
What is pkgconfig in there for?
I don't know, but it is needed for fine mock build.
I'm unable to reproduce an issue with this. I removed the buildreq of pkgconfig and it still got pulled in properly as a dependency of other buildrequired packages when running mock builds on FC5.x86_64 and FC6.i386.
Where is the failure happening when you guys tried this?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bygfoot - Football Manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202670
------- Additional Comments From mr.ecik@gmail.com 2006-08-18 05:30 EST ------- (In reply to comment #7)
I'm unable to reproduce an issue with this. I removed the buildreq of
pkgconfig
and it still got pulled in properly as a dependency of other buildrequired packages when running mock builds on FC5.x86_64 and FC6.i386.
Where is the failure happening when you guys tried this?
I realized why you're unable to reproduce that issue. I notice that pkgconfig is installed as a dependency for gtk2-devel, gettext or desktop-file-utils. This is mock build report:
============================================================================= Package Arch Version Repository Size ============================================================================= Installing: desktop-file-utils x86_64 0.10-6.1 core 62 k gettext x86_64 0.14.5-3 core 1.4 M gtk2-devel x86_64 2.8.15-1 core 2.7 M Installing for dependencies: atk x86_64 1.11.3-1 core 209 k atk-devel x86_64 1.11.3-1 core 104 k ....... ....... pkgconfig x86_64 1:0.20-2.2.1 core 61 k
So probably we can delete pkgconfig BR. I can do it in next release.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bygfoot - Football Manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202670
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-08-18 05:40 EST ------- I think it may be down to my i386 buildsys, but it gtk2-devel wasn't dragging in pkgconfig.
I'll need to check at home in case there is a conflict somewhere.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bygfoot - Football Manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202670
------- Additional Comments From paul@city-fan.org 2006-08-18 06:26 EST ------- (In reply to comment #9)
I think it may be down to my i386 buildsys, but it gtk2-devel wasn't dragging in pkgconfig.
I'll need to check at home in case there is a conflict somewhere.
There's something wrong there because gtk2-devel requires glib2-devel, which in turn requires pkgconfig >= 1:0.8
The pkgconfig in FC5 is 1:0.20, which should be pulled in by this dependency.
The same dependency chain is there in rawhide too.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bygfoot - Football Manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202670
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-08-20 11:46 EST ------- Checked, it seems to be a problem at my end. pkgconfig is not required. You can remove it safely.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bygfoot - Football Manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202670
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-08-23 06:09 EST ------- Anything happening with this bug?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bygfoot - Football Manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202670
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-08-31 18:24 EST ------- If this package has been included, could you please close this bug and mark it as NEXTRELEASE?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bygfoot - Football Manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202670
mr.ecik@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From mr.ecik@gmail.com 2006-09-04 13:25 EST ------- I was on vacation. Now, I'm closing it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bygfoot - Football Manager
https://bugzilla.redhat.com/show_bug.cgi?id=202670
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla