Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249524
Summary: Review Request: wxdfast - Multi-threaded download manager Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: adel.gadllah@gmail.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://tgmweb.at/gadllah/wxdfast.spec SRPM URL: http://tgmweb.at/gadllah/wxdfast-0.6.0-1.fc7.src.rpm Description: wxDownload Fast (also known as wxDFast) is an open source multi-threaded download manager.This means that it can split a file into several pieces and download the pieces simultaneously
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: wxdfast - Multi-threaded download manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249524
adel.gadllah@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |163776 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: wxdfast - Multi-threaded download manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249524
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163776 | nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: wxdfast - Multi-threaded download manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249524
dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |dan@danny.cz Flag| |fedora-review?
------- Additional Comments From dan@danny.cz 2007-08-22 03:34 EST ------- some notes from testing before formal review: - update license tag GPL => GPLv2, icons are using Creative Commons Public License - in %build - using %configure is enough, no need to set prefix, ..., no need to explicitly set CXXFLAGS for make - remove execute bit from source files (find + xargs chmod a-x) - debug package does not contain the sources (tested in mock for Rawhide/i386 and natively on FC6/x86_64)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: wxdfast - Multi-threaded download manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249524
------- Additional Comments From dan@danny.cz 2007-08-22 04:35 EST ------- Sorry, overwriting the CXXFLAGS is necessary. Only in the top-level makefile they are OK. The debug package is created correctly too. But I have a solution that can be posted upstream, see attachments.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: wxdfast - Multi-threaded download manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249524
------- Additional Comments From dan@danny.cz 2007-08-22 04:36 EST ------- Created an attachment (id=162036) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=162036&action=vie...) patch for Makefile.*
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: wxdfast - Multi-threaded download manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249524
------- Additional Comments From dan@danny.cz 2007-08-22 04:36 EST ------- Created an attachment (id=162037) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=162037&action=vie...) spec file patch
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: wxdfast - Multi-threaded download manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249524
------- Additional Comments From adel.gadllah@gmail.com 2007-08-22 05:08 EST ------- hi thx for the patches I applied them, new package here: http://tgmweb.at/gadllah/wxdfast.spec http://tgmweb.at/gadllah/wxdfast-0.6.0-2.fc7.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: wxdfast - Multi-threaded download manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249524
------- Additional Comments From dan@danny.cz 2007-08-23 01:50 EST ------- there is a typo in the spec file when doing chmod a-x - there is *.cpp twice
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: wxdfast - Multi-threaded download manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249524
------- Additional Comments From adel.gadllah@gmail.com 2007-08-23 07:35 EST ------- Fixed package is here: http://tgmweb.at/gadllah/wxdfast.spec http://tgmweb.at/gadllah/wxdfast-0.6.0-3.fc7.src.rpm also some .h files needed fixing added that too.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: wxdfast - Multi-threaded download manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249524
------- Additional Comments From dan@danny.cz 2007-08-23 16:18 EST ------- the review is here:
OK source files match upstream: 09f8a13c399e6e8f40e9b0a2776acd4133f0f1f6 wxdfast_0.6.0.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible. License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock (Development/i386). OK debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane: OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK is a GUI app and correctly install its desktop file
this package is APPROVED
PS: are you aware of the many unresolved bugs in the project's sf.net bugtracker?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: wxdfast - Multi-threaded download manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249524
dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: wxdfast - Multi-threaded download manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249524
------- Additional Comments From adel.gadllah@gmail.com 2007-08-23 17:04 EST -------
this package is APPROVED
ok, thx for the review.
PS: are you aware of the many unresolved bugs in the project's sf.net bugtracker?
no was working quite good for me (no issues yet) but thx will look at them.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: wxdfast - Multi-threaded download manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249524
adel.gadllah@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From adel.gadllah@gmail.com 2007-08-23 17:07 EST ------- New Package CVS Request ======================= Package Name: wxdfast Short Description: Multi-threaded download manager Owners: drago01 Branches: FC-6 F7 devel InitialCC: Cvsextras Commits: no
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: wxdfast - Multi-threaded download manager
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249524
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-08-24 11:32 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: wxdfast - Multi-threaded download manager
https://bugzilla.redhat.com/show_bug.cgi?id=249524
------- Additional Comments From dan@danny.cz 2007-09-09 05:02 EST ------- you should close this bug, as the package is already built
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: wxdfast - Multi-threaded download manager
https://bugzilla.redhat.com/show_bug.cgi?id=249524
adel.gadllah@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From adel.gadllah@gmail.com 2007-09-09 05:06 EST ------- sorry was waiting for the update push to be able to build it for fc6 then I forgot to close the bug.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla