https://bugzilla.redhat.com/show_bug.cgi?id=2184723
Bug ID: 2184723 Summary: Review Request: rust-gdk4-x11 - Rust bindings of the GDK4 X11 library Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: klember@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://kalev.fedorapeople.org/rust-gdk4-x11.spec SRPM URL: https://kalev.fedorapeople.org/rust-gdk4-x11-0.6.3-1.fc39.src.rpm Description: Rust bindings of the GDK4 X11 library. Fedora Account System Username: kalev
https://bugzilla.redhat.com/show_bug.cgi?id=2184723
Kalev Lember klember@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2184720
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2184720 [Bug 2184720] Review Request: rust-gdk4-x11-sys - FFI bindings of GDK4 X11
https://bugzilla.redhat.com/show_bug.cgi?id=2184723
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/gd | |k4-x11
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5745884 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2184723
Kalev Lember klember@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2184729
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2184729 [Bug 2184729] Review Request: rust-ashpd - XDG portals wrapper in Rust using zbus
https://bugzilla.redhat.com/show_bug.cgi?id=2184723 Bug 2184723 depends on bug 2184720, which changed state.
Bug 2184720 Summary: Review Request: rust-gdk4-x11-sys - FFI bindings of GDK4 X11 https://bugzilla.redhat.com/show_bug.cgi?id=2184720
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2184723
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |decathorpe@gmail.com CC| |decathorpe@gmail.com Flags| |fedora-review? Status|NEW |ASSIGNED
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Similar to 2184722, there seem to be subpackages for features that are missing:
- dox - egl - khronos-egl
What's the reason for dropping these? And are you sure you don't need this functionality?
https://bugzilla.redhat.com/show_bug.cgi?id=2184723
--- Comment #3 from Kalev Lember klember@redhat.com --- We are missing some deps - the egl crate at least, if I remember right. I just wanted to get a subset in first and then look at adding more optional features.
https://bugzilla.redhat.com/show_bug.cgi?id=2184723
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=2184723
--- Comment #5 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gdk4-x11
https://bugzilla.redhat.com/show_bug.cgi?id=2184723
--- Comment #6 from Kalev Lember klember@redhat.com --- Thanks for the review! Package imported and rawhide build under way.
https://bugzilla.redhat.com/show_bug.cgi?id=2184723
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-b9ef0d74c5 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b9ef0d74c5
https://bugzilla.redhat.com/show_bug.cgi?id=2184723
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2023-04-27 11:10:09
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-b9ef0d74c5 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org