[Bug 1781071] New: Rename Review Request: xe-guest-utilities-latest - XAPI Virtual Machine Monitoring Scripts
https://bugzilla.redhat.com/show_bug.cgi?id=1781071
Bug ID: 1781071 Summary: Rename Review Request: xe-guest-utilities-latest - XAPI Virtual Machine Monitoring Scripts Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: robinlee.sysu@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://cheeselee.fedorapeople.org/xe-guest-utilities-latest.spec SRPM URL: https://cheeselee.fedorapeople.org/xe-guest-utilities-latest-7.16.0-1.fc30.s... Description: Scripts for monitoring XAPI project virtual machine.
Writes distribution version information and IP address to XenStore.
This package follows the latest version of xe-guest-utilities upstream.
Fedora Account System Username: cheeselee
This review is for renaming xe-guest-utilities to xe-guest-utilities-latest, to not conflict with the xe-guest-utilities package provided in Citrix Hypervisor.
https://bugzilla.redhat.com/show_bug.cgi?id=1781071
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - Latest version is 7.17.0
- Update GO_FLAGS to latest version:
GO_FLAGS='-a -ldflags "-B 0x$$(head -c20 /dev/urandom|od -An -tx1|tr -d '"'"' \n'"'"')" -v -x'
→
GO_FLAGS='-a -ldflags "${LDFLAGS:-}%{?currentgoldflags} -B 0x$$(head -c20 /dev/urandom|od -An -tx1|tr -d '"'"' \n'"'"') -extldflags '"'"'%__global_ldflags %{?__golang_extldflags}'"'"'" -v -x'
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/xe-guest-utilities-latest/review-xe-guest- utilities-latest/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/libexec/xe-guest- utilities(Failed, xe-guest-utilities, locale,, defaulting, C, to, set), /usr/share/licenses/xe-guest-utilities-latest(Failed, locale,, defaulting, C, to, set) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in xe-guest-utilities-latest [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: xe-guest-utilities-latest-7.17.0-1.fc32.x86_64.rpm xe-guest-utilities-latest-debuginfo-7.17.0-1.fc32.x86_64.rpm xe-guest-utilities-latest-debugsource-7.17.0-1.fc32.x86_64.rpm xe-guest-utilities-latest-7.17.0-1.fc32.src.rpm xe-guest-utilities-latest.x86_64: W: obsolete-not-provided xe-guest-utilities xe-guest-utilities-latest.x86_64: E: statically-linked-binary /usr/sbin/xe-daemon xe-guest-utilities-latest.x86_64: W: no-documentation xe-guest-utilities-latest.x86_64: W: no-manual-page-for-binary xe-daemon xe-guest-utilities-latest.x86_64: W: no-manual-page-for-binary xe-linux-distribution xe-guest-utilities-latest.x86_64: W: dangerous-command-in-%trigger rm 4 packages and 0 specfiles checked; 1 errors, 5 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1781071
--- Comment #2 from Robin Lee robinlee.sysu@gmail.com --- Spec URL: https://cheeselee.fedorapeople.org/xe-guest-utilities-latest.spec SRPM URL: https://cheeselee.fedorapeople.org/xe-guest-utilities-latest-7.17.0-1.fc30.s...
* Wed Dec 11 2019 Robin Lee cheeselee@fedoraproject.org - 7.17.0-1 - Release 7.17.0 - Update GO_FLAGS
https://bugzilla.redhat.com/show_bug.cgi?id=1781071
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1781071
--- Comment #4 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/xe-guest-utilities-latest
https://bugzilla.redhat.com/show_bug.cgi?id=1781071
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2019-8797182132 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8797182132
https://bugzilla.redhat.com/show_bug.cgi?id=1781071
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- xe-guest-utilities-latest-7.17.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-f0dfb13eeb
https://bugzilla.redhat.com/show_bug.cgi?id=1781071
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- xe-guest-utilities-latest-7.17.0-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8797182132
https://bugzilla.redhat.com/show_bug.cgi?id=1781071
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2019-cb0c069998 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-cb0c069998
https://bugzilla.redhat.com/show_bug.cgi?id=1781071
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- xe-guest-utilities-latest-7.17.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-cb0c069998
https://bugzilla.redhat.com/show_bug.cgi?id=1781071
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2019-cb0c069998 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-cb0c069998
https://bugzilla.redhat.com/show_bug.cgi?id=1781071
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- xe-guest-utilities-latest-7.17.0-2.el8 has been pushed to the Fedora EPEL 8 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-7304986fad
https://bugzilla.redhat.com/show_bug.cgi?id=1781071
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- xe-guest-utilities-latest-7.17.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-cb0c069998
https://bugzilla.redhat.com/show_bug.cgi?id=1781071
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2020-01-04 20:08:12
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- xe-guest-utilities-latest-7.17.0-2.el8 has been pushed to the Fedora EPEL 8 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1781071
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- xe-guest-utilities-latest-7.17.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com