Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=266001
Summary: Review Request: webunit - Python web testing framework Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mike@flyn.org QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://www.flyn.org/SRPMS/webunit.spec SRPM URL: http://www.flyn.org/SRPMS/webunit-0.4-1.src.rpm Description: A framework for performing client-side tests of web applications, based on PyUnit.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: webunit - Python web testing framework
https://bugzilla.redhat.com/show_bug.cgi?id=266001
mike@flyn.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=266001
--- Comment #1 from Jason Tibbitts tibbs@math.uh.edu 2009-07-17 12:42:49 EDT --- I just saw this ticket, which nobody has looked at because you set the fedora-review flag when you submitted it so it never appeared in the review queue.
If you still want to submit this package, please clear the fedora-review tag and bring the package up to today's packaging guidelines. And you should probably make the package noarch as well, because I can't see any reason for it to be arch-specific.
webunit.x86_64: E: description-line-too-long A framework for performing client-side tests of web applications, based on PyUnit. webunit.x86_64: W: invalid-license LGPL webunit.x86_64: E: no-binary webunit.x86_64: E: non-executable-script /usr/lib/python2.6/site-packages/httpsession.py 0644 webunit-debuginfo.x86_64: W: invalid-license LGPL webunit-debuginfo.x86_64: E: empty-debuginfo-package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=266001
--- Comment #2 from W. Michael Petullo mike@flyn.org 2009-07-17 20:29:37 EDT --- Spec URL: http://www.flyn.org/SRPMS/webunit.spec SRPM URL: http://www.flyn.org/SRPMS/webunit-0.4-2.fc11.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=266001
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@bernewireless.net
--- Comment #3 from Fabian Affolter fabian@bernewireless.net 2009-08-03 07:07:38 EDT --- Some comment after a quick look at your spec file.
- Don't mix '$RPM_BUILD_ROOT' and '%{buildroot}'
http://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_... - README is missing in %doc - Is there any note about the license in the source?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=266001
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(mike@flyn.org)
--- Comment #4 from Fabian Affolter fabian@bernewireless.net 2009-09-18 03:25:37 EDT --- Mike, do you still want to proceed with this review request?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=266001
W. Michael Petullo mike@flyn.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(mike@flyn.org) |
--- Comment #5 from W. Michael Petullo mike@flyn.org 2009-09-18 20:00:03 EDT --- This project's license is documented as LGPL at http://sourceforge.net/projects/webunit/develop/.
Spec URL: http://www.flyn.org/SRPMS/webunit.spec SRPM URL: http://www.flyn.org/SRPMS/webunit-0.4-3.fc11.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=266001
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |fabian@bernewireless.net Flag|fedora-review? |
--- Comment #6 from Fabian Affolter fabian@bernewireless.net 2009-12-23 06:52:50 EDT --- - Do you really need 'python_sitearch'? I guess that this is a left-over from the template. - Can you please preserve the timestamps in the install section? https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps
The biggest issue is still the missing license statement.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=266001
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=266001
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #7 from Fabian Affolter fabian@bernewireless.net 2009-12-23 08:12:43 EDT --- Upstream closed the bug [1] about the license as 'wont fix'.
[1] https://sourceforge.net/tracker/?func=browse&group_id=20323&atid=120...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=266001
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW CC|fabian@bernewireless.net | AssignedTo|fabian@bernewireless.net |nobody@fedoraproject.org Flag|fedora-review? |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=266001
--- Comment #8 from W. Michael Petullo mike@flyn.org 2010-02-14 16:45:40 EST --- Spec URL: http://www.flyn.org/SRPMS/webunit.spec SRPM URL: http://www.flyn.org/SRPMS/webunit-0.4-4.fc12.src.rpm
- Remove python_sitearch. - Preserve timestaps when using install.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=266001
Steve Traylen steve.traylen@cern.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |steve.traylen@cern.ch
--- Comment #9 from Steve Traylen steve.traylen@cern.ch 2010-03-05 15:31:20 EST ---
I can't see any license statement anywhere? How do you derive that its LGPLv2
also there some rpmlint errors that can definitely be fixed:
webunit.spec:44: W: macro-in-%changelog %{buildroot} webunit.src:44: W: macro-in-%changelog %{buildroot} webunit.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/httpsession.py 0644L /usr/bin/env 2 packages and 1 specfiles checked; 1 errors, 2 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=266001
--- Comment #10 from W. Michael Petullo mike@flyn.org 2010-03-05 20:35:50 EST --- Spec URL: http://www.flyn.org/SRPMS/webunit.spec SRPM URL: http://www.flyn.org/SRPMS/webunit-0.4-5.fc12.src.rpm
- Fix macro in changelog - Chmod httpsession.py 755
As stated in comment #5, the license is noted at the project's SourceForge site.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=266001
--- Comment #11 from Steve Traylen steve.traylen@cern.ch 2010-03-21 11:33:25 EDT --- Copy and paste messages you sent to and from upstream about the license as comments into the .spec file.
Then the licensing is clear where it comes from.
Steve.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=266001
--- Comment #12 from W. Michael Petullo mike@flyn.org 2010-03-21 13:46:39 EDT --- Spec URL: http://www.flyn.org/SRPMS/webunit.spec SRPM URL: http://www.flyn.org/SRPMS/webunit-0.4-6.fc12.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=266001
Thomas Spura tomspur@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tomspur@fedoraproject.org
--- Comment #13 from Thomas Spura tomspur@fedoraproject.org 2010-04-25 20:24:09 EDT --- To be honest:
Is it worth to get a package into fedora, which is not actively maintained? (Tarball 8 years old, last commit in svn 4 years old) Or do you want to become the new maintainer and further improve/develop this?
It looks like this could work on python3 (just looked at the source, untested), maybe you could do a subpackage as described in https://fedoraproject.org/wiki/Packaging:Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=266001
Thomas Spura tomspur@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(mike@flyn.org)
--- Comment #14 from Thomas Spura tomspur@fedoraproject.org 2010-10-26 07:50:51 EDT --- Ping, I'll close this soon, when no response by the reporter...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=266001
Thomas Spura tomspur@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Blocks| |201449(FE-DEADREVIEW) Resolution| |NOTABUG AssignedTo|nobody@fedoraproject.org |tomspur@fedoraproject.org Flag|needinfo?(mike@flyn.org) | Last Closed| |2010-11-02 12:43:48
--- Comment #15 from Thomas Spura tomspur@fedoraproject.org 2010-11-02 12:43:48 EDT --- http://fedoraproject.org/wiki/Extras/Policy/StalledReviews#Submitter_not_res...
package-review@lists.fedoraproject.org