https://bugzilla.redhat.com/show_bug.cgi?id=847512
Bug ID: 847512 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: mailnag - Mail notification daemon for GNOME 3 Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: fedora@leemhuis.info Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://www.leemhuis.info/files/fedora/mailnag.spec SRPM URL: http://www.leemhuis.info/files/fedora/mailnag-0.4.2-1.fc17.src.rpm
Description: Mailnag checks POP3 and IMAP servers for new mail and when it finds one creates a proper GNOME 3 notification that mentions sender and subject.
Fedora Account System Username: thl
Haven't submitted a package for a while; nevertheless I hope the spec file won't have to many mistakes ;-)
$ rpmlint /home/thl/rpmbuild/SRPMS/mailnag-0.4.2-1.fc17.src.rpm /home/thl/rpmbuild/RPMS/noarch/mailnag-0.4.2-1.fc17.noarch.rpm mailnag.noarch: E: explicit-lib-dependency python-httplib2 mailnag.noarch: W: no-manual-page-for-binary mailnag_config mailnag.noarch: W: no-manual-page-for-binary mailnag
I think the error can be ignored here; or is there a better way to express a dependency on python-httplib2?
https://bugzilla.redhat.com/show_bug.cgi?id=847512
Adrian Reber adrian@lisas.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |adrian@lisas.de Flags| |fedora-review+
--- Comment #1 from Adrian Reber adrian@lisas.de --- Haven't reviewed a package for a while... But here you go:
fedora-review seems happy with only one 'Fail':
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5
Probably not relevant as there is no GNOME 3 for EPEL5.
mailnag.noarch: E: explicit-lib-dependency python-httplib2
Other python.noarch packages are doing the same, so this seems the way to go.
MD5-sum check ------------- https://github.com/downloads/pulb/mailnag/mailnag-0.4.2.tar.gz : MD5SUM this package : 998666618dd0a4e23d3d11752262efac MD5SUM upstream package : 998666618dd0a4e23d3d11752262efac
Package ACCEPTed.
I will attach a small patch which enables the use of non standard IMAP ports. All my IMAP connections are tunneled through SSH and are using non standard ports and mailnag did not work for me without the patch.
https://bugzilla.redhat.com/show_bug.cgi?id=847512
--- Comment #2 from Adrian Reber adrian@lisas.de --- Created attachment 604000 --> https://bugzilla.redhat.com/attachment.cgi?id=604000&action=edit patch for non-standard IMAP ports
https://bugzilla.redhat.com/show_bug.cgi?id=847512
--- Comment #3 from Thorsten Leemhuis fedora@leemhuis.info --- hey, great, many thx; will import later and submit patch upstream
https://bugzilla.redhat.com/show_bug.cgi?id=847512
Thorsten Leemhuis fedora@leemhuis.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from Thorsten Leemhuis fedora@leemhuis.info --- New Package SCM Request ======================= Package Name: mailnag Short Description: Mail notification daemon for GNOME 3 Owners: thl Branches: f17 f18 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=847512
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Adrian, please take ownership of review BZs, thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=847512
Adrian Reber adrian@lisas.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |adrian@lisas.de
https://bugzilla.redhat.com/show_bug.cgi?id=847512
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=847512
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- mailnag-0.4.2-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/mailnag-0.4.2-2.fc17
https://bugzilla.redhat.com/show_bug.cgi?id=847512
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- Package mailnag-0.4.2-2.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing mailnag-0.4.2-2.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-11855/mailnag-0.4.2-2.fc... then log in and leave karma (feedback).
https://bugzilla.redhat.com/show_bug.cgi?id=847512
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2012-08-25 20:22:50
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- mailnag-0.4.2-2.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla