[Bug 590777] New: Review Request: php-domxml-php4-php5 - XML transition from PHP4 domxml to PHP5 dom module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: php-domxml-php4-php5 - XML transition from PHP4 domxml to PHP5 dom module
https://bugzilla.redhat.com/show_bug.cgi?id=590777
Summary: Review Request: php-domxml-php4-php5 - XML transition from PHP4 domxml to PHP5 dom module Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: fedora@famillecollet.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://github.com/remicollet/remirepo/blob/master/php-domxml-php4-php5/php-d... SRPM URL: http://remi.fedorapeople.org/php-domxml-php4-php5-1.21.1-1.remi.src.rpm Description: XML transition from PHP4 domxml to PHP5 dom module.
Taking over #549604 This small library is embeded by some other PHP packages.
From rpmlint:
php-domxml-php4-php5.src: W: invalid-url Source0: domxml-php4-php5-1.21.1.tar.gz => see comment (howto create a simple tarball) php-domxml-php4-php5.noarch: W: no-documentation => nothing provided upstream
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2177862
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590777
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |eric@christensenplace.us
--- Comment #1 from Remi Collet fedora@famillecollet.com 2010-05-10 12:54:31 EDT --- *** Bug 549604 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590777
Johan Cwiklinski johan@x-tnd.be changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |johan@x-tnd.be AssignedTo|nobody@fedoraproject.org |johan@x-tnd.be Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590777
--- Comment #2 from Johan Cwiklinski johan@x-tnd.be 2010-05-15 03:46:05 EDT --- Just a quick note, license should be LGPLv3+ instead of LGPLv3 according to source file header.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590777
--- Comment #3 from Remi Collet fedora@famillecollet.com 2010-05-15 05:21:35 EDT --- Changes: http://github.com/remicollet/remirepo/commit/0a4e160010cbc9adde925e86404df5b... New Spec: http://github.com/remicollet/remirepo/blob/master/php-domxml-php4-php5/php-d... SRPM : http://remi.fedorapeople.org/php-domxml-php4-php5-1.21.1-2.remi.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590777
Johan Cwiklinski johan@x-tnd.be changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #4 from Johan Cwiklinski johan@x-tnd.be 2010-05-15 05:40:01 EDT --- REVIEW: + rpmlint is clean php-domxml-php4-php5.src: I: checking => (false spelling-error from french removed and ignored) php-domxml-php4-php5.src: I: checking-url http://alexandre.alapetite.fr/doc-alex/domxml-php4-php5 (timeout 10 seconds) php-domxml-php4-php5.src: W: invalid-url Source0: domxml-php4-php5-1.21.1.tar.gz php-domxml-php4-php5.noarch: I: checking => (false spelling-error from french removed and ignored) php-domxml-php4-php5.noarch: I: checking-url http://alexandre.alapetite.fr/doc-alex/domxml-php4-php5 (timeout 10 seconds) php-domxml-php4-php5.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 12 warnings. + package is named according to the Package Naming Guidelines . + spec file name ok + The package meet the Packaging Guidelines and PHP Guidelines + license ok (LGPLv3) and match upstream + license provided + spec file is legible + sources match upstream a735ed6005551a49477b634004ca2c76 domxml-php4-to-php5.php + source URL not ok, but explained in the specfile + build on F13 x86_64 (php 5.3.3dev) + BuildRequires + no locale + no shared library (extension are not lib.) + no system library + own all directories that it creates + not list a file more than once in the spec + Permissions on files are set properly. + %clean ok + consistently use macro + contain code + no doc, no sub package + no -devel + no -static + no .pc + no .la + not own files or directories already owned by other packages + %install start with rm -rf $RPM_BUILD_ROOT + all files are UTF-8 + provides php-domxml-php4-php5 = 1.21.1-1.fc13 + requires php-xml >= 5.1
***** APPROVED *****
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590777
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Remi Collet fedora@famillecollet.com 2010-05-15 05:52:50 EDT --- Thanks for the review
New Package CVS Request ======================= Package Name: php-domxml-php4-php5 Short Description: XML transition from PHP4 domxml to PHP5 dom module Owners: remi Branches: F-12 F-13 EL-5 EL-6 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590777
Dennis Gilmore dennis@ausil.us changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #6 from Dennis Gilmore dennis@ausil.us 2010-05-18 14:18:48 EDT --- CVS Done
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590777
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2010-05-19 14:19:50 EDT --- php-domxml-php4-php5-1.21.1-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/php-domxml-php4-php5-1.21.1-2.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590777
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2010-05-19 14:20:40 EDT --- php-domxml-php4-php5-1.21.1-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/php-domxml-php4-php5-1.21.1-2.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590777
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2010-05-19 14:22:27 EDT --- php-domxml-php4-php5-1.21.1-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/php-domxml-php4-php5-1.21.1-2.el5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590777
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2010-05-20 14:45:16 EDT --- php-domxml-php4-php5-1.21.1-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-domxml-php4-php5'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/php-domxml-php4-php5-1.21.1-2.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590777
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2010-05-20 14:47:50 EDT --- php-domxml-php4-php5-1.21.1-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-domxml-php4-php5'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/php-domxml-php4-php5-1.21.1-2.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590777
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2010-05-20 20:30:51 EDT --- php-domxml-php4-php5-1.21.1-2.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-domxml-php4-php5'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/php-domxml-php4-php5-1.21.1-2.el5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590777
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2010-06-03 14:10:56 EDT --- php-domxml-php4-php5-1.21.1-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590777
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |php-domxml-php4-php5-1.21.1 | |-2.fc13 Resolution| |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590777
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2010-06-03 14:16:04 EDT --- php-domxml-php4-php5-1.21.1-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590777
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|php-domxml-php4-php5-1.21.1 |php-domxml-php4-php5-1.21.1 |-2.fc13 |-2.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590777
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2010-06-08 17:39:36 EDT --- php-domxml-php4-php5-1.21.1-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590777
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|php-domxml-php4-php5-1.21.1 |php-domxml-php4-php5-1.21.1 |-2.fc12 |-2.el5
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla