https://bugzilla.redhat.com/show_bug.cgi?id=1984198
Bug ID: 1984198 Summary: Review Request: rust-termwiz - Terminal Wizardry for Unix and Windows Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: dcavalca@fb.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/rust-termwiz/rust-termwiz.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-termwiz/rust-termwiz-0.13.0-1....
Description: Terminal Wizardry for Unix and Windows.
Fedora Account System Username: dcavalca
https://bugzilla.redhat.com/show_bug.cgi?id=1984198
Davide Cavalca dcavalca@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1984195, 1984197, 1984196 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1984195 [Bug 1984195] Review Request: rust-memmem - Substring searching https://bugzilla.redhat.com/show_bug.cgi?id=1984196 [Bug 1984196] Review Request: rust-vtparse - Low level escape sequence parser https://bugzilla.redhat.com/show_bug.cgi?id=1984197 [Bug 1984197] Review Request: rust-varbincode - Binary encoder / decoder with variable length integer encoding implementation in Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1984198
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |michel@michel-slm.name Status|NEW |POST CC| |michel@michel-slm.name Flags| |fedora-review+
--- Comment #1 from Michel Alexandre Salim michel@michel-slm.name --- LGTM, please upgrade to 0.15.0
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - X latest version of the crate is packaged - upgrade to termwiz 0.15.0 - license matches upstream specification (MIT) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add package to rust-sig with "commit" access
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=1984198
--- Comment #2 from Davide Cavalca dcavalca@fb.com --- Thanks!
$ fedpkg request-repo rust-termwiz 1984198 https://pagure.io/releng/fedora-scm-requests/issue/40980
https://bugzilla.redhat.com/show_bug.cgi?id=1984198
--- Comment #3 from Jens Petersen petersen@redhat.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-termwiz
https://bugzilla.redhat.com/show_bug.cgi?id=1984198 Bug 1984198 depends on bug 1984196, which changed state.
Bug 1984196 Summary: Review Request: rust-vtparse - Low level escape sequence parser https://bugzilla.redhat.com/show_bug.cgi?id=1984196
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1984198 Bug 1984198 depends on bug 1984197, which changed state.
Bug 1984197 Summary: Review Request: rust-varbincode - Binary encoder / decoder with variable length integer encoding implementation in Rust https://bugzilla.redhat.com/show_bug.cgi?id=1984197
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1984198 Bug 1984198 depends on bug 1984195, which changed state.
Bug 1984195 Summary: Review Request: rust-memmem - Substring searching https://bugzilla.redhat.com/show_bug.cgi?id=1984195
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1984198
--- Comment #4 from Davide Cavalca dcavalca@fb.com --- This was imported but never built properly. I tried updating it to 0.16.0 to see if that helps, but it requires two new crates: wezterm-bidi and wezterm-color-types.
https://bugzilla.redhat.com/show_bug.cgi?id=1984198
Davide Cavalca dcavalca@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2105831
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2105831 [Bug 2105831] Review Request: rust-wezterm-bidi - Unicode Bidi Algorithm (UBA)
https://bugzilla.redhat.com/show_bug.cgi?id=1984198
Davide Cavalca dcavalca@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2105859
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2105859 [Bug 2105859] Review Request: rust-wezterm-color-types - Types for working with colors
https://bugzilla.redhat.com/show_bug.cgi?id=1984198
Davide Cavalca dcavalca@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2118892
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2118892 [Bug 2118892] Review Request: rust-wezterm-dynamic - Config serialization for wezterm via dynamic json-like data values
https://bugzilla.redhat.com/show_bug.cgi?id=1984198 Bug 1984198 depends on bug 2118892, which changed state.
Bug 2118892 Summary: Review Request: rust-wezterm-dynamic - Config serialization for wezterm via dynamic json-like data values https://bugzilla.redhat.com/show_bug.cgi?id=2118892
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1984198 Bug 1984198 depends on bug 2105831, which changed state.
Bug 2105831 Summary: Review Request: rust-wezterm-bidi - Unicode Bidi Algorithm (UBA) https://bugzilla.redhat.com/show_bug.cgi?id=2105831
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1984198 Bug 1984198 depends on bug 2105859, which changed state.
Bug 2105859 Summary: Review Request: rust-wezterm-color-types - Types for working with colors https://bugzilla.redhat.com/show_bug.cgi?id=2105859
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1984198
Davide Cavalca dcavalca@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2138983
--- Comment #5 from Davide Cavalca dcavalca@fb.com --- 0.18.0 grew one more dep: https://bugzilla.redhat.com/show_bug.cgi?id=2138983
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2138983 [Bug 2138983] Review Request: rust-finl_unicode - Library for handling Unicode functionality for finl (categories and grapheme segmentation)
https://bugzilla.redhat.com/show_bug.cgi?id=1984198
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- Just package the previous version for now, the finl_unicode review might take some time - looks like it bundles large amounts of code generated from Unicode data but doesn't specify this correctly.
https://bugzilla.redhat.com/show_bug.cgi?id=1984198
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-59e1a826f8 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-59e1a826f8
https://bugzilla.redhat.com/show_bug.cgi?id=1984198
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2022-11-03 04:26:29
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-59e1a826f8 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org