[Bug 1922799] New: Review Request: golang-github-josephspurrier-goversioninfo - Golang Windows File Properties/Version Info and Icon Resource Generator
https://bugzilla.redhat.com/show_bug.cgi?id=1922799
Bug ID: 1922799 Summary: Review Request: golang-github-josephspurrier-goversioninfo - Golang Windows File Properties/Version Info and Icon Resource Generator Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: zebob.m@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-josephspurrier-go... SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-josephspurrier-go...
Description: Microsoft Windows File Properties/Version Info and Icon Resource Generator for the Go Language Package creates a syso file which contains Microsoft Windows Version Information and an optional icon. When you run "go build", Go will embed the version information and an optional icon and an optional manifest in the executable. Go will automatically use the syso file if it's in the same directory as the main() function
Fedora Account System Username: eclipseo
https://bugzilla.redhat.com/show_bug.cgi?id=1922799
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-josephspurrier-go... New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-josephspurrier-go...
https://bugzilla.redhat.com/show_bug.cgi?id=1922799
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1922790 (golang-fyne)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1922790 [Bug 1922790] Review Request: golang-fyne - Cross platform GUI in Go based on Material DesignCross platform GUI in Go based on Material Design
Product: Fedora Version: rawhide Component: Package Review
Package Review package-review@lists.fedoraproject.org has canceled Package Review package-review@lists.fedoraproject.org's request for Robert-André Mauchin 🐧 zebob.m@gmail.com's needinfo: Bug 1922799: Review Request: golang-github-josephspurrier-goversioninfo - Golang Windows File Properties/Version Info and Icon Resource Generator https://bugzilla.redhat.com/show_bug.cgi?id=1922799
--- Comment #3 from Package Review package-review@lists.fedoraproject.org --- This is an automatic action taken by review-stats script.
The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.
https://bugzilla.redhat.com/show_bug.cgi?id=1922799
Christian Glombek cglombek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |NEW CC| |cglombek@redhat.com Resolution|NOTABUG |--- Keywords| |Reopened
--- Comment #4 from Christian Glombek cglombek@redhat.com --- Moving this to NEW again. I'm in need of this package, and would be happy to co-maintain
https://bugzilla.redhat.com/show_bug.cgi?id=1922799
Arthur Bols arthur@bols.dev changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #5 from Arthur Bols arthur@bols.dev --- Hi,
Since this review is so old, some changes are needed:
- Add the -f flag to %gometa New packages should use this to exclude %ix86 - Update to the latest version 1.4.0 - Consider using the rpmautospec macros (%autorelease and %autochangelog) - Change the %{_bindir}/* to not glob (go2rpm still does this, but it's not recommended): https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists - goversioninfo is an application, shouldn't the package be named goversioninfo instead? I'll let you decide, since I don't know the project: https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_source_pa...
I'll continue the review after the changes, but I believe it will be ready for approval.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com