[Bug 226155] New: Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226155

Summary: Merge Review: mod_perl
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: mod_perl

http://cvs.fedora.redhat.com/viewcvs/devel/mod_perl/
Initial Owner: [e-mail]

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: mod_perl
Alias: mod_perl

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226155

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
  BugsThisDependsOn|                            |228429
              Alias|                            |mod_perl

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: mod_perl
Alias: mod_perl

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226155

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|normal                      |medium

Bug 226155 depends on bug 228429, which changed state.

Bug 228429 Summary: mod_perl errantly provides perl(warnings)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228429

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |RAWHIDE
             Status|NEW                         |CLOSED

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: mod_perl
Alias: mod_perl

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226155

Bug 226155 depends on bug 228429, which changed state.

Bug 228429 Summary: mod_perl errantly provides perl(warnings)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228429

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|RAWHIDE                     |
             Status|CLOSED                      |ASSIGNED

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: mod_perl
Alias: mod_perl

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226155

Bug 226155 depends on bug 228429, which changed state.

Bug 228429 Summary: mod_perl errantly provides perl(warnings)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228429

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |CURRENTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: mod_perl
Alias: mod_perl

https://bugzilla.redhat.com/show_bug.cgi?id=226155

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2008-07-22 09:54 EST -------
mod_perl.src:55: W: rpm-buildroot-usage %build PREFIX=$RPM_BUILD_ROOT/usr \
mod_perl.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 55)
mod_perl.src: W: strange-permission filter-provides.sh 0775
mod_perl.src: W: strange-permission filter-requires.sh 0775

mod_perl.i386: W: hidden-file-or-dir
/usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-inline
mod_perl.i386: W: hidden-file-or-dir
/usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-modperl-register
mod_perl.i386: W: hidden-file-or-dir
/usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-modperl-xs
mod_perl.i386: E: wrong-script-interpreter
/usr/share/doc/mod_perl-2.0.4/docs/os/win32/mpinstall "C:/Perl/bin"
mod_perl.i386: W: file-not-utf8 /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/c.pod
mod_perl.i386: W: file-not-utf8 /usr/share/doc/mod_perl-2.0.4/Changes
mod_perl.i386: W: hidden-file-or-dir
/usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-modperl-init
mod_perl.i386: W: file-not-utf8 /usr/share/doc/mod_perl-2.0.4/docs/user/Changes.pod
mod_perl.i386: W: file-not-utf8 /usr/share/doc/mod_perl-2.0.4/SVN-MOVE
mod_perl.i386: W: file-not-utf8
/usr/share/doc/mod_perl-2.0.4/docs/devel/core/explained.pod
mod_perl.i386: E: useless-explicit-provides perl(Apache2::Connection)
mod_perl.i386: E: useless-explicit-provides perl(Apache2::RequestRec)

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: mod_perl
Alias: mod_perl

https://bugzilla.redhat.com/show_bug.cgi?id=226155

------- Additional Comments From [e-mail]  2008-07-22 09:59 EST -------
spec:
missing dist tag

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226155

Itamar Reis Peixoto  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Itamar Reis Peixoto   2008-10-03 09:01:29 EDT ---
Hi.

I am using

mod_perl-2.0.4-6.x86_64
httpd-2.2.9-4.x86_64

and I receiving the flowing error.

[root@localhost ~]# service httpd restart
Stopping httpd:                                            [FAILED]
Starting httpd: httpd: Syntax error on line 209 of /etc/httpd/conf/httpd.conf:
Syntax error on line 10 of /etc/httpd/conf.d/perl.conf: Cannot load
/etc/httpd/modules/mod_perl.so into server: /etc/httpd/modules/mod_perl.so:
undefined symbol: modperl_io_perlio_restore_stdout
                                                           [FAILED]

Can you help with this issue, or Can I open a new bug report ?

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226155

--- Comment #4 from Marcela Maslanova   2008-10-06 04:18:48 EDT ---
I opened new bug #465743 for this problem.

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226155

--- Comment #5 from Emmanuel Seyman   2009-09-26 17:16:22 EDT ---
Created an attachment (id=362781)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=362781)
Patch to the mod_perl spec file

Here's a patch that removes all the errors that can be removed.

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226155

Emmanuel Seyman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |emmanuel.seyman@club-intern
                   |                            |et.fr

--- Comment #6 from Emmanuel Seyman  2010-07-10 13:20:15 EDT ---
Joe, per the recent discussion on [e-mail].o on merge reviews, do you think
we can get this one closed ? I'ld gladly review it if so.

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226155

--- Comment #7 from Joe Orton  2010-07-12 03:17:32 EDT ---
Emmanuel - if you are a provenpackager please go ahead and commit your fixes,
if not please request commit privs for this package and I'll approve that!

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226155

--- Comment #8 from Emmanuel Seyman  2010-07-14 05:17:17 EDT ---
(In reply to comment #7)
> Emmanuel - if you are a provenpackager please go ahead and commit your fixes,
> if not please request commit privs for this package and I'll approve that!

This kind of defeats the point of having merge reviews. The whole point is that
two people collaborate on raising the package's quality level.

http://lists.fedoraproject.org/pipermail/devel/2010-July/138649.html

That said, the changes look to be minor. Would anybody else care to review the
package so that I can play the part of the maintainer ?

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226155

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Parag AN(पराग)  2010-09-06 05:22:28 EDT ---
Emmanuel,
  Its official that if maintainer approves reviewer to commit on behalf of him
then please go ahead and commit the changes and close yourself this review. 
  This has been approved in
http://lists.fedoraproject.org/pipermail/devel/2010-August/141204.html

Let's help merge-review maintainers to review their packages by committing
approved changes by them and reviewing their packages.

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226155

Marcela Mašláňová  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |needinfo?(emmanuel.seyman@c
                   |                            |lub-internet.fr)

--- Comment #10 from Marcela Mašláňová  2010-10-04 08:40:08 EDT ---
Hello Emmanuel,
I can review it again.
rpmlint mod_perl-2.0.4-11.fc15.src.rpm 
mod_perl.src: W: spelling-error %description -l en_US perl -> Perl, peel, perk
mod_perl.src: W: spelling-error %description -l en_US runtime -> run time,
run-time, runtish
mod_perl.src: W: strange-permission filter-provides.sh 0755L
mod_perl.src: W: strange-permission filter-requires.sh 0755L
mod_perl.src:59: W: rpm-buildroot-usage %build PREFIX=$RPM_BUILD_ROOT/usr \
mod_perl.src:108: W: macro-in-comment %{_mandir}
mod_perl.src:109: W: macro-in-comment %{perl_vendorarch}
mod_perl.src:59: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 59)
1 packages and 0 specfiles checked; 0 errors, 8 warnings.
rpmlint i386/* | grep -v private
mod_perl.i386: W: spelling-error %description -l en_US runtime -> run time,
run-time, runtish
mod_perl.i386: E: useless-provides perl(Apache2::Connection)
mod_perl.i386: E: useless-provides perl(Apache2::RequestRec)
mod_perl.i386: W: hidden-file-or-dir
/usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-inline
mod_perl.i386: W: hidden-file-or-dir
/usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-modperl-register
mod_perl.i386: W: hidden-file-or-dir
/usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-modperl-xs
mod_perl.i386: E: wrong-script-interpreter
/usr/share/doc/mod_perl-2.0.4/docs/os/win32/mpinstall C:/Perl/bin
mod_perl.i386: W: file-not-utf8
/usr/share/doc/mod_perl-2.0.4/docs/devel/debug/c.pod
mod_perl.i386: W: file-not-utf8 /usr/share/doc/mod_perl-2.0.4/Changes
mod_perl.i386: W: hidden-file-or-dir
/usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-modperl-init
mod_perl.i386: W: file-not-utf8
/usr/share/doc/mod_perl-2.0.4/docs/user/Changes.pod
mod_perl.i386: W: file-not-utf8 /usr/share/doc/mod_perl-2.0.4/SVN-MOVE
mod_perl.i386: W: file-not-utf8
/usr/share/doc/mod_perl-2.0.4/docs/devel/core/explained.pod
mod_perl.i386: W: no-manual-page-for-binary mp2bug
And there is also a lot of *.so in provides. This could be easily filtered by
perl_default_filter.
That's for start ;-)

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226155

Marcela Mašláňová  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(emmanuel.seyman@c
                   |                            |lub-internet.fr)

--- Comment #11 from Marcela Mašláňová  2010-10-13 04:07:25 EDT ---
Ping Emmanuel, do you want still fix it?

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226155

Emmanuel Seyman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(emmanuel.seyman@c |needinfo+
                   |lub-internet.fr),           |
                   |needinfo?(emmanuel.seyman@c |
                   |lub-internet.fr)            |

--- Comment #12 from Emmanuel Seyman  2010-10-13 06:20:55 EDT ---
(In reply to comment #11)
> Ping Emmanuel, do you want still fix it?

Yup, I've just been busy these last two weeks and haven't had time to spare to
reviews. I'll make time by the end of the week.

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226155

Emmanuel Seyman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #362781|0                           |1
        is obsolete|                            |

--- Comment #13 from Emmanuel Seyman  2010-10-31 12:57:10 EDT ---
Created attachment 456737
  --> https://bugzilla.redhat.com/attachment.cgi?id=456737
Patch to mod_perl.spec

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226155

--- Comment #14 from Emmanuel Seyman  2010-10-31 12:58:12 EDT ---
Created attachment 456738
  --> https://bugzilla.redhat.com/attachment.cgi?id=456738
The new spec file

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226155

--- Comment #15 from Emmanuel Seyman  2010-10-31 13:04:57 EDT ---
(In reply to comment #12)
> Yup, I've just been busy these last two weeks and haven't had time to spare to
> reviews. I'll make time by the end of the week.

Well, make that next week. :-)

(In reply to comment #10)
> mod_perl.src: W: spelling-error %description -l en_US perl -> Perl, peel, perk

False positive.
> mod_perl.src: W: spelling-error %description -l en_US runtime -> run time,
> run-time, runtish

Fixed.
> mod_perl.src: W: strange-permission filter-provides.sh 0755L
> mod_perl.src: W: strange-permission filter-requires.sh 0755L

Removed (see below).
> mod_perl.src:59: W: rpm-buildroot-usage %build PREFIX=$RPM_BUILD_ROOT/usr \

Not fixed (and harmless, imho).
> mod_perl.src:108: W: macro-in-comment %{_mandir}
> mod_perl.src:109: W: macro-in-comment %{perl_vendorarch}

Removed.
> mod_perl.src:59: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 59)

Ugh. Fixed.
> mod_perl.i386: E: useless-provides perl(Apache2::Connection)
> mod_perl.i386: E: useless-provides perl(Apache2::RequestRec)

Filtered. I also moved the filtering inline.
> mod_perl.i386: W: hidden-file-or-dir
> /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-inline
> mod_perl.i386: W: hidden-file-or-dir
> /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-modperl-register
> mod_perl.i386: W: hidden-file-or-dir
> /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-modperl-xs
> mod_perl.i386: E: wrong-script-interpreter

False postives.
> /usr/share/doc/mod_perl-2.0.4/docs/os/win32/mpinstall C:/Perl/bin

False positive.
> mod_perl.i386: W: file-not-utf8
> /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/c.pod
> mod_perl.i386: W: file-not-utf8 /usr/share/doc/mod_perl-2.0.4/Changes
> mod_perl.i386: W: hidden-file-or-dir
> /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-modperl-init
> mod_perl.i386: W: file-not-utf8
> /usr/share/doc/mod_perl-2.0.4/docs/user/Changes.pod
> mod_perl.i386: W: file-not-utf8 /usr/share/doc/mod_perl-2.0.4/SVN-MOVE
> mod_perl.i386: W: file-not-utf8
> /usr/share/doc/mod_perl-2.0.4/docs/devel/core/explained.pod

All fixed.
> mod_perl.i386: W: no-manual-page-for-binary mp2bug

Probably something to report to upstream.

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226155

--- Comment #16 from Marcela Mašláňová  2010-11-01 03:03:28 EDT ---
Buildroot and rm -rf in build section are not needed since F-13. These could be
removed, but everything else looks allright.

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226155

Emmanuel Seyman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #456737|0                           |1
        is obsolete|                            |
 Attachment #456738|0                           |1
        is obsolete|                            |

--- Comment #17 from Emmanuel Seyman  2010-11-04 09:18:12 EDT ---
Created attachment 457786
  --> https://bugzilla.redhat.com/attachment.cgi?id=457786
New patch to the spec file

(In reply to comment #16)
> Buildroot and rm -rf in build section are not needed since F-13. These could be
> removed, but everything else looks allright.

You're right. The new patch does this (and adds the correct changelog).
Can you commit this ? I don't have provenpackager rights.

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226155

Marcela Mašláňová  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
   Fixed In Version|                            |mod_perl-2.0.4-12.fc15
         Resolution|                            |RAWHIDE
        Last Closed|                            |2010-11-04 12:58:17

--- Comment #18 from Marcela Mašláňová  2010-11-04 12:58:17 EDT ---
(In reply to comment #17)
> Created attachment 457786 [details]
> New patch to the spec file
>
> (In reply to comment #16)
> > Buildroot and rm -rf in build section are not needed since F-13. These could be
> > removed, but everything else looks allright.
>
> You're right. The new patch does this (and adds the correct changelog).
> Can you commit this ? I don't have provenpackager rights.

Built in rawhide.

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226155

--- Comment #19 from Joe Orton  2010-11-11 06:08:39 EST ---
mod_perl has broken dependencies in the rawhide tree:
On x86_64:
        mod_perl-devel-2.0.4-12.fc15.x86_64 requires
perl(Apache::TestConfigPerl)
        mod_perl-devel-2.0.4-12.fc15.x86_64 requires
perl(Apache::TestConfigParse)
        mod_perl-devel-2.0.4-12.fc15.x86_64 requires perl(Data::Flow)

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226155

--- Comment #20 from Marcela Mašláňová  2010-11-11 08:28:42 EST ---
Should be fixed in last commit. I'm sorry, we missed these.

[Bug 226155] Merge Review: mod_perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226155

Andres Garcia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #21 from Andres Garcia  2011-10-19 17:44:10 EDT ---
Hi Guys,

i'm having issues with the package mod_perl (mod_perl-2.0.5-5).  The httpd
service crashed after installed

The httpd version is 2.2.21 and this is the error message i'm getting everytime
I tried to run the service:

Restarting httpd (via systemctl):  Job failed. See system logs and 'systemctl
status' for details.
                                                           [FAILED]
# systemctl status httpd

# systemctl status httpd.service 
httpd.service - The Apache HTTP Server (prefork MPM)
      Loaded: loaded (/lib/systemd/system/httpd.service; enabled)
      Active: failed since Wed, 19 Oct 2011 16:40:07 -0500; 27s ago
     Process: 5233 ExecStop=/usr/sbin/httpd $OPTIONS -k stop (code=exited,
status=0/SUCCESS)
     Process: 5235 ExecStart=/usr/sbin/httpd $OPTIONS -k start (code=dumped,
signal=SEGV)
    Main PID: 4794 (code=exited, status=0/SUCCESS)
      CGroup: name=systemd:/system/httpd.service

Please let me know if you need more details