https://bugzilla.redhat.com/show_bug.cgi?id=2075980
Bug ID: 2075980 Summary: Review Request: rust-digest_auth-rpm - Implementation of the Digest Auth algorithm Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: carmelo.sarta.main@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://raw.githubusercontent.com/Laiot/rust-digest_auth-rpm/master/rust-dig... SRPM URL: https://github.com/Laiot/rust-digest_auth-rpm/raw/master/rust-digest_auth-0.... Description: Implementation of the Digest Auth algorithm as defined in IETF RFC 2069, 2617, and 7616, intended for HTTP clients Fedora Account System Username: laiot
https://bugzilla.redhat.com/show_bug.cgi?id=2075980
Carmelo Sarta carmelo.sarta.main@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Summary|Review Request: |Review Request: |rust-digest_auth-rpm - |rust-digest_auth - |Implementation of the |Implementation of the |Digest Auth algorithm |Digest Auth algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=2075980
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |decathorpe@gmail.com Flags| |fedora-review+ Assignee|nobody@fedoraproject.org |decathorpe@gmail.com
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
===
Please shorten the Summary tag in the spec file as well, it should fit within 80 columns. You could just use the same one as in this bug's title.
I'm curious, what are you packaging that requires this crate?
https://bugzilla.redhat.com/show_bug.cgi?id=2075980
--- Comment #2 from Carmelo Sarta carmelo.sarta.main@gmail.com --- Hi Fabio, thanks again for this review! I needed this package since it's a dependency for the following crate https://crates.io/crates/xh
https://bugzilla.redhat.com/show_bug.cgi?id=2075980
--- Comment #3 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-digest_auth
https://bugzilla.redhat.com/show_bug.cgi?id=2075980
Carmelo Sarta carmelo.sarta.main@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2022-05-05 13:51:36
package-review@lists.fedoraproject.org