Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=438024
Summary: Review Request: freeimage - Multi-format image decoder library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: j.w.r.degoede@hhs.nl QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://people.atrpms.net/~hdegoede/freeimage.spec SRPM URL: http://people.atrpms.net/~hdegoede/freeimage-3.10.0-1.fc9.src.rpm Description: FreeImage is a library for developers who would like to support popular graphics image formats like PNG, BMP, JPEG, TIFF and others as needed by today's multimedia applications.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: freeimage - Multi-format image decoder library
https://bugzilla.redhat.com/show_bug.cgi?id=438024
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |435399 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: freeimage - Multi-format image decoder library
https://bugzilla.redhat.com/show_bug.cgi?id=438024
lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |lemenkov@gmail.com Flag| |fedora-review?
------- Additional Comments From lemenkov@gmail.com 2008-03-19 09:17 EST ------- I'll review it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: freeimage - Multi-format image decoder library
https://bugzilla.redhat.com/show_bug.cgi?id=438024
lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From lemenkov@gmail.com 2008-03-25 17:06 EST ------- REVIEW:
+ rpmlint is silent. + The package named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package licensed with a Fedora approved license and meet the Licensing Guidelines. + The License field in the package spec matches the actual license. + The spec file written in American English. + The spec file for the package is legible. + The sources used to build the package must matches the upstream source.
[petro@Sulaco SOURCES]$ md5sum FreeImage3100.zip* 2e57135e26bb487cc8e13ee7b7e0a595 FreeImage3100.zip 2e57135e26bb487cc8e13ee7b7e0a595 FreeImage3100.zip.1 [petro@Sulaco SOURCES]$
+ The package must successfully compiles and builds into binary rpms on ppc architecture. + All build dependencies listed in BuildRequires. + Every binary RPM package which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. If the package has multiple subpackages with libraries, each subpackage should also have a %post/%postun section that calls /sbin/ldconfig. An example of the correct syntax for this is:
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
+ A package owns all directories that it creates. + A package does not contain any duplicate files in the %files listing. + Permissions on files are set properly. + Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + Each package must consistently use macros, as described in the macros section of Packaging Guidelines. + The package contain code, or permissable content. + If a package includes something as %doc, it must not affect the runtime of the application. + Header files are in a -devel package. + If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. + In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} + Packages does NOT contain any .la libtool archives. + Packages does not own files or directories already owned by other packages. + At the beginning of %install, package run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: freeimage - Multi-format image decoder library
https://bugzilla.redhat.com/show_bug.cgi?id=438024
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From j.w.r.degoede@hhs.nl 2008-03-25 18:25 EST ------- Thanks for the review!
New Package CVS Request ======================= Package Name: freeimage Short Description: Multi-format image decoder library Owners: jwrdegoede Branches: F-8 InitialCC: Cvsextras Commits: Yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: freeimage - Multi-format image decoder library
https://bugzilla.redhat.com/show_bug.cgi?id=438024
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-03-26 12:04 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: freeimage - Multi-format image decoder library
https://bugzilla.redhat.com/show_bug.cgi?id=438024
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |RAWHIDE
------- Additional Comments From j.w.r.degoede@hhs.nl 2008-03-27 08:39 EST ------- Imported and build, closing.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla