[Bug 842124] New: Review Request: appmenu-qt - This package allows Qt to export its menus over DBus. - package-review

List overview All Threads
Download

newer

[Bug 842124] New: Review Request: appmenu-qt - This package allows Qt to export its menus over DBus.

older

[Bug 882498] New: Review Request:...

[Bug 760177] New: Review Request:...

Red Hat Bugzilla

22 Jul 2012 22 Jul '12

6:21 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=842124

Bug ID: 842124 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: unspecified CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: appmenu-qt - This package allows Qt to export its menus over DBus. Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: damianatorrpm@gmail.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora

Spec URL: https://build.opensuse.org/package/view_file?file=appmenu-qt-Fedora_17.spec&... SRPM URL: http://download.opensuse.org/repositories/GNOME:/Ayatana/Fedora_17/src/appme... Description: This package allows Qt to export its menus over DBus. Fedora Account System Username:

NOTE: This package is for unity on fedora and/or indicators usable by gnome and xfce. It requires dbusmenu which will have a review request too.

-- You are receiving this mail because: You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

22 Jul 22 Jul

6:23 a.m.

New subject: [Bug 842124] Review Request: appmenu-qt - This package allows Qt to export its menus over DBus.

https://bugzilla.redhat.com/show_bug.cgi?id=842124

--- Comment #1 from Damian Ivanov damianatorrpm@gmail.com --- Please note one additional difference: When including to Fedora .spec file name must be renamed to appmenu-qt.spec and the moment name is %name-Fedora_17.spec correctly named spec file can be found here: https://raw.github.com/chenxiaolong/Unity-for-Fedora/master/appmenu-qt/appme...

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

12:09 p.m.

New subject: [Bug 842124] Review Request: appmenu-qt - This package allows Qt to export its menus over DBus.

https://bugzilla.redhat.com/show_bug.cgi?id=842124

Michael Scherer misc@zarb.org changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@zarb.org

--- Comment #2 from Michael Scherer misc@zarb.org --- Hi,

a few notes :

- BuildRequires: libXfixes BuildRequires: libXfixes-devel

this seems redundant ( ie, the -devel should pull the regular library )

- No need to clean in %install %install rm -rf $RPM_BUILD_ROOT

that's already done by rpm since a long time

- unowned directory

I am npot sure, but it seems that the direcotry %{_libdir}/qt4/plugins/menubar/libappmenu is unowned. This should be fixed : https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Owner...

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

24 Jul 24 Jul

1:33 p.m.

New subject: [Bug 842124] Review Request: appmenu-qt - This package allows Qt to export its menus over DBus.

https://bugzilla.redhat.com/show_bug.cgi?id=842124

Xiao-Long Chen chillermillerlong@hotmail.com changed:

--- Comment #3 from Xiao-Long Chen chillermillerlong@hotmail.com --- The reason I added both libXfixes and libXfixes-devel is to workaround some issues in the Open Build Service's dependency resolver. If appmenu-qt is accepted into the Fedora repos, any dependencies where I put "Satisfy OBS conflict" are not needed.

I have updated the spec file to check for %{?opensuse_bs}.

New spec file can be found here: https://raw.github.com/chenxiaolong/Unity-for-Fedora/master/appmenu-qt/appme...

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

4:04 p.m.

New subject: [Bug 842124] Review Request: appmenu-qt - This package allows Qt to export its menus over DBus.

https://bugzilla.redhat.com/show_bug.cgi?id=842124

--- Comment #4 from Michael Scherer misc@zarb.org --- Now, the srpm is missing ( 404 ).

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

4:09 p.m.

New subject: [Bug 842124] Review Request: appmenu-qt - This package allows Qt to export its menus over DBus.

https://bugzilla.redhat.com/show_bug.cgi?id=842124

--- Comment #5 from Michael Scherer misc@zarb.org --- In fact, I do not understand, can you explain in more detail what are such conflict, what do you see, how it fail the build ?

I see no reason that fedora on OBS should be different from koji or mock, that's basically the same rpm, installed by similar tools.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

9:21 p.m.

New subject: [Bug 842124] Review Request: appmenu-qt - This package allows Qt to export its menus over DBus.

https://bugzilla.redhat.com/show_bug.cgi?id=842124

--- Comment #6 from Xiao-Long Chen chillermillerlong@hotmail.com --- Sure. Somewhere along the chain of build dependencies, qt-ubuntu needs libXfixes-devel. The conflict comes from us providing a libXfixes-ubuntu-devel package (for Unity), which provides and obsoletes libXfixes-devel. OBS uses its own dependency solver that ignores the obsoletes tag, so it fails with something like: "have choice for libXfixes-devel, required by qt-devel: libXfixes-ubuntu-devel libXfixes-devel". In OBS, we must BuildRequires the preferred package to use.

No workarounds will ever be needed because koji uses mock, which uses yum, which works just fine.

The issue is really only relevant in our OBS repo because we need patched system packages for Unity.

Hope I explained the issue a little better :)

By the way, the SRPM is here: http://download.opensuse.org/repositories/GNOME:/Ayatana/Fedora_17/src/

The SRPM will 404 pretty quickly as OBS bumps the release number with every rebuild.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

9:22 p.m.

New subject: [Bug 842124] Review Request: appmenu-qt - This package allows Qt to export its menus over DBus.

https://bugzilla.redhat.com/show_bug.cgi?id=842124

--- Comment #7 from Xiao-Long Chen chillermillerlong@hotmail.com --- Just in case it's not clear from my previous comment, appmenu-qt will work *without* any patches to other packages :)

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

25 Jul 25 Jul

12:01 a.m.

New subject: [Bug 842124] Review Request: appmenu-qt - This package allows Qt to export its menus over DBus.

https://bugzilla.redhat.com/show_bug.cgi?id=842124

--- Comment #8 from Michael Scherer misc@zarb.org --- so if appmenu-qt package work without patchs, why is there the need for libXfixes-ubuntu-devel, and if there is no need for it, why do you keep it in the fedora sources ?

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

12:03 a.m.

New subject: [Bug 842124] Review Request: appmenu-qt - This package allows Qt to export its menus over DBus.

https://bugzilla.redhat.com/show_bug.cgi?id=842124

--- Comment #9 from Xiao-Long Chen chillermillerlong@hotmail.com --- You're right. That is the current source for the GNOME:Ayatana. Damian (if he will maintain the package) should copy the spec file to somewhere else and remove that part of the spec.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

31 Jul 31 Jul

7:33 a.m.

New subject: [Bug 842124] Review Request: appmenu-qt - This package allows Qt to export its menus over DBus.

https://bugzilla.redhat.com/show_bug.cgi?id=842124

Rex Dieter rdieter@math.unl.edu changed:

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

10:28 a.m.

New subject: [Bug 842124] Review Request: appmenu-qt - This package allows Qt to export its menus over DBus.

https://bugzilla.redhat.com/show_bug.cgi?id=842124

--- Comment #10 from Kevin Kofler kevin@tigcc.ticalc.org --- FWIW, there's also at least one plasmoid which uses those app menus.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

6 Aug 6 Aug

11:10 a.m.

New subject: [Bug 842124] Review Request: appmenu-qt - This package allows Qt to export its menus over DBus.

https://bugzilla.redhat.com/show_bug.cgi?id=842124

Rex Dieter rdieter@math.unl.edu changed:

--- Comment #11 from Rex Dieter rdieter@math.unl.edu --- I'll try to start reviewing this today.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

11:14 a.m.

New subject: [Bug 842124] Review Request: appmenu-qt - This package allows Qt to export its menus over DBus.

https://bugzilla.redhat.com/show_bug.cgi?id=842124

--- Comment #12 from Rex Dieter rdieter@math.unl.edu --- using http://download.opensuse.org/repositories/GNOME:/Ayatana/Fedora_17/src/appme...

the original link didn't work.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

11:26 a.m.

New subject: [Bug 842124] Review Request: appmenu-qt - This package allows Qt to export its menus over DBus.

https://bugzilla.redhat.com/show_bug.cgi?id=842124

Rex Dieter rdieter@math.unl.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #13 from Rex Dieter rdieter@math.unl.edu --- OK, using https://raw.github.com/chenxiaolong/Unity-for-Fedora/master/appmenu-qt/appme... as referenced...

1. MUST drop extraneous BuildRequires: gcc-c++ (see http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 )

naming: ok

sources: ok md5sum *.bz2 90cce750e5412d43ce075b0a9bdb6782 appmenu-qt-0.2.6.tar.bz2

license: ok

macros: ok (but could use some polish, like using fedora's %_qt4_plugindir macro instead of hard-coding %{_libdir}/qt4/plugins)

scriptlets: n/a

otherwise, it's a relatively simple package, I see nothing else that needs work.

As far as I'm concerned, item 1 is relatively cosmetic, and it's ok with me as long as it is addressed prior to doing any official fedora builds in koji.

APPROVED.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

11:32 a.m.

New subject: [Bug 842124] Review Request: appmenu-qt - This package allows Qt to export its menus over DBus.

https://bugzilla.redhat.com/show_bug.cgi?id=842124

--- Comment #14 from Rex Dieter rdieter@math.unl.edu --- oh, and if you don't mind, when making the cvsadmin request, please add me (rdieter) as comaintainer.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

8 Nov 8 Nov

9:55 a.m.

New subject: [Bug 842124] Review Request: appmenu-qt - This package allows Qt to export its menus over DBus.

https://bugzilla.redhat.com/show_bug.cgi?id=842124

Rex Dieter rdieter@math.unl.edu changed:

--- Comment #15 from Rex Dieter rdieter@math.unl.edu --- Damian, ping? are you still able and interested in maintaining appmenu-qt?

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

13 Nov 13 Nov

8:45 a.m.

New subject: [Bug 842124] Review Request: appmenu-qt - This package allows Qt to export its menus over DBus.

https://bugzilla.redhat.com/show_bug.cgi?id=842124

Damian Ivanov damianatorrpm@gmail.com changed:

--- Comment #16 from Damian Ivanov damianatorrpm@gmail.com --- Rex, appmenu-qt is an important package. All desktop environments need that package if they want Qt applications to export their menus. I did (and will continue if missed something / guidelines get updated) change the spec file to conform to Fedora policies, though I consider Koji & co inferior to OBS and use exclusively OBS for building packages. If anybody wants to have it in mainline Fedora just get the spec from OBS and remove the -Fedora_17 (or appropriate) suffix.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

10:58 a.m.

New subject: [Bug 842124] Review Request: appmenu-qt - This package allows Qt to export its menus over DBus.

https://bugzilla.redhat.com/show_bug.cgi?id=842124

--- Comment #17 from Rex Dieter rdieter@math.unl.edu --- Damian, submitting something for review here means that you want to take responsibility for owning and maintaining it in fedora. Based on your statement, it's not clear to me if you're willing to do that or not. I'd appreciate if you could clarify.

(If not, this review is good for posterity, but will have to be closed, and a new one submitted by someone who *is* willing).

-- You are receiving this mail because: You are on the CC list for the bug.