[Bug 1530431] New: Review Request: nodepool - nodes management for a distributed test infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1530431
Bug ID: 1530431 Summary: Review Request: nodepool - nodes management for a distributed test infrastructure Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: tdecacqu@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://fedorapeople.org/~tdecacqu/pkgs/nodepool.spec SRPM URL: https://fedorapeople.org/~tdecacqu/pkgs/nodepool-0.4.0-1.2017.12.14.a20d81c....
Description: Nodepool is a service used by the OpenStack CI team to deploy and manage a pool of devstack images on a cloud server for use in OpenStack project testing.
Note: Nodepool feature/zuulv3 isn't release yet, this is a preemptive package of the next version. Once the branch is tagged, the spec would need to use the released version instead of the git commit and the local driver plugin patch could be removed. Other than that, the spec should be almost good...
Fedora Account System Username: tdecacqu
https://bugzilla.redhat.com/show_bug.cgi?id=1530431
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - You need systemd requires too, add:
%{?systemd_requires} BuildRequires: systemd
See https://fedoraproject.org/wiki/Packaging:Scriptlets#Systemd
- The license file mist be installed with the %license macro, not %doc:
%files %license LICENSE
- Some dirs are not owned:
[!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.6/site- packages/nodepool/driver, /usr/lib/python3.6 /site-packages/nodepool, /etc/nodepool
- gitdate should not be separated by dots:
%global gitdate 20171214
- The Release field should mention the type of VCS:
Release: 1.%{gitdate}git%{shortcommit}%{?dist}
- The %changelog release info are not identical to the header ones:
* Wed Jan 3 2018 Tristan Cacqueray tdecacqu@redhat.com - 0.4.0-1.20171214gita20d81c
- Fix the line encodings for the LICENSE file:
nodepool-launcher.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/nodepool-launcher/LICENSE
- You must ship a logrotate config file for your log. See https://fedoraproject.org/wiki/Packaging:Guidelines#Logrotate_config_file
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "*No copyright* Apache", "Unknown or generated", "*No copyright* Apache (v2.0)". 33 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/nodepool/review-nodepool/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /etc/nodepool [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.6/site- packages/nodepool/driver, /usr/lib/systemd/system, /usr/lib/python3.6 /site-packages/nodepool, /etc/nodepool, /usr/lib/systemd [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. → Missing sytemd requires [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 81920 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in nodepool-launcher , nodepool-driver-openstack , nodepool-builder [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: nodepool-0.4.0-1.2017.12.14.a20d81c.fc28.noarch.rpm nodepool-launcher-0.4.0-1.2017.12.14.a20d81c.fc28.noarch.rpm nodepool-driver-openstack-0.4.0-1.2017.12.14.a20d81c.fc28.noarch.rpm nodepool-builder-0.4.0-1.2017.12.14.a20d81c.fc28.noarch.rpm nodepool-doc-0.4.0-1.2017.12.14.a20d81c.fc28.noarch.rpm nodepool-0.4.0-1.2017.12.14.a20d81c.fc28.src.rpm nodepool.noarch: W: spelling-error %description -l en_US devstack -> devastate nodepool.noarch: W: incoherent-version-in-changelog 0.4.0-1 ['0.4.0-1.2017.12.14.a20d81c.fc28', '0.4.0-1.2017.12.14.a20d81c'] nodepool.noarch: W: non-standard-gid /etc/nodepool/secure.conf nodepool nodepool.noarch: E: non-readable /etc/nodepool/secure.conf 640 nodepool.noarch: E: zero-length /etc/nodepool/secure.conf nodepool.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/nodepool/LICENSE nodepool.noarch: W: non-standard-uid /var/lib/nodepool nodepool nodepool.noarch: W: non-standard-gid /var/lib/nodepool nodepool nodepool.noarch: E: non-standard-dir-perm /var/lib/nodepool 750 nodepool.noarch: W: non-standard-uid /var/lib/nodepool/.config nodepool nodepool.noarch: W: non-standard-gid /var/lib/nodepool/.config nodepool nodepool.noarch: W: hidden-file-or-dir /var/lib/nodepool/.config nodepool.noarch: E: non-standard-dir-perm /var/lib/nodepool/.config 750 nodepool.noarch: W: hidden-file-or-dir /var/lib/nodepool/.config nodepool.noarch: W: non-standard-uid /var/lib/nodepool/.config/openstack nodepool nodepool.noarch: W: non-standard-gid /var/lib/nodepool/.config/openstack nodepool nodepool.noarch: E: non-standard-dir-perm /var/lib/nodepool/.config/openstack 750 nodepool.noarch: W: non-standard-uid /var/lib/nodepool/dib nodepool nodepool.noarch: W: non-standard-gid /var/lib/nodepool/dib nodepool nodepool.noarch: E: non-standard-dir-perm /var/lib/nodepool/dib 750 nodepool.noarch: W: non-standard-uid /var/log/nodepool nodepool nodepool.noarch: W: non-standard-gid /var/log/nodepool nodepool nodepool.noarch: E: non-standard-dir-perm /var/log/nodepool 750 nodepool.noarch: W: log-files-without-logrotate ['/var/log/nodepool'] nodepool.noarch: W: no-manual-page-for-binary nodepool nodepool-launcher.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/nodepool-launcher/LICENSE nodepool-launcher.noarch: W: no-manual-page-for-binary nodepool-launcher nodepool-launcher.noarch: W: empty-%postun nodepool-driver-openstack.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/nodepool-driver-openstack/LICENSE nodepool-builder.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/nodepool-builder/LICENSE nodepool-builder.noarch: W: non-standard-uid /var/cache/nodepool nodepool nodepool-builder.noarch: W: non-standard-gid /var/cache/nodepool nodepool nodepool-builder.noarch: W: non-standard-uid /var/cache/nodepool/dib_cache nodepool nodepool-builder.noarch: W: non-standard-gid /var/cache/nodepool/dib_cache nodepool nodepool-builder.noarch: W: non-standard-uid /var/cache/nodepool/dib_tmp nodepool nodepool-builder.noarch: W: non-standard-gid /var/cache/nodepool/dib_tmp nodepool nodepool-builder.noarch: W: no-manual-page-for-binary nodepool-builder nodepool-builder.noarch: W: empty-%postun nodepool-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/nodepool-doc/LICENSE nodepool-doc.noarch: W: hidden-file-or-dir /usr/share/doc/nodepool-doc/html/.buildinfo nodepool-doc.noarch: W: hidden-file-or-dir /usr/share/doc/nodepool-doc/html/.doctrees nodepool-doc.noarch: W: hidden-file-or-dir /usr/share/doc/nodepool-doc/html/.doctrees nodepool.src: W: spelling-error %description -l en_US devstack -> devastate 6 packages and 0 specfiles checked; 7 errors, 36 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1530431
--- Comment #2 from Tristan Cacqueray tdecacqu@redhat.com --- Thanks for the review Robert.
Spec URL: https://fedorapeople.org/~tdecacqu/pkgs/nodepool.spec SRPM URL: https://fedorapeople.org/~tdecacqu/pkgs/nodepool-0.4.0-1.20171214gita20d81c....
New version changes:
- Add %{?systemd_requires} - Uses %license instead of %doc - Uses %global gitdate 20171214 - Fixes release and changelog using 1.%{gitdate}git%{shortcommit}%{?dist} - Fixes LICENSE encoding - Add logrotate configuration - Add manpage with help2man - Fixes %file directives for correct ownership - Remove sphinx buildinfo
Regarding the remaining rpmlint errors:
non-readable and zero-length /etc/nodepool/secure.conf is expected and may be removed in the final release. This is a legacy file unused anymore, but the service still tries to load it.
non-standard-dir-perm 750 are expected because those directory should only be available to the nodepool user. Not sure why this is an error.
https://bugzilla.redhat.com/show_bug.cgi?id=1530431
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- Seems good, package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1530431
--- Comment #4 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nodepool. You may commit to the branch "f27" in about 10 minutes.
https://bugzilla.redhat.com/show_bug.cgi?id=1530431
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- nodepool-3.0.0-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-d2da815b3e
https://bugzilla.redhat.com/show_bug.cgi?id=1530431
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1530431
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- nodepool-3.0.0-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-75021b046f
https://bugzilla.redhat.com/show_bug.cgi?id=1530431
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- nodepool-3.0.0-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-d2da815b3e
https://bugzilla.redhat.com/show_bug.cgi?id=1530431
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- nodepool-3.0.0-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-75021b046f
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com