[Bug 731191] New: Review Request: libspnav - Open source alternative to 3DConnextion drivers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: libspnav - Open source alternative to 3DConnextion drivers
https://bugzilla.redhat.com/show_bug.cgi?id=731191
Summary: Review Request: libspnav - Open source alternative to 3DConnextion drivers Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: hobbes1069@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: http://hobbes1069.fedorapeople.org/libspnav/libspnav.spec SRPM URL: http://hobbes1069.fedorapeople.org/libspnav/libspnav-0.2.2-1.fc15.src.rpm Description: The spacenav project provides a free, compatible alternative to the proprietary 3Dconnexion device driver and SDK, for their 3D input devices (called "space navigator", "space pilot", "space traveller", etc).
This package provides the library needed for applications to connect to the user land daemon.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731191
Richard Shaw hobbes1069@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |libspnav
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731191
--- Comment #1 from Richard Shaw hobbes1069@gmail.com 2011-08-16 17:37:14 EDT --- rpmlint output:
$ ls *.rpm libspnav-0.2.2-1.fc15.src.rpm libspnav-0.2.2-1.fc15.x86_64.rpm libspnav-debuginfo-0.2.2-1.fc15.x86_64.rpm libspnav-devel-0.2.2-1.fc15.x86_64.rpm libspnav-static-0.2.2-1.fc15.x86_64.rpm
$ rpmlint *.rpm libspnav.src: W: spelling-error %description -l en_US spacenav -> spacemen libspnav.src: W: spelling-error %description -l en_US traveller -> traveler, traveled, traversal libspnav.src:43: W: rpm-buildroot-usage %build %configure --prefix=%{buildroot}%{_prefix} libspnav.x86_64: W: spelling-error %description -l en_US spacenav -> spacemen libspnav.x86_64: W: spelling-error %description -l en_US traveller -> traveler, traveled, traversal libspnav-static.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 6 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731191
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |rdieter@math.unl.edu Flag| |fedora-review?
--- Comment #2 from Rex Dieter rdieter@math.unl.edu 2011-08-17 08:46:25 EDT --- I can help review this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731191
--- Comment #3 from Richard Shaw hobbes1069@gmail.com 2011-08-17 08:53:20 EDT --- Great! I've also got spacenavd and spnavcfg packaged but haven't submitted review requests just yet.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731191
--- Comment #4 from Rex Dieter rdieter@math.unl.edu 2011-08-17 09:00:46 EDT --- naming: ok
license: BSD, ok
sources: ok b85a0f4ab711e2d4f73a40e2e371f5ae libspnav-0.2.2.tar.gz
scriptlets: ok
1. MUST: build doesn't use $RPM_OPT_FLAGS. maybe use something like: --- configure.opt 2011-08-17 07:47:12.275486930 -0500 +++ configure 2011-08-17 07:52:24.599256027 -0500 @@ -74,7 +74,7 @@ fi
if [ "$OPT" = 'yes' ]; then - echo 'opt = -O3' >>Makefile + echo 'opt = -O3 $(RPM_OPT_FLAGS)' >>Makefile fi
if [ "$X11" = 'yes' ]; then
2. MUST. static library build/packaged. Please provide justification/rationale for doing so, or remove it.
3. SHOULD. In %files, be explicit about what soname to package, so future abi bumps don't come as a surprise, use something like %files %{_libdir}/libspnav.so.0* instead?
4. SHOULD. Given all the configure/makefile hacks (optflags, DESTDIR, lib64) in the .spec, I'm wondering if it may be more worthwhile to make an upstreamable patch instead? I can help do that, if that's agreeable with you.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731191
--- Comment #5 from Richard Shaw hobbes1069@gmail.com 2011-08-17 09:12:15 EDT --- (In reply to comment #4)
- MUST: build doesn't use $RPM_OPT_FLAGS. maybe use something like:
--- configure.opt 2011-08-17 07:47:12.275486930 -0500 +++ configure 2011-08-17 07:52:24.599256027 -0500 @@ -74,7 +74,7 @@ fi
if [ "$OPT" = 'yes' ]; then
echo 'opt = -O3' >>Makefile
echo 'opt = -O3 $(RPM_OPT_FLAGS)' >>Makefilefi
if [ "$X11" = 'yes' ]; then
I'll get this updated and see if a patch wouldn't be better then a bunch of sed hacks. I usually just sed update "CFLAGS =" to "CFLAGS +="
- MUST. static library build/packaged. Please provide
justification/rationale for doing so, or remove it.
Yeah, I was wondering about that. I only packaged it because it built it. I guess I just need to "rm -f" it so I don't get an "installed but unpackaged" error
- SHOULD. In %files, be explicit about what soname to package, so future abi
bumps don't come as a surprise, use something like %files %{_libdir}/libspnav.so.0* instead?
OK
- SHOULD. Given all the configure/makefile hacks (optflags, DESTDIR, lib64)
in the .spec, I'm wondering if it may be more worthwhile to make an upstreamable patch instead? I can help do that, if that's agreeable with you.
I'll ask but these makefiles are VERY simple and the packages have not been updated recently so I wonder how active upstream is.
I'll post a new spec and SRPM shortly.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731191
--- Comment #6 from Richard Shaw hobbes1069@gmail.com 2011-08-17 09:33:22 EDT --- Spec URL: http://hobbes1069.fedorapeople.org/libspnav/libspnav.spec SRPM URL: http://hobbes1069.fedorapeople.org/libspnav/libspnav-0.2.2-2.fc15.src.rpm
* Wed Aug 17 2011 Richard Shaw hobbes1069@gmail.com - 0.2.2-2 - Patched make file to honor Fedora CFLAGS defaults. - Removed static library package. - Other minor updates to the spec file.
This addresses 1-3. If you want to help with the makefile that's great as I'm not an expert at it :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731191
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #7 from Rex Dieter rdieter@math.unl.edu 2011-08-17 14:51:39 EDT --- good enough methinks, APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731191
Richard Shaw hobbes1069@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED Flag| |fedora-cvs?
--- Comment #8 from Richard Shaw hobbes1069@gmail.com 2011-08-17 15:06:41 EDT --- New Package SCM Request ======================= Package Name: libspnav Short Description: Open source alternative to 3DConnextion drivers Owners: hobbes1069 Branches: f15 f16 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731191
--- Comment #9 from Jon Ciesla limb@jcomserv.net 2011-08-17 15:58:20 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731191
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-08-17 17:02:46 EDT --- libspnav-0.2.2-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/libspnav-0.2.2-2.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731191
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2011-08-17 17:02:56 EDT --- libspnav-0.2.2-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/libspnav-0.2.2-2.fc16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731191
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-08-18 18:04:10 EDT --- libspnav-0.2.2-2.fc16 has been pushed to the Fedora 16 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731191
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-09-06 20:15:32 EDT --- libspnav-0.2.2-2.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731191
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |libspnav-0.2.2-2.fc15 Resolution| |ERRATA Last Closed| |2011-09-06 20:15:37
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731191
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2011-09-06 23:43:30 EDT --- libspnav-0.2.2-2.fc16 has been pushed to the Fedora 16 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731191
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|libspnav-0.2.2-2.fc15 |libspnav-0.2.2-2.fc16
https://bugzilla.redhat.com/show_bug.cgi?id=731191
John Morris john@zultron.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |john@zultron.com
--- Comment #15 from John Morris john@zultron.com --- Package Change Request ====================== Package Name: libspnav New Branches: el6 Owners: zultron hobbes1069 InitialCC:
The owner of this package (hobbes1069) and I (zultron) are building this package for EPEL6.
https://bugzilla.redhat.com/show_bug.cgi?id=731191
John Morris john@zultron.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ | Flags| |fedora-cvs?
https://bugzilla.redhat.com/show_bug.cgi?id=731191
--- Comment #16 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=731191
Richard Shaw hobbes1069@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ |fedora-cvs?
--- Comment #17 from Richard Shaw hobbes1069@gmail.com --- Package Change Request ====================== Package Name: libspnav New Branches: epel7 Owners: zultron hobbes1069 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=731191
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=731191
--- Comment #18 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla