[Bug 728664] New: Review Request: django-pylibmc - Django cache backend using pylibmc

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: django-pylibmc - Django cache backend using pylibmc

https://bugzilla.redhat.com/show_bug.cgi?id=728664

           Summary: Review Request: django-pylibmc - Django cache backend
                    using pylibmc
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: nobody(a)fedoraproject.org
        ReportedBy: kumarpraveen.nitdgp(a)gmail.com
         QAContact: extras-qa(a)fedoraproject.org
                CC: notting(a)redhat.com,
                    package-review(a)lists.fedoraproject.org
    Classification: Fedora
      Story Points: ---
              Type: ---


Spec URL:
http://kumarpraveen.fedorapeople.org/django-pylibmc/django-pylibmc.spec
SRPM URL:
http://kumarpraveen.fedorapeople.org/django-pylibmc/django-pylibmc-0.2.1-...
Description: Django-pylibmc package provides a memcached cache backend for
Django using pylibmc. You want to use pylibmc because it's fast.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 728664] Review Request: django-pylibmc - Django cache backend using pylibmc

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=728664

Praveen Kumar <kumarpraveen.nitdgp(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |728662
               Flag|                            |fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 728664] Review Request: django-pylibmc - Django cache backend using pylibmc

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=728664

Ankur Sinha <sanjay.ankur(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |sanjay.ankur(a)gmail.com
         AssignedTo|nobody(a)fedoraproject.org    |sanjay.ankur(a)gmail.com
               Flag|fedora-review?              |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 728664] Review Request: django-pylibmc - Django cache backend using pylibmc

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=728664

Ankur Sinha <sanjay.ankur(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 728664] Review Request: django-pylibmc - Django cache backend using pylibmc

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=728664

Ankur Sinha <sanjay.ankur(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|728662                      |
         Depends on|                            |728662

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 728664] Review Request: django-pylibmc - Django cache backend using pylibmc

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=728664

--- Comment #1 from Ankur Sinha <sanjay.ankur(a)gmail.com&gt; 2011-08-07 14:02:52 EDT
---
REVIEW:

+ OK
- NA
? ISSUE

+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.
+ Sources match upstream md5sum:
git checkout, confirmed using diff. 

- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package is code or permissible content.
- Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.

- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.

- Package is a GUI app and has a .desktop file

+ Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
+ No rpmlint output.
^^
[ankur@ankur SRPMS]$ rpmlint /var/lib/mock/fedora-rawhide-i386/result/*.rpm
../SPECS/django-pylibmc.spec
django-pylibmc-0.2.1-1.20110806gitb56e74.fc15.src.rpm 
django-pylibmc.noarch: W: spelling-error Summary(en_US) backend -> backed, back
end, back-end
django-pylibmc.noarch: W: spelling-error %description -l en_US memcached ->
schemed
django-pylibmc.noarch: W: spelling-error %description -l en_US backend ->
backed, back end, back-end
django-pylibmc.src: W: spelling-error Summary(en_US) backend -> backed, back
end, back-end
django-pylibmc.src: W: spelling-error %description -l en_US memcached ->
schemed
django-pylibmc.src: W: spelling-error %description -l en_US backend -> backed,
back end, back-end
django-pylibmc.src: W: invalid-url Source0:
django-pylibmc-0.2.1.20110806gitb56e74.tar.xz
../SPECS/django-pylibmc.spec: W: invalid-url Source0:
django-pylibmc-0.2.1.20110806gitb56e74.tar.xz
django-pylibmc.src: W: spelling-error Summary(en_US) backend -> backed, back
end, back-end
django-pylibmc.src: W: spelling-error %description -l en_US memcached ->
schemed
django-pylibmc.src: W: spelling-error %description -l en_US backend -> backed,
back end, back-end
django-pylibmc.src: W: invalid-url Source0:
django-pylibmc-0.2.1.20110806gitb56e74.tar.xz
3 packages and 1 specfiles checked; 0 errors, 12 warnings.

ONLY MINOR SPELLING SUGGESTIONS. OK

+ final provides and requires are sane:
[ankur@ankur result]$ review-req-check 
== django-pylibmc-0.2.1-1.20110806gitb56e74.fc17.noarch.rpm ==
Provides:
django-pylibmc = 0.2.1-1.20110806gitb56e74.fc17

Requires:
python(abi) = 2.7

== django-pylibmc-0.2.1-1.20110806gitb56e74.fc17.src.rpm ==
Provides:

Requires:
python-devel  
python-setuptools  
python-pylibmc  
Django  


SHOULD Items:

+ Should build in mock.
+ Should build on all supported archs
- Should function as described.
- Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
+ Should package latest version
- check for outstanding bugs on package. (For core merge reviews)

Issues:

1. Again, only a cosmetic suggestion for the setup macro directory name. Can be
a simple %{name}. 

I'll approve this as soon as python-pylibmc is approved and built for rawhide.
(It's *blocking* this one)


Thanks,
Ankur

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 728664] Review Request: django-pylibmc - Django cache backend using pylibmc

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=728664

--- Comment #2 from Praveen Kumar <kumarpraveen.nitdgp(a)gmail.com&gt; 2011-08-08
21:11:42 EDT ---
Thanks for tip.

Spec URL:
http://kumarpraveen.fedorapeople.org/django-pylibmc/django-pylibmc.spec
SRPM URL:
http://kumarpraveen.fedorapeople.org/django-pylibmc/django-pylibmc-0.2.1-...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 728664] Review Request: django-pylibmc - Django cache backend using pylibmc

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=728664

--- Comment #3 from Praveen Kumar <kumarpraveen.nitdgp(a)gmail.com&gt; 2011-08-11
10:00:53 EDT ---
Koji Build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3265945

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 728664] Review Request: django-pylibmc - Django cache backend using pylibmc

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=728664

--- Comment #4 from Praveen Kumar <kumarpraveen.nitdgp(a)gmail.com&gt; 2011-08-11
10:14:07 EDT ---
Spec URL:
http://kumarpraveen.fedorapeople.org/django-pylibmc/django-pylibmc.spec
SRPM URL:
http://kumarpraveen.fedorapeople.org/django-pylibmc/django-pylibmc-0.2.1-...

koji build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3265978

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 728664] Review Request: django-pylibmc - Django cache backend using pylibmc

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=728664

Ankur Sinha <sanjay.ankur(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #5 from Ankur Sinha <sanjay.ankur(a)gmail.com&gt; 2011-08-11 11:01:23 EDT
---
Okay! 

Nice work. Package is good to go.

[ankur@ankur SRPMS]$ rpmlint /var/lib/mock/fedora-rawhide-*/result/*.rpm
django-pylibmc.noarch: W: spelling-error Summary(en_US) backend -> backed, back
end, back-end
django-pylibmc.noarch: W: spelling-error %description -l en_US memcached ->
schemed
django-pylibmc.noarch: W: spelling-error %description -l en_US backend ->
backed, back end, back-end
django-pylibmc.src: W: spelling-error Summary(en_US) backend -> backed, back
end, back-end
django-pylibmc.src: W: spelling-error %description -l en_US memcached ->
schemed
django-pylibmc.src: W: spelling-error %description -l en_US backend -> backed,
back end, back-end
django-pylibmc.src: W: invalid-url Source0:
django-pylibmc-0.2.1.20110806gitb56e74.tar.xz
django-pylibmc.noarch: W: spelling-error Summary(en_US) backend -> backed, back
end, back-end
django-pylibmc.noarch: W: spelling-error %description -l en_US memcached ->
schemed
django-pylibmc.noarch: W: spelling-error %description -l en_US backend ->
backed, back end, back-end
django-pylibmc.src: W: spelling-error Summary(en_US) backend -> backed, back
end, back-end
django-pylibmc.src: W: spelling-error %description -l en_US memcached ->
schemed
django-pylibmc.src: W: spelling-error %description -l en_US backend -> backed,
back end, back-end
django-pylibmc.src: W: invalid-url Source0:
django-pylibmc-0.2.1.20110806gitb56e74.tar.xz
4 packages and 0 specfiles checked; 0 errors, 14 warnings.


XXX APPROVED XXX
Ankur

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 728664] Review Request: django-pylibmc - Django cache backend using pylibmc

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=728664

--- Comment #6 from Praveen Kumar <kumarpraveen.nitdgp(a)gmail.com&gt; 2011-08-11
12:22:57 EDT ---
New Package SCM Request
=======================
Package Name: django-pylibmc
Short Description: Django cache backend using pylibmc 
Owners: sundaram pjp kumarpraveen
Branches: f14 f15 el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 728664] Review Request: django-pylibmc - Django cache backend using pylibmc

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=728664

Praveen Kumar <kumarpraveen.nitdgp(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 728664] Review Request: django-pylibmc - Django cache backend using pylibmc

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=728664

--- Comment #7 from Jon Ciesla <limb(a)jcomserv.net&gt; 2011-08-13 10:36:42 EDT ---
Git done (by process-git-requests).

Added f16.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 728664] Review Request: django-pylibmc - Django cache backend using pylibmc

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=728664

Bug 728664 depends on bug 728662, which changed state.

Bug 728662 Summary: Review Request: python-pylibmc - Memcached client for Python
https://bugzilla.redhat.com/show_bug.cgi?id=728662

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |CURRENTRELEASE

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 728664] Review Request: django-pylibmc - Django cache backend using pylibmc

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=728664

Ankur Sinha (FranciscoD) <sanjay.ankur(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |CURRENTRELEASE
        Last Closed|                            |2012-10-18 19:04:02

--- Comment #8 from Ankur Sinha (FranciscoD) <sanjay.ankur(a)gmail.com&gt; ---
Package available in repositories. Closing bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.