[Bug 2364400] New: Review Request: kurchu - Assembles Fedora/CentOS resources to create artifact collections
https://bugzilla.redhat.com/show_bug.cgi?id=2364400
Bug ID: 2364400 Summary: Review Request: kurchu - Assembles Fedora/CentOS resources to create artifact collections Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ngompa13@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/ngompa/Kurchu/fedora-rawh... SRPM URL: https://download.copr.fedorainfracloud.org/results/ngompa/Kurchu/fedora-rawh... Description: Kurchu assembles Fedora/CentOS resources to create artifact collections.
Fedora Account System Username: ngompa
https://bugzilla.redhat.com/show_bug.cgi?id=2364400
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://download.copr.fedorainfracloud.org/results/ngompa/Kurchu/fedora-rawh... SRPM URL: https://download.copr.fedorainfracloud.org/results/ngompa/Kurchu/fedora-rawh...
Description: Kurchu assembles Fedora/CentOS resources to create artifact collections.
Fedora Account System Username: ngompa
https://bugzilla.redhat.com/show_bug.cgi?id=2364400
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/Velocity | |Limitless/Projects/%{name} Keywords| |AutomationTriaged
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9002313 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2364400
Simon de Vlieger cmdr@supakeen.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cmdr@supakeen.com Flags| |fedora-review? Assignee|nobody@fedoraproject.org |cmdr@supakeen.com Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2364400
--- Comment #2 from Simon de Vlieger cmdr@supakeen.com --- Package Review ==============
I didn't find anything wrong with this package. Approving. See below for the checklist that I performed.
Note that rpmlint throws "incorrect-fsf-address" and you will need to inform upstream about this, per the package maintainers documentation but this is not a blocker on the review.
This version isn't the latest version (you release 0.4.2 upstream an hour ago) but that's a should item.
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [+]: License field in the package spec file matches the actual license. [+]: Package must own all directories that it creates. [+]: Package contains no bundled libraries without FPC exception. [+]: Changelog in prescribed format. [+]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [+]: Package consistently uses macros (instead of hard-coded directory names). [+]: Package is named according to the Package Naming Guidelines. [+]: Package does not generate any conflict. [+]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [+]: Requires correct, justified where necessary. [+]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [+]: Package is not known to require an ExcludeArch tag. [+]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5531 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [+]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [+]: Final provides and requires are sane (see attachments). [+]: Package functions as described. [!]: Latest version is packaged. [+]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [+]: %check is present and all tests pass. [+]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
https://bugzilla.redhat.com/show_bug.cgi?id=2364400
Simon de Vlieger cmdr@supakeen.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=2364400
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RELEASE_PENDING
--- Comment #3 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/kurchu
https://bugzilla.redhat.com/show_bug.cgi?id=2364400
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2025-9af35de34a (kurchu-0.4.3-1.el10_0) has been submitted as an update to Fedora EPEL 10.0. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-9af35de34a
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-83793a716a (kurchu-0.4.3-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-83793a716a
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-3a8f652a26 (kurchu-0.4.3-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-3a8f652a26
https://bugzilla.redhat.com/show_bug.cgi?id=2364400
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2025-9af35de34a (kurchu-0.4.3-1.el10_0) has been submitted as an update to Fedora EPEL 10.0. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-9af35de34a
https://bugzilla.redhat.com/show_bug.cgi?id=2364400
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2025-9af35de34a (kurchu-0.4.3-1.el10_0) has been submitted as an update to Fedora EPEL 10.0. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-9af35de34a
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-83793a716a (kurchu-0.4.3-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-83793a716a
https://bugzilla.redhat.com/show_bug.cgi?id=2364400
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-a218f97d7f (kurchu-0.4.3-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-a218f97d7f
https://bugzilla.redhat.com/show_bug.cgi?id=2364400
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2025-05-07 03:22:49
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-3a8f652a26 (kurchu-0.4.3-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2364400
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-83793a716a (kurchu-0.4.3-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2364400
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2025-c2d1320126 has been pushed to the Fedora EPEL 10.1 testing repository.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-c2d1320126
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2364400
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2025-9af35de34a has been pushed to the Fedora EPEL 10.0 testing repository.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-9af35de34a
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2364400
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-a218f97d7f (kurchu-0.4.3-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2364400
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2025-9af35de34a (kurchu-0.4.3-1.el10_0) has been pushed to the Fedora EPEL 10.0 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2364400
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2025-9af35de34a (kurchu-0.4.3-1.el10_0) has been pushed to the Fedora EPEL 10.0 stable repository. If problem still persists, please make note of it in this bug report.
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2025-c2d1320126 (kurchu-0.4.3-1.el10_1) has been pushed to the Fedora EPEL 10.1 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com