[Bug 437046] New: Review Request: mod_bw - Bandwidth Limiter For Apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=437046

Summary: Review Request: mod_bw - Bandwidth Limiter For Apache
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://hrozkovi.cz/fedora/mod_bw.spec
SRPM URL: http://hrozkovi.cz/fedora/mod_bw-0.8-1.fc7.src.rpm
Description: 
mod_bw is a bandwidth administration module for Apache httpd 2.x

* Restricts the number of simultaneous connections per vhost/dir
* Limits the bandwidth for files on vhost/dir

[Bug 437046] Review Request: mod_bw - Bandwidth Limiter For Apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mod_bw - Bandwidth Limiter For Apache

https://bugzilla.redhat.com/show_bug.cgi?id=437046

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+

------- Additional Comments From [e-mail]  2008-05-10 23:16 EST -------
Not sure why this hasn't been reviewed yet; it's a trivial package.

* source files match upstream:
   75d43f586b7662ccca7d67bc67c52e25a341c6caef89a4804fedbeaee25a13b3  
   mod_bw-0.8.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   config(mod_bw) = 0.8-1.fc9
   mod_bw.so()(64bit)
   mod_bw = 0.8-1.fc9
  =
   config(mod_bw) = 0.8-1.fc9
   httpd

* %check is not present; no test suite upstream.  I can't easily test this.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED

[Bug 437046] Review Request: mod_bw - Bandwidth Limiter For Apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mod_bw - Bandwidth Limiter For Apache

https://bugzilla.redhat.com/show_bug.cgi?id=437046

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2008-05-15 03:34 EST -------
New Package CVS Request
=======================
Package Name: mod_bw
Short Description: Bandwidth Limiter For Apache
Owners: jhrozek
Branches: F-8 F-9
InitialCC: N/A
Cvsextras Commits: yes

[Bug 437046] Review Request: mod_bw - Bandwidth Limiter For Apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mod_bw - Bandwidth Limiter For Apache

https://bugzilla.redhat.com/show_bug.cgi?id=437046

------- Additional Comments From [e-mail]  2008-05-15 03:35 EST -------
Thanks for the review, Tibbs!

[Bug 437046] Review Request: mod_bw - Bandwidth Limiter For Apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mod_bw - Bandwidth Limiter For Apache

https://bugzilla.redhat.com/show_bug.cgi?id=437046

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-05-15 12:06 EST -------
cvs done.

Would you consider maintaining or allowing someone else to maintain EPEL
branches of this package. I could be very useful in EPEL.

[Bug 437046] Review Request: mod_bw - Bandwidth Limiter For Apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mod_bw - Bandwidth Limiter For Apache

https://bugzilla.redhat.com/show_bug.cgi?id=437046

------- Additional Comments From [e-mail]  2008-05-16 05:31 EST -------
(In reply to comment #4)
> Would you consider maintaining or allowing someone else to maintain EPEL
> branches of this package. I could be very useful in EPEL.

OK, I'm not planning to use the package on my CentOS box myself but I agree 
that it might be useful. I'll maintain it myself for EL-5 since the codebase 
is pretty slow target anyway. Thanks for the reminder!

[Bug 437046] Review Request: mod_bw - Bandwidth Limiter For Apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mod_bw - Bandwidth Limiter For Apache

https://bugzilla.redhat.com/show_bug.cgi?id=437046

------- Additional Comments From [e-mail]  2008-05-16 05:31 EST -------
Package Change Request
======================
Package Name: mod_bw
New Branches: EL-5

[Bug 437046] Review Request: mod_bw - Bandwidth Limiter For Apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mod_bw - Bandwidth Limiter For Apache

https://bugzilla.redhat.com/show_bug.cgi?id=437046

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?

[Bug 437046] Review Request: mod_bw - Bandwidth Limiter For Apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mod_bw - Bandwidth Limiter For Apache

https://bugzilla.redhat.com/show_bug.cgi?id=437046

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-05-16 11:10 EST -------
Thanks.

cvs done.

[Bug 437046] Review Request: mod_bw - Bandwidth Limiter For Apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mod_bw - Bandwidth Limiter For Apache

https://bugzilla.redhat.com/show_bug.cgi?id=437046

------- Additional Comments From [e-mail]  2008-05-22 17:06 EST -------
mod_bw-0.8-1.fc8 has been submitted as an update for Fedora 8

[Bug 437046] Review Request: mod_bw - Bandwidth Limiter For Apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mod_bw - Bandwidth Limiter For Apache

https://bugzilla.redhat.com/show_bug.cgi?id=437046

------- Additional Comments From [e-mail]  2008-05-22 17:07 EST -------
mod_bw-0.8-1.fc9 has been submitted as an update for Fedora 9

[Bug 437046] Review Request: mod_bw - Bandwidth Limiter For Apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mod_bw - Bandwidth Limiter For Apache

https://bugzilla.redhat.com/show_bug.cgi?id=437046

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2008-05-22 17:31 EST -------
Built for rawhide, F-9-testing, F-8-testing and EL-5-testing.

Closing.

[Bug 437046] Review Request: mod_bw - Bandwidth Limiter For Apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mod_bw - Bandwidth Limiter For Apache

https://bugzilla.redhat.com/show_bug.cgi?id=437046

------- Additional Comments From [e-mail]  2008-06-11 19:33 EST -------
mod_bw-0.8-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

[Bug 437046] Review Request: mod_bw - Bandwidth Limiter For Apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mod_bw - Bandwidth Limiter For Apache

https://bugzilla.redhat.com/show_bug.cgi?id=437046

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |CLOSED
         Resolution|NEXTRELEASE                 |CURRENTRELEASE
   Fixed In Version|                            |0.8-1.fc9

[Bug 437046] Review Request: mod_bw - Bandwidth Limiter For Apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mod_bw - Bandwidth Limiter For Apache

https://bugzilla.redhat.com/show_bug.cgi?id=437046

------- Additional Comments From [e-mail]  2008-06-11 19:35 EST -------
mod_bw-0.8-1.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.