[Bug 744522] New: Review Request: perl-Moo - Minimalist Object Orientation (with Moose compatibility)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Moo - Minimalist Object Orientation (with Moose compatibility)
Alias: perl-Moo

https://bugzilla.redhat.com/show_bug.cgi?id=744522

Summary: Review Request: perl-Moo - Minimalist Object
                    Orientation (with Moose compatibility)
           Product: Fedora
           Version: rawhide
          Platform: Unspecified
               URL: http://search.cpan.org/dist/Moo/
        OS/Version: Unspecified
            Status: NEW
          Severity: unspecified
          Priority: unspecified
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],
                    [e-mail]
        Depends on: 742742
    Classification: Fedora
      Story Points: ---
              Type: ---

Spec URL: http://fedorapeople.org/~iarnell/review/perl-Moo.spec
SRPM URL:
http://fedorapeople.org/~iarnell/review/perl-Moo-0.009010-1.fc17.src.rpm

Description:
This module is an extremely light-weight, high-performance Moose
replacement. It also avoids depending on any XS modules to allow simple
deployments. The name Moo is based on the idea that it provides almost -but
not quite- two thirds of Moose.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3416038

*rt-0.10_01

[Bug 744522] Review Request: perl-Moo - Minimalist Object Orientation (with Moose compatibility)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=744522

Emmanuel Seyman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |emmanuel.seyman@club-intern
                   |                            |et.fr
         AssignedTo|[e-mail]    |emmanuel.seyman@club-intern
                   |                            |et.fr
               Flag|                            |fedora-review?

--- Comment #1 from Emmanuel Seyman  2011-10-09 05:39:14 EDT ---
Taking.

[Bug 744522] Review Request: perl-Moo - Minimalist Object Orientation (with Moose compatibility)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=744522

Emmanuel Seyman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #2 from Emmanuel Seyman  2011-10-09 05:58:28 EDT ---
=== KEY ===

- = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===

[x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3416090

[x] Rpmlint output: 2 packages and 1 specfiles checked; 0 errors, 0 warnings.
 [x] Package is not relocatable.
 [x] Buildroot is correct
None specified, default used.

[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: GPL+ or Artistic
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
474b3dd37189b7a5056ec6d2d25096d2  Moo-0.009010.tar.gz

[x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [-] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [-] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===

[!] Latest version is packaged.
Moo-0.009011 is out there as of last week.

[x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: fedora-rawhide-x86_64
 [x] Package should compile and build into binary rpms on all supported
architectures.
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=3416090
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the tests pass
All tests successful.
Files=23, Tests=188,  1 wallclock secs ( 0.08 usr  0.01 sys +  0.74 cusr  0.08
csys =  0.91 CPU)
Result: PASS

APPROVED.

[Bug 744522] Review Request: perl-Moo - Minimalist Object Orientation (with Moose compatibility)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=744522

--- Comment #3 from Iain Arnell  2011-10-09 06:02:36 EDT ---
New Package SCM Request
=======================
Package Name: perl-Moo
Short Description: Minimalist Object Orientation (with Moose compatibility)
Owners: iarnell
Branches: f15 f16
InitialCC: perl-sig

[Bug 744522] Review Request: perl-Moo - Minimalist Object Orientation (with Moose compatibility)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=744522

Iain Arnell  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 744522] Review Request: perl-Moo - Minimalist Object Orientation (with Moose compatibility)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=744522

--- Comment #4 from Iain Arnell  2011-10-09 06:08:15 EDT ---
Thanks for the review.
> [!] Latest version is packaged.
> Moo-0.009011 is out there as of last week.

Oh, so it is. Will update as soon as I've imported this version.

[Bug 744522] Review Request: perl-Moo - Minimalist Object Orientation (with Moose compatibility)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=744522

--- Comment #5 from Jon Ciesla  2011-10-09 13:50:55 EDT ---
Git done (by process-git-requests).

[Bug 744522] Review Request: perl-Moo - Minimalist Object Orientation (with Moose compatibility)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=744522

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

Bug 744522 depends on bug 742742, which changed state.

Bug 742742 Summary: Review Request: perl-strictures - Turn on strict and make all warnings fatal
https://bugzilla.redhat.com/show_bug.cgi?id=742742

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |ERRATA
             Status|ON_QA                       |CLOSED

[Bug 744522] Review Request: perl-Moo - Minimalist Object Orientation (with Moose compatibility)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=744522

--- Comment #6 from Fedora Update System  2011-10-11 03:38:30 EDT ---
perl-Moo-0.009011-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/perl-Moo-0.009011-1.fc16

[Bug 744522] Review Request: perl-Moo - Minimalist Object Orientation (with Moose compatibility)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=744522

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #7 from Fedora Update System  2011-10-12 12:47:46 EDT ---
perl-Moo-0.009011-1.fc16 has been pushed to the Fedora 16 testing repository.

[Bug 744522] Review Request: perl-Moo - Minimalist Object Orientation (with Moose compatibility)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=744522

--- Comment #8 from Fedora Update System  2011-10-12 23:32:11 EDT ---
perl-Moo-0.009011-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/perl-Moo-0.009011-1.fc15

[Bug 744522] Review Request: perl-Moo - Minimalist Object Orientation (with Moose compatibility)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=744522

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |perl-Moo-0.009011-1.fc16
         Resolution|                            |ERRATA
        Last Closed|                            |2011-10-20 00:00:46

--- Comment #9 from Fedora Update System  2011-10-20 00:00:46 EDT ---
perl-Moo-0.009011-1.fc16 has been pushed to the Fedora 16 stable repository.

[Bug 744522] Review Request: perl-Moo - Minimalist Object Orientation (with Moose compatibility)

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=744522

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|perl-Moo-0.009011-1.fc16    |perl-Moo-0.009011-1.fc15

--- Comment #10 from Fedora Update System  2011-10-22 04:30:07 EDT ---
perl-Moo-0.009011-1.fc15 has been pushed to the Fedora 15 stable repository.