[Bug 226665] New: Merge Review: yp-tools

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226665

Summary: Merge Review: yp-tools
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: yp-tools

http://cvs.fedora.redhat.com/viewcvs/devel/yp-tools/
Initial Owner: [e-mail]

[Bug 226665] Merge Review: yp-tools

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226665

Jiri Popelka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail],
                   |                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]

[Bug 226665] Merge Review: yp-tools

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226665

Jiri Popelka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #1 from Jiri Popelka   2009-11-26 05:19:30 EDT ---
formal review of yp-tools-2.9-8.fc12 is here, see the notes below:

YES source files match upstream:
  19de06a04129ec26773f9198e086fcd4  yp-tools-2.9.tar.bz2
YES package meets naming and versioning guidelines.
YES specfile is properly named, is cleanly written and uses macros
consistently.
YES dist tag is present.
YES build root is correct.
YES license field matches the actual license.
YES license is open source-compatible.
YES License text included in package.

NO latest version is being packaged.
  http://www.linux-nis.org/nis/yp-tools/index.html
  claims current version is yp-tools-2.10

N/A BuildRequires are proper.
YES compiler flags are appropriate.
YES %clean is present.
YES package builds in mock (Rawhide/x86_64).
YES debuginfo package looks complete.

NO rpmlint is silent.
  yp-tools.src: W: summary-ended-with-dot NIS (or YP) client programs.
  yp-tools.src:11: W: unversioned-explicit-obsoletes yppasswd
  yp-tools.src:11: W: unversioned-explicit-obsoletes yp-clients
  yp-tools.x86_64: W: summary-ended-with-dot NIS (or YP) client programs.
  yp-tools.x86_64: W: obsolete-not-provided yppasswd
  yp-tools.x86_64: W: obsolete-not-provided yp-clients

YES final provides and requires look sane.
N/A %check is present and all tests pass.
YES no shared libraries are added to the regular linker search paths.
YES owns the directories it creates.
YES doesn't own any directories it shouldn't.
YES no duplicates in %files.
YES file permissions are appropriate.
YES no scriptlets present.
YES code, not content.
YES documentation is small, so no -docs subpackage is necessary.
YES %docs are not necessary for the proper functioning of the package.
YES no headers.
YES no pkgconfig files.
YES no libtool .la droppings.
YES not a GUI app.

I think these above mentioned rpmlint warnings may be omitted.
yp-tools-2.9-8.fc12 is all right
(I hope version 2.10 will be included in next release)
so I'm giving APPROVED.

[Bug 226665] Merge Review: yp-tools

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226665

Karel Klíč  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #2 from Karel Klíč   2009-12-10 10:18:12 EDT ---
The rpmlint warnings were fixed.
The package was updated to the newest version.

Thank you, Jiri, for the review.