[Bug 1520582] New: Review Request: perl-Mojolicious-Plugin-I18N - Internationalization Plugin for Mojolicious
https://bugzilla.redhat.com/show_bug.cgi?id=1520582
Bug ID: 1520582 Summary: Review Request: perl-Mojolicious-Plugin-I18N - Internationalization Plugin for Mojolicious Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: zebob.m@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/749fc2d/perl-Mojoliciou... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhi...
Description: Mojolicious::Plugin::I18N is internationalization plugin for Mojolicious It works with Mojolicious 4.0+.
Fedora Account System Username: eclipseo
https://bugzilla.redhat.com/show_bug.cgi?id=1520582
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/047fc7f/perl-Mojoliciou... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhi...
https://bugzilla.redhat.com/show_bug.cgi?id=1520582
--- Comment #2 from Robert-André Mauchin zebob.m@gmail.com --- Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/044a039/perl-Mojoliciou... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhi...
https://bugzilla.redhat.com/show_bug.cgi?id=1520582
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@redhat.com Assignee|nobody@fedoraproject.org |ppisar@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1520582
--- Comment #3 from Petr Pisar ppisar@redhat.com --- Url and Source0 are usable. Ok. Source0 archive (SHA-256: 32fb5ef8037d954b7ecebef5c1b2b24b420abd829702312f4ad42794f52b514d) is original. Ok. Summary verified from lib/Mojolicious/Plugin/I18N.pm. Ok.
TODO: The description text is missing a full stop before "It" word.
FIX: The License tag is wrong. lib/Mojolicious/Plugin/I18N.pm and README.pod states "Artistic 2.0". The specification at Build.PL:7 is probably a mistake.
FIX: Build-require 'perl(constant)' (lib/Mojolicious/Plugin/I18N.pm:153). FIX: Build-require 'perl(I18N::LangTags::Detect)' (lib/Mojolicious/Plugin/I18N.pm:6). FIX: Build-require 'perl(Mojo::Base)' (lib/Mojolicious/Plugin/I18N.pm:2). FIX: Build-require 'perl(Mojo::URL)' (lib/Mojolicious/Plugin/I18N.pm:4). FIX: Build-require 'perl(Mojolicious::Plugin)' (lib/Mojolicious/Plugin/I18N.pm:2)'.
FIX: Build-require 'perl(base)' (t/i18n.t:16). FIX: Build-require 'perl(lib)' (t/i18n.t:2). FIX: Build-require 'perl(Locale::Maketext)' (t/i18n.t:16). FIX: Build-require 'perl(Mojolicious::Lite)' (t/i18n.t:29).
TODO: You should run-require 'perl(Mojolicious) >= 5' for the same reason as you build-require it.
Please correct all 'FIX' items, consider fixing 'TODO' items, and provide a new spec file. Resolution: Package NOT approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1520582
--- Comment #4 from Robert-André Mauchin zebob.m@gmail.com --- Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/6a344cc/perl-Mojoliciou... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhi...
SPEC diff: https://github.com/eclipseo/packaging/commit/6a344cc87bd5fff63d9ab6beffb63da...
Thanks for the review.
https://bugzilla.redhat.com/show_bug.cgi?id=1520582
--- Comment #5 from Petr Pisar ppisar@redhat.com ---
TODO: The description text is missing a full stop before "It" word.
Ok.
FIX: The License tag is wrong. lib/Mojolicious/Plugin/I18N.pm and README.pod states "Artistic 2.0". The specification at Build.PL:7 is probably a mistake.
Ok.
FIX: Build-require 'perl(constant)' (lib/Mojolicious/Plugin/I18N.pm:153).
Ok.
FIX: Build-require 'perl(I18N::LangTags::Detect)' (lib/Mojolicious/Plugin/I18N.pm:6).
Ok.
FIX: Build-require 'perl(Mojo::Base)' (lib/Mojolicious/Plugin/I18N.pm:2).
Ok.
FIX: Build-require 'perl(Mojo::URL)' (lib/Mojolicious/Plugin/I18N.pm:4).
Ok.
FIX: Build-require 'perl(Mojolicious::Plugin)' (lib/Mojolicious/Plugin/I18N.pm:2)'.
Ok.
FIX: Build-require 'perl(base)' (t/i18n.t:16).
Ok.
FIX: Build-require 'perl(lib)' (t/i18n.t:2).
Ok.
FIX: Build-require 'perl(Locale::Maketext)' (t/i18n.t:16).
Ok.
FIX: Build-require 'perl(Mojolicious::Lite)' (t/i18n.t:29).
Ok.
TODO: You should run-require 'perl(Mojolicious) >= 5' for the same reason as you build-require it.
Ok.
Fix: Build-require 'perl(utf8)' (t/i18n.t:3).
All tests pass. Ok.
$ rpmlint perl-Mojolicious-Plugin-I18N.spec ../SRPMS/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.src.rpm ../RPMS/noarch/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm perl-Mojolicious-Plugin-I18N.noarch: E: wrong-script-interpreter /usr/share/doc/perl-Mojolicious-Plugin-I18N/script/app_i18n_mail.pl /usr/bin/env perl 2 packages and 1 specfiles checked; 1 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm drwxr-xr-x 2 root root 0 Jan 8 10:29 /usr/share/doc/perl-Mojolicious-Plugin-I18N -rw-r--r-- 1 root root 965 Aug 11 2015 /usr/share/doc/perl-Mojolicious-Plugin-I18N/Changes drwxr-xr-x 2 root root 0 Aug 11 2015 /usr/share/doc/perl-Mojolicious-Plugin-I18N/script -rw-r--r-- 1 root root 586 Aug 11 2015 /usr/share/doc/perl-Mojolicious-Plugin-I18N/script/App.pm -rw-r--r-- 1 root root 446 Aug 11 2015 /usr/share/doc/perl-Mojolicious-Plugin-I18N/script/app_i18n_mail.pl -rw-r--r-- 1 root root 98 Aug 11 2015 /usr/share/doc/perl-Mojolicious-Plugin-I18N/script/test.mail.ep -rw-r--r-- 1 root root 3254 Jan 8 10:29 /usr/share/man/man3/Mojolicious::Plugin::I18N.3pm.gz drwxr-xr-x 2 root root 0 Jan 8 10:29 /usr/share/perl5/vendor_perl/Mojolicious drwxr-xr-x 2 root root 0 Jan 8 10:29 /usr/share/perl5/vendor_perl/Mojolicious/Plugin -rw-r--r-- 1 root root 8488 Jan 8 10:29 /usr/share/perl5/vendor_perl/Mojolicious/Plugin/I18N.pm File permissions and layout are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.1) 1 perl(constant) 1 perl(I18N::LangTags) 1 perl(I18N::LangTags::Detect) 1 perl(Mojo::Base) 1 perl(Mojo::URL) 1 perl(Mojolicious) >= 5 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Run-require 'perl(Mojolicious::Plugin)' (lib/Mojolicious/Plugin/I18N.pm:2). FIX: Run-require 'perl(strict)' (lib/Mojolicious/Plugin/I18N.pm:143). FIX: Run-require 'perl(warnings)' (lib/Mojolicious/Plugin/I18N.pm:144). FIX: Constrain 'perl(I18N::LangTags)' run-time dependency with '>= 0.35' (META.json:36).
$ rpm -q --provides -p ../RPMS/noarch/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm | sort -f | uniq -c 1 perl(Mojolicious::Plugin::I18N) = 1.6 1 perl(Mojolicious::Plugin::I18N::_Handler) 1 perl-Mojolicious-Plugin-I18N = 1.6-1.fc28 Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm Binary dependencies resolvable. Ok.
The package builds in F28 (https://koji.fedoraproject.org/koji/taskinfo?taskID=24071493). Ok.
Please correct all 'FIX' items and provide a new spec file. Resolution: Package NOT approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1520582
--- Comment #6 from Robert-André Mauchin zebob.m@gmail.com --- Spec URL: https://raw.githubusercontent.com/eclipseo/packaging/a73a5ca/perl-Mojoliciou... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhi...
SPEC diff: https://github.com/eclipseo/packaging/commit/a73a5cad5715dad010a92b15595f47e...
https://bugzilla.redhat.com/show_bug.cgi?id=1520582
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #7 from Petr Pisar ppisar@redhat.com ---
Fix: Build-require 'perl(utf8)' (t/i18n.t:3).
Ok.
$ rpmlint perl-Mojolicious-Plugin-I18N.spec ../SRPMS/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.src.rpm ../RPMS/noarch/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm perl-Mojolicious-Plugin-I18N.noarch: E: wrong-script-interpreter /usr/share/doc/perl-Mojolicious-Plugin-I18N/script/app_i18n_mail.pl /usr/bin/env perl 2 packages and 1 specfiles checked; 1 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm |sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.1) 1 perl(constant) 1 perl(I18N::LangTags) 1 perl(I18N::LangTags) >= 0.35 1 perl(I18N::LangTags::Detect) 1 perl(Mojo::Base) 1 perl(Mojo::URL) 1 perl(Mojolicious) >= 5 1 perl(Mojolicious::Plugin) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok.
TODO: Filter the less specific 'perl(I18N::LangTags)' dependency without the version. It only pollutes the repository database.
$ resolvedeps rawhide ../RPMS/noarch/perl-Mojolicious-Plugin-I18N-1.6-1.fc28.noarch.rpm Binary dependencies resolvable. Ok.
Package builds in F28 (https://koji.fedoraproject.org/koji/taskinfo?taskID=24076144). Ok.
Please consider fixing the 'TODO' item before building this package. Resolution: Package APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1520582
--- Comment #8 from Robert-André Mauchin zebob.m@gmail.com ---
TODO: Filter the less specific 'perl(I18N::LangTags)' dependency without the version.
I'm not entirely sure how to do that. Using %global __requires_exclude ?
https://bugzilla.redhat.com/show_bug.cgi?id=1520582
--- Comment #9 from Petr Pisar ppisar@redhat.com --- Yes. This could do it:
%global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\(I18N::LangTags\)$
https://bugzilla.redhat.com/show_bug.cgi?id=1520582
--- Comment #10 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Mojolicious-Plugin-I18N. You may commit to the branch "f27" in about 10 minutes.
https://bugzilla.redhat.com/show_bug.cgi?id=1520582
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- perl-Mojolicious-Plugin-I18N-1.6-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-48b68ecee8
https://bugzilla.redhat.com/show_bug.cgi?id=1520582
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1520582
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- perl-Mojolicious-Plugin-I18N-1.6-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8ecf44c366
https://bugzilla.redhat.com/show_bug.cgi?id=1520582
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- perl-Mojolicious-Plugin-I18N-1.6-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8ecf44c366
https://bugzilla.redhat.com/show_bug.cgi?id=1520582
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- perl-Mojolicious-Plugin-I18N-1.6-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-48b68ecee8
https://bugzilla.redhat.com/show_bug.cgi?id=1520582
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2018-01-24 04:57:50
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- perl-Mojolicious-Plugin-I18N-1.6-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1520582
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- perl-Mojolicious-Plugin-I18N-1.6-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com