[Bug 1082332] New: Review Request: nodejs-tiny-lr-fork - A tiny LiveReload server implementation you can spawn in the background - package-review

List overview All Threads
Download

newer

[Bug 1082332] New: Review Request: nodejs-tiny-lr-fork - A tiny LiveReload server implementation you can spawn in the background

older

[Bug 1082336] New: Review Request:...

[Bug 1082329] New: Review Request:...

Red Hat Bugzilla

30 Mar 2014 30 Mar '14

2:47 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1082332

Bug ID: 1082332 Summary: Review Request: nodejs-tiny-lr-fork - A tiny LiveReload server implementation you can spawn in the background Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jamielinux@fedoraproject.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: http://jamielinux.fedorapeople.org/gruntjs/nodejs-tiny-lr-fork.spec SRPM URL: http://jamielinux.fedorapeople.org/gruntjs/SRPMS/nodejs-tiny-lr-fork-0.0.5-1... Fedora Account System Username: jamielinux

Description: A tiny LiveReload server implementation you can spawn in the background.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by thread

Red Hat Bugzilla

30 Mar 30 Mar

2:55 p.m.

New subject: [Bug 1082332] Review Request: nodejs-tiny-lr-fork - A tiny LiveReload server implementation you can spawn in the background

https://bugzilla.redhat.com/show_bug.cgi?id=1082332

--- Comment #1 from Jamie Nguyen jamielinux@fedoraproject.org --- Spec URL: http://jamielinux.fedorapeople.org/gruntjs/nodejs-tiny-lr-fork.spec SRPM URL: http://jamielinux.fedorapeople.org/gruntjs/SRPMS/nodejs-tiny-lr-fork-0.0.5-2...

* Sun Mar 30 2014 Jamie Nguyen jamielinux@fedoraproject.org - 0.0.5-2 - symlink to _bindir

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2:56 p.m.

New subject: [Bug 1082332] Review Request: nodejs-tiny-lr-fork - A tiny LiveReload server implementation you can spawn in the background

https://bugzilla.redhat.com/show_bug.cgi?id=1082332

Jamie Nguyen jamielinux@fedoraproject.org changed:

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1082329 [Bug 1082329] Review Request: nodejs-faye-websocket - A standards-compliant WebSocket server and client for Node.js https://bugzilla.redhat.com/show_bug.cgi?id=1082330 [Bug 1082330] Review Request: nodejs-noptify - A wrapper for the nopt module with a commander-like API

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2:57 p.m.

New subject: [Bug 1082332] Review Request: nodejs-tiny-lr-fork - A tiny LiveReload server implementation you can spawn in the background

https://bugzilla.redhat.com/show_bug.cgi?id=1082332

Jamie Nguyen jamielinux@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1082334

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1082334 [Bug 1082334] Review Request: nodejs-grunt-contrib-watch - Run predefined tasks whenever watched file patterns are added/changed/deleted

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

31 Mar 31 Mar

5:28 a.m.

New subject: [Bug 1082332] Review Request: nodejs-tiny-lr-fork - A tiny LiveReload server implementation you can spawn in the background

https://bugzilla.redhat.com/show_bug.cgi?id=1082332

T.C. Hollingsworth tchollingsworth@gmail.com changed:

--- Comment #2 from T.C. Hollingsworth tchollingsworth@gmail.com --- Looking at the names in %{_bindir} I'd guess this will conflict with the original tiny-lr. But that upstream seems really dead, so I'm happy to ship this.

I'd suggest contacting upstream and let them know they can steal the real tiny-lr name if that upstream is really dead, following the advice in 'npm help disputes': https://www.npmjs.org/doc/misc/npm-disputes.html

The note about the tests kinda freaks me out a little, are we too old or they?

Nothing blocking here though, so APPROVED.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:51 p.m.

New subject: [Bug 1082332] Review Request: nodejs-tiny-lr-fork - A tiny LiveReload server implementation you can spawn in the background

https://bugzilla.redhat.com/show_bug.cgi?id=1082332

--- Comment #3 from Jamie Nguyen jamielinux@fedoraproject.org --- (In reply to T.C. Hollingsworth from comment #2)

...

Looking at the names in %{_bindir} I'd guess this will conflict with the original tiny-lr. But that upstream seems really dead, so I'm happy to ship this.

I'd suggest contacting upstream and let them know they can steal the real tiny-lr name if that upstream is really dead, following the advice in 'npm help disputes': https://www.npmjs.org/doc/misc/npm-disputes.html

There is a comment here from tiny-lr-fork maintainer: https://github.com/gruntjs/grunt-contrib-watch/pull/296#issuecomment-3604333...

...

I appreciate the intent but I don't consider tiny-lr "abandoned" unless @mklabs has stated he has abandoned it. I believe he is just on hiatus and hopefully will return (as he is a great developer I really appreciate his work).

...

The note about the tests kinda freaks me out a little, are we too old or they?

They are too old. Our express and connect is right up to date! (Well, ok so in the time that it took me to post the updates and get them pushed to stable, there's been a new minor point release of both...)

...

Nothing blocking here though, so APPROVED.

Thanks!

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:52 p.m.

New subject: [Bug 1082332] Review Request: nodejs-tiny-lr-fork - A tiny LiveReload server implementation you can spawn in the background

https://bugzilla.redhat.com/show_bug.cgi?id=1082332

Jamie Nguyen jamielinux@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #4 from Jamie Nguyen jamielinux@fedoraproject.org --- New Package SCM Request ======================= Package Name: nodejs-tiny-lr-fork Short Description: A tiny LiveReload server implementation you can spawn in the background Owners: jamielinux patches Branches: f19 f20 el6 InitialCC:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:41 p.m.

New subject: [Bug 1082332] Review Request: nodejs-tiny-lr-fork - A tiny LiveReload server implementation you can spawn in the background

https://bugzilla.redhat.com/show_bug.cgi?id=1082332

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:41 p.m.

New subject: [Bug 1082332] Review Request: nodejs-tiny-lr-fork - A tiny LiveReload server implementation you can spawn in the background

https://bugzilla.redhat.com/show_bug.cgi?id=1082332

--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:33 p.m.

New subject: [Bug 1082332] Review Request: nodejs-tiny-lr-fork - A tiny LiveReload server implementation you can spawn in the background

https://bugzilla.redhat.com/show_bug.cgi?id=1082332

Jamie Nguyen jamielinux@fedoraproject.org changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:33 p.m.

New subject: [Bug 1082332] Review Request: nodejs-tiny-lr-fork - A tiny LiveReload server implementation you can spawn in the background

https://bugzilla.redhat.com/show_bug.cgi?id=1082332 Bug 1082332 depends on bug 1082330, which changed state.

Bug 1082330 Summary: Review Request: nodejs-noptify - A wrapper for the nopt module with a commander-like API https://bugzilla.redhat.com/show_bug.cgi?id=1082330

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

1 Apr 1 Apr

9:42 p.m.

New subject: [Bug 1082332] Review Request: nodejs-tiny-lr-fork - A tiny LiveReload server implementation you can spawn in the background

https://bugzilla.redhat.com/show_bug.cgi?id=1082332 Bug 1082332 depends on bug 1082329, which changed state.

Bug 1082329 Summary: Review Request: nodejs-faye-websocket - A standards-compliant WebSocket server and client for Node.js https://bugzilla.redhat.com/show_bug.cgi?id=1082329

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

4130

Age (days ago)

4132

Last active (days ago)

package-review@lists.fedoraproject.org

11 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla