[Bug 488105] New: Review Request: rubygem-htmlentities - A module for encoding and decoding (X)HTML entities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-htmlentities - A module for encoding and decoding (X)HTML
entities

https://bugzilla.redhat.com/show_bug.cgi?id=488105

           Summary: Review Request: rubygem-htmlentities - A module for
                    encoding and decoding (X)HTML entities
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: nobody(a)fedoraproject.org
        ReportedBy: mtasaka(a)ioa.s.u-tokyo.ac.jp
         QAContact: extras-qa(a)fedoraproject.org
                CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
   Estimated Hours: 0.0
    Classification: Fedora


Spec URL:
http://mtasaka.fedorapeople.org/Review_request/rubygem-htmlentities/rubyg...
SRPM URL:
http://mtasaka.fedorapeople.org/Review_request/rubygem-htmlentities/rubyg...
koji scratch build:
- for dist-f11: http://koji.fedoraproject.org/koji/taskinfo?taskID=1213998
- for dist-f10: http://koji.fedoraproject.org/koji/taskinfo?taskID=1213999
Description: 
HTMLEntities is a simple library to facilitate encoding and 
decoding of named (ý and so on) or numerical ({ or Ī) 
entities in HTML and XHTML documents.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 488105] Review Request: rubygem-htmlentities - A module for encoding and decoding (X)HTML entities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488105


Orcan 'oget' Ogetbil <oget.fedora(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |oget.fedora(a)gmail.com
         AssignedTo|nobody(a)fedoraproject.org    |oget.fedora(a)gmail.com
               Flag|                            |fedora-review+




--- Comment #1 from Orcan 'oget' Ogetbil <oget.fedora(a)gmail.com&gt;  2009-03-03
19:57:24 EDT ---
This is a very simple ruby package. I went through it and didn't find any
problems. But I have a few questions and two little suggestions:

? The other rubygem packages have BR: ruby(rubygems). This one has BR:
rubygems. Why is there a difference? Does it matter? Also BR: ruby(abi) =
%{rubyabi} will be pulled up by BR: rubygems. Do we really need to specify it
specifically? I know the guidelines tell us to do so. But I don't know why.

! The ruby guidelines tell us to use %global instead of %define. While it
doesn't matter much in this case, it would be good to obey the guidelines.

! It would look nicer and consistent if you make the description span evenly
and use the full 80 columns.


Otherwise, the package is good to go:

-------------------------------------------------------
This package (rubygem-htmlentities) is APPROVED by oget
-------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 488105] Review Request: rubygem-htmlentities - A module for encoding and decoding (X)HTML entities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488105


Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?




--- Comment #2 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt;  2009-03-04 05:07:31
EDT ---
Thank you for a quick review!
(In reply to comment #1)

>  ? The other rubygem packages have BR: ruby(rubygems). This one has
> BR:
>  rubygems. Why is there a difference? Does it matter?  
- No deference, however I
prefer to use ruby(rubygems) so I will
  switch to ruby(rubugems)

>  Also BR: ruby(abi) =
>  %{rubyabi} will be pulled up by BR: rubygems. Do we really need to specify it
>  specifically? I know the guidelines tell us to do so. 
- I usually add this abi
dependency for BR explicitly to make it
  consistent with Requires of ruby abi dependency.

>  ! The ruby guidelines tell us to use %global instead of %define.
> While it
>  doesn't matter much in this case, it would be good to obey the guidelines. 
-
Will change.

-----------------------------------------------------
New Package CVS Request
=======================
Package Name:          rubygem-htmlentities
Short Description:     A module for encoding and decoding (X)HTML entities
Owners:                mtasaka
Branches:              F-10 F-9 
InitialCC:             (nobody)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 488105] Review Request: rubygem-htmlentities - A module for encoding and decoding (X)HTML entities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488105


Kevin Fenzi <kevin(a)tummy.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+




--- Comment #3 from Kevin Fenzi <kevin(a)tummy.com&gt;  2009-03-05 15:26:47 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 488105] Review Request: rubygem-htmlentities - A module for encoding and decoding (X)HTML entities

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488105


Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE




--- Comment #4 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp&gt;  2009-03-06 02:27:44
EDT ---
Rebuilt on all branches, submitted push requests for F-10/9, closing.
Thank you for your review and CVS procedure.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.