[Bug 2318618] New: Review Request: golang-github-xtgo-set - General, type-safe, non-allocating set-operations

https://bugzilla.redhat.com/show_bug.cgi?id=2318618

Bug ID: 2318618
           Summary: Review Request: golang-github-xtgo-set - General,
                    type-safe, non-allocating set-operations
           Product: Fedora
           Version: rawhide
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://trix.fedorapeople.org/golang-github-xtgo-set.spec
SRPM URL:
https://trix.fedorapeople.org/golang-github-xtgo-set-1.0.0-1.fc42.src.rpm

Needed for ollama

Reproducible: Always

[Bug 2318618] Review Request: golang-github-xtgo-set - General, type-safe, non-allocating set-operations

https://bugzilla.redhat.com/show_bug.cgi?id=2318618

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2318425
           Doc Type|---                         |If docs needed, set a value

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2318425
[Bug 2318425] Review Request: golang-github-ollama-ollama - Get up and running
with Llama 3.2, Mistral, Gemma 2, and other large language models

[Bug 2318618] Review Request: golang-github-xtgo-set - General, type-safe, non-allocating set-operations

https://bugzilla.redhat.com/show_bug.cgi?id=2318618

Mikel Olasagasti Uranga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED

--- Comment #1 from Mikel Olasagasti Uranga  ---
As with https://bugzilla.redhat.com/show_bug.cgi?id=2318604 can you keep the
bootstrapping logic in the spec?

[Bug 2318618] Review Request: golang-github-xtgo-set - General, type-safe, non-allocating set-operations

https://bugzilla.redhat.com/show_bug.cgi?id=2318618

Petr Pisar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?

[Bug 2318618] Review Request: golang-github-xtgo-set - General, type-safe, non-allocating set-operations

https://bugzilla.redhat.com/show_bug.cgi?id=2318618

Mikel Olasagasti Uranga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #2 from Mikel Olasagasti Uranga  ---
Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

- [x] The latest version is packaged or packaging an earlier version is
justified.
- [x] The License tag reflects the package contents and uses the correct
identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the
distribution. (Some Go projects include utility binaries with very generic
names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these
by default)
- [x] The package does not use `%gometa -f` if it has dependents that still
build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the
Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

[Bug 2318618] Review Request: golang-github-xtgo-set - General, type-safe, non-allocating set-operations

https://bugzilla.redhat.com/show_bug.cgi?id=2318618

Fedora Admin user for bugzilla script actions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RELEASE_PENDING

--- Comment #3 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-xtgo-set

[Bug 2318618] Review Request: golang-github-xtgo-set - General, type-safe, non-allocating set-operations

https://bugzilla.redhat.com/show_bug.cgi?id=2318618

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |CURRENTRELEASE
             Status|RELEASE_PENDING             |CLOSED
        Last Closed|                            |2024-11-05 13:57:54