[Bug 1980003] New: Review Request: jdupes - Duplicate file finder and an enhanced fork of 'fdupes'
https://bugzilla.redhat.com/show_bug.cgi?id=1980003
Bug ID: 1980003 Summary: Review Request: jdupes - Duplicate file finder and an enhanced fork of 'fdupes' Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: dcantrell@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcantrell.fedorapeople.org/jdupes.spec SRPM URL: https://dcantrell.fedorapeople.org/jdupes-1.20.0-1.fc34.src.rpm
Description: jdupes is a program for identifying and taking actions upon duplicate files.
A WORD OF WARNING: jdupes IS NOT a drop-in compatible replacement for fdupes! Do not blindly replace fdupes with jdupes in scripts and expect everything to work the same way. Option availability and meanings differ between the two programs. For example, the -I switch in jdupes means "isolate" and blocks intra-argument matching, while in fdupes it means "immediately delete files during scanning without prompting the user."
Fedora Account System Username: dcantrell
https://bugzilla.redhat.com/show_bug.cgi?id=1980003
Brian Lane bcl@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |bcl@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1980003
Brian Lane bcl@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Brian Lane bcl@redhat.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Expat License", "Unknown or generated", "Expat License", "GNU General Public License, Version 2", "*No copyright* Public domain", "BSD 2-clause "Simplified" License". 127 files have unknown license. Detailed output of licensecheck in /home/bcl/tmp/jdupes/1980003-jdupes/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: jdupes-1.20.0-1.fc35.x86_64.rpm jdupes-debuginfo-1.20.0-1.fc35.x86_64.rpm jdupes-debugsource-1.20.0-1.fc35.x86_64.rpm jdupes-1.20.0-1.fc35.src.rpm jdupes.x86_64: W: spelling-error Summary(en_US) fdupes -> dupes, f dupes, drupes jdupes.x86_64: W: spelling-error %description -l en_US fdupes -> dupes, f dupes, drupes jdupes.x86_64: W: spelling-error %description -l en_US intra -> intro, infra, intranet jdupes.x86_64: W: install-file-in-docs /usr/share/doc/jdupes/INSTALL jdupes.src: W: spelling-error Summary(en_US) fdupes -> dupes, f dupes, drupes jdupes.src: W: spelling-error %description -l en_US fdupes -> dupes, f dupes, drupes jdupes.src: W: spelling-error %description -l en_US intra -> intro, infra, intranet 4 packages and 0 specfiles checked; 0 errors, 7 warnings.
Rpmlint (debuginfo) ------------------- Checking: jdupes-debuginfo-1.20.0-1.fc35.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Source checksums ---------------- https://github.com/jbruchon/jdupes/archive/v1.20.0/jdupes-1.20.0.tar.gz : CHECKSUM(SHA256) this package : c1f728961ad8aeb074e5767367639e6b418f0ca572f70f7635655da722f1827e CHECKSUM(SHA256) upstream package : c1f728961ad8aeb074e5767367639e6b418f0ca572f70f7635655da722f1827e
Requires -------- jdupes (rpmlib, GLIBC filtered): glibc libc.so.6()(64bit) rtld(GNU_HASH)
jdupes-debuginfo (rpmlib, GLIBC filtered):
jdupes-debugsource (rpmlib, GLIBC filtered):
Provides -------- jdupes: jdupes jdupes(x86-64)
jdupes-debuginfo: debuginfo(build-id) jdupes-debuginfo jdupes-debuginfo(x86-64)
jdupes-debugsource: jdupes-debugsource jdupes-debugsource(x86-64)
Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1980003 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Perl, SugarActivity, Haskell, R, Python, Ocaml, Java, fonts, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=1980003
--- Comment #2 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/jdupes
https://bugzilla.redhat.com/show_bug.cgi?id=1980003
David Cantrell dcantrell@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2021-07-07 19:36:03
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com