[Bug 2275006] New: Review Request: ansible-collection-community-library_inventory_filtering_v1 - Library collection with helpers for inventory plugins
https://bugzilla.redhat.com/show_bug.cgi?id=2275006
Bug ID: 2275006 Summary: Review Request: ansible-collection-community-library_inventory_filteri ng_v1 - Library collection with helpers for inventory plugins Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: maxwell@gtmx.me QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://gotmax23.fedorapeople.org/reviews/ansible-collection-community-libra... SRPM URL: https://gotmax23.fedorapeople.org/reviews/ansible-collection-community-libra...
Description: The community.library_inventory_filtering_v1 collection includes helpers for use with other collections that allow inventory plugins to offer common filtering functionality.
https://bugzilla.redhat.com/show_bug.cgi?id=2275006
Maxwell G maxwell@gtmx.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Depends On| |2263696 Blocks| |2242856
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2242856 [Bug 2242856] ansible-collection-community-docker-3.8.1 is available https://bugzilla.redhat.com/show_bug.cgi?id=2263696 [Bug 2263696] Review Request: ansible-collection-community-internal_test_tools - Internal test tools for other collections
https://bugzilla.redhat.com/show_bug.cgi?id=2275006 Bug 2275006 depends on bug 2263696, which changed state.
Bug 2263696 Summary: Review Request: ansible-collection-community-internal_test_tools - Internal test tools for other collections https://bugzilla.redhat.com/show_bug.cgi?id=2263696
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2275006
--- Comment #1 from Maxwell G maxwell@gtmx.me --- Spec URL: https://gotmax23.fedorapeople.org/reviews/ansible-collection-community-libra... SRPM URL: https://gotmax23.fedorapeople.org/reviews/ansible-collection-community-libra...
Update to latest version and upstream patch
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=123703396
https://bugzilla.redhat.com/show_bug.cgi?id=2275006
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8044452 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- License file CHANGELOG.md.license is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2275006
--- Comment #3 from Maxwell G maxwell@gtmx.me --- Spec URL: https://gotmax23.fedorapeople.org/reviews/ansible-collection-community-libra... SRPM URL: https://gotmax23.fedorapeople.org/reviews/ansible-collection-community-libra...
Include all CHANGELOG files in package
https://bugzilla.redhat.com/show_bug.cgi?id=2275006
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2047918 --> https://bugzilla.redhat.com/attachment.cgi?id=2047918&action=edit The .spec file difference from Copr build 8044452 to 8044909
https://bugzilla.redhat.com/show_bug.cgi?id=2275006
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8044909 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2275006
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |code@musicinmybrain.net Flags| |fedora-review? | |needinfo?(code@musicinmybra | |in.net) Status|NEW |ASSIGNED CC| |code@musicinmybrain.net
https://bugzilla.redhat.com/show_bug.cgi?id=2275006
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ |needinfo?(code@musicinmybra | |in.net) | Status|ASSIGNED |POST
--- Comment #6 from Ben Beasley code@musicinmybrain.net --- No issues were found in the general package review below. Furthermore, the package appears to comply with the specific guidelines for Ansible Collections in https://docs.fedoraproject.org/en-US/packaging-guidelines/Ansible_collection....
The package is therefore APPROVED.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 3". 8 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2275006-ansible-collection-community- library_inventory_filtering_v1/licensecheck.txt [-]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/ansible/collections/ansible_collections/community(ansible- collection-community-libvirt, ansible-collection-community-general, ansible-collection-community-crypto, ansible-collection-community- kubernetes, ansible-collection-community-rabbitmq, ansible-collection- community-internal_test_tools, ansible-collection-community-mysql, ansible-collection-community-postgresql, ansible-collection-community- docker)
This directory is appropriately co-owned with other ansible- collection-community-* packages.
[x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment).
Hidden .reuse files are appropriate; so are duplicate .license files.
[x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 7349 bytes in 3 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described.
(tests pass)
[x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
Patch is noted as not upstreamable and is consistent with
https://docs.fedoraproject.org/en-US/packaging-guidelines/Ansible_collection....
[-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures.
https://koji.fedoraproject.org/koji/taskinfo?taskID=123757559
[x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: ansible-collection-community-library_inventory_filtering_v1-1.0.1-1.fc42.noarch.rpm
ansible-collection-community-library_inventory_filtering_v1-1.0.1-1.fc42.src.rpm =========================================================================================== rpmlint session starts =========================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmppbe9g4ap')] checks: 32, packages: 2
ansible-collection-community-library_inventory_filtering_v1.noarch: W: hidden-file-or-dir /usr/share/licenses/ansible-collection-community-library_inventory_filtering_v1/.reuse ansible-collection-community-library_inventory_filtering_v1.noarch: W: hidden-file-or-dir /usr/share/licenses/ansible-collection-community-library_inventory_filtering_v1/.reuse ansible-collection-community-library_inventory_filtering_v1.noarch: W: files-duplicate /usr/share/licenses/ansible-collection-community-library_inventory_filtering_v1/no-unwanted-files.json.license /usr/share/licenses/ansible-collection-community-library_inventory_filtering_v1/CHANGELOG.md.license:/usr/share/licenses/ansible-collection-community-library_inventory_filtering_v1/CHANGELOG.rst.license:/usr/share/licenses/ansible-collection-community-library_inventory_filtering_v1/changelog.yaml.license:/usr/share/licenses/ansible-collection-community-library_inventory_filtering_v1/extra-docs.json.license:/usr/share/licenses/ansible-collection-community-library_inventory_filtering_v1/licenses.json.license ====================================================== 2 packages and 0 specfiles checked; 0 errors, 3 warnings, 7 filtered, 0 badness; has taken 0.2 s ======================================================
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
ansible-collection-community-library_inventory_filtering_v1.noarch: W: hidden-file-or-dir /usr/share/licenses/ansible-collection-community-library_inventory_filtering_v1/.reuse ansible-collection-community-library_inventory_filtering_v1.noarch: W: hidden-file-or-dir /usr/share/licenses/ansible-collection-community-library_inventory_filtering_v1/.reuse ansible-collection-community-library_inventory_filtering_v1.noarch: W: files-duplicate /usr/share/licenses/ansible-collection-community-library_inventory_filtering_v1/no-unwanted-files.json.license /usr/share/licenses/ansible-collection-community-library_inventory_filtering_v1/CHANGELOG.md.license:/usr/share/licenses/ansible-collection-community-library_inventory_filtering_v1/CHANGELOG.rst.license:/usr/share/licenses/ansible-collection-community-library_inventory_filtering_v1/changelog.yaml.license:/usr/share/licenses/ansible-collection-community-library_inventory_filtering_v1/extra-docs.json.license:/usr/share/licenses/ansible-collection-community-library_inventory_filtering_v1/licenses.json.license 1 packages and 0 specfiles checked; 0 errors, 3 warnings, 3 filtered, 0 badness; has taken 0.1 s
Source checksums ---------------- https://github.com/ansible-collections/community.library_inventory_filtering... : CHECKSUM(SHA256) this package : 194a42f2e14a542c95b37ac95979d0623a6345e6d39209f2980036a4d733258f CHECKSUM(SHA256) upstream package : 194a42f2e14a542c95b37ac95979d0623a6345e6d39209f2980036a4d733258f
Requires -------- ansible-collection-community-library_inventory_filtering_v1 (rpmlib, GLIBC filtered): (ansible-core or (ansible < 2.10.0 with ansible >= 2.9.10))
Provides -------- ansible-collection-community-library_inventory_filtering_v1: ansible-collection(community.library_inventory_filtering_v1) ansible-collection-community-library_inventory_filtering_v1
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2275006 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: PHP, Python, SugarActivity, Perl, Ocaml, Java, C/C++, Haskell, R, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
https://bugzilla.redhat.com/show_bug.cgi?id=2275006
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #7 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/ansible-collection-community-library_inve...
https://bugzilla.redhat.com/show_bug.cgi?id=2275006
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-29502208c6 (ansible-collection-community-docker-3.12.2-1.fc42 and ansible-collection-community-library_inventory_filtering_v1-1.0.1-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-29502208c6
https://bugzilla.redhat.com/show_bug.cgi?id=2275006
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2024-09-27 21:11:38
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-29502208c6 (ansible-collection-community-docker-3.12.2-1.fc42 and ansible-collection-community-library_inventory_filtering_v1-1.0.1-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com