Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: logkeys - Linux keylogger
https://bugzilla.redhat.com/show_bug.cgi?id=799701
Summary: Review Request: logkeys - Linux keylogger Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: sanjay.ankur@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://ankursinha.fedorapeople.org/logkeys/logkeys.spec SRPM URL: http://ankursinha.fedorapeople.org/logkeys/logkeys-0.1.1a-1.fc16.src.rpm
Description: logkeys is a linux keylogger (GNU/Linux systems only). It is no more advanced than other available linux keyloggers, but is a bit more up to date, it doesn't unreliably repeat keys and it should never crash your X. All in all, it just seems to work. It relies on event interface of the Linux input subsystem. Once set, it logs all common character and function keys, while also being fully aware of Shift and AltGr key modifiers. It works with serial as well as USB keyboards.
== rpmlint output == [ankur@ankur result]$ rpmlint *.rpm ~/rpmbuild/SPECS/logkeys.spec logkeys.src: W: spelling-error Summary(en_US) keylogger -> key logger, key-logger, flogger logkeys.src: W: spelling-error %description -l en_US linux -> Linux logkeys.src: W: spelling-error %description -l en_US keylogger -> key logger, key-logger, flogger logkeys.src: W: spelling-error %description -l en_US keyloggers -> key loggers, key-loggers, loggers logkeys.src: W: strange-permission logkeys-0.1.1a.tar.gz 0640L logkeys.src: W: invalid-url Source0: http://logkeys.googlecode.com/files/logkeys-0.1.1a.tar.gz HTTP Error 404: Not Found logkeys.x86_64: W: spelling-error Summary(en_US) keylogger -> key logger, key-logger, flogger logkeys.x86_64: W: spelling-error %description -l en_US linux -> Linux logkeys.x86_64: W: spelling-error %description -l en_US keylogger -> key logger, key-logger, flogger logkeys.x86_64: W: spelling-error %description -l en_US keyloggers -> key loggers, key-loggers, loggers logkeys.x86_64: W: manual-page-warning /usr/share/man/man8/logkeys.8.gz 216: warning: macro `..' not defined logkeys.x86_64: W: no-manual-page-for-binary llk logkeys.x86_64: W: no-manual-page-for-binary llkk /home/ankur/rpmbuild/SPECS/logkeys.spec: W: invalid-url Source0: http://logkeys.googlecode.com/files/logkeys-0.1.1a.tar.gz HTTP Error 404: Not Found 3 packages and 1 specfiles checked; 0 errors, 14 warnings. [ankur@ankur result]$
Nothing really serious here.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=799701
--- Comment #1 from Ankur Sinha sanjay.ankur@gmail.com 2012-03-04 08:02:06 EST --- Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3850441
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=799701
Brendan Jones brendan.jones.it@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan.jones.it@gmail.com AssignedTo|nobody@fedoraproject.org |brendan.jones.it@gmail.com Flag| |fedora-review?
--- Comment #2 from Brendan Jones brendan.jones.it@gmail.com 2012-03-06 08:01:34 EST --- I will take this review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=799701
--- Comment #3 from Brendan Jones brendan.jones.it@gmail.com 2012-03-06 09:09:47 EST --- (In reply to comment #0)
logkeys.src: W: strange-permission logkeys-0.1.1a.tar.gz 0640L
You can correct these permissions
logkeys.x86_64: W: manual-page-warning /usr/share/man/man8/logkeys.8.gz 216:
You can notify upstream about this
warning: macro `..' not defined
You could try this in your prep section perl -i -p -e 's/^...\n/\n/' man/logkeys.8 and notify upstream
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=799701
François Cami fdc@fcami.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fdc@fcami.net Flags| |needinfo?(sanjay.ankur@gmai | |l.com)
--- Comment #4 from François Cami fdc@fcami.net --- FranciscoD, could you please update your SPEC according to Brendan's comments? Otherwise we might consider this as stalled.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=799701
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(sanjay.ankur@gmai | |l.com) |
--- Comment #5 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Hi Brendan, Francois,
I seem to have somehow missed this bug. I'll update it over the weekend. Thanks for the ping.
Thanks, Warm regards, Ankur
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=799701
--- Comment #6 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Hi,
* Corrected the man page error * Permissions seem okay
New spec/srpm:
http://ankursinha.fedorapeople.org/logkeys/logkeys.spec
http://ankursinha.fedorapeople.org/logkeys/logkeys-0.1.1a-2.fc19.src.rpm
Thanks, Warm regards, Ankur
https://bugzilla.redhat.com/show_bug.cgi?id=799701
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |cickumqt@gmail.com Assignee|brendan.jones.it@gmail.com |cickumqt@gmail.com
--- Comment #7 from Christopher Meng cickumqt@gmail.com --- I'll take this(but later review coming)
https://bugzilla.redhat.com/show_bug.cgi?id=799701
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|cickumqt@gmail.com |brendan.jones.it@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=799701
--- Comment #8 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- (In reply to Christopher Meng from comment #7)
I'll take this(but later review coming)
Uhm,
Christopher, can I request you to please communicate with the folks in the bug before you take over or give up the review? For instance, here there's no comment asking Brendan if he wanted to give up the bug so you can take over, and there isn't one asking if he wants to take it over now when you're giving it up. :/
Thanks, Ankur
https://bugzilla.redhat.com/show_bug.cgi?id=799701
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@gmail.com
--- Comment #9 from Christopher Meng cickumqt@gmail.com --- (In reply to Ankur Sinha (FranciscoD) from comment #8)
(In reply to Christopher Meng from comment #7)
I'll take this(but later review coming)
Uhm,
Christopher, can I request you to please communicate with the folks in the bug before you take over or give up the review? For instance, here there's no comment asking Brendan if he wanted to give up the bug so you can take over, and there isn't one asking if he wants to take it over now when you're giving it up. :/
Thanks, Ankur
I think I've reseted the flag to him in July.
I just removed myself from this bug as I can't see any new progress here.
Thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=799701
--- Comment #10 from Brendan Jones brendan.jones.it@gmail.com --- Sorry I missed that it had changed back to me. Comment would be good next time.
Is this still wanted? Need to change the permissions of the source tarbal and address the missing call to cgroups rpmlint. Source URL is fine
logkeys.x86_64: W: spelling-error Summary(en_US) keylogger -> key logger, key-logger, flogger logkeys.x86_64: W: spelling-error %description -l en_US linux -> Linux logkeys.x86_64: W: spelling-error %description -l en_US keylogger -> key logger, key-logger, flogger logkeys.x86_64: W: spelling-error %description -l en_US keyloggers -> key loggers, key-loggers, loggers logkeys.x86_64: E: missing-call-to-setgroups /usr/bin/logkeys logkeys.x86_64: W: no-manual-page-for-binary llk logkeys.x86_64: W: no-manual-page-for-binary llkk logkeys.src: W: spelling-error Summary(en_US) keylogger -> key logger, key-logger, flogger logkeys.src: W: spelling-error %description -l en_US linux -> Linux logkeys.src: W: spelling-error %description -l en_US keylogger -> key logger, key-logger, flogger logkeys.src: W: spelling-error %description -l en_US keyloggers -> key loggers, key-loggers, loggers logkeys.src: W: strange-permission logkeys-0.1.1a.tar.gz 0640L logkeys.src: W: invalid-url Source0: http://logkeys.googlecode.com/files/logkeys-0.1.1a.tar.gz HTTP Error 404: Not Found 2 packages and 0 specfiles checked; 1 errors, 12 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=799701
--- Comment #11 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- pbrobinson's scratch build of linux-user-chroot?#b7afe5173cbd31b029b027b6f8a14baa5e6ce87a for epel7-archbootstrap and git://pkgs.fedoraproject.org/linux-user-chroot?#b7afe5173cbd31b029b027b6f8a14baa5e6ce87a failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12089939
https://bugzilla.redhat.com/show_bug.cgi?id=799701
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |WONTFIX Last Closed| |2017-12-17 09:37:18
--- Comment #12 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Dropping this - I haven't used logkeys in a long time, and I don't reckon I'll use it in the future either.
Thanks for the comments.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com -
Red Hat Bugzilla