[Bug 1367976] New: Review Request: rubygem-contracts - Contracts for Ruby

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367976

Bug ID: 1367976
           Summary: Review Request: rubygem-contracts - Contracts for Ruby
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-contract...
SRPM URL:
https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-contract...
Description: 
This library provides contracts for Ruby. Contracts let you clearly express
how your code behaves, and free you from writing tons of boilerplate,
defensive code.
Fedora Account System Username: mtasaka

scratch build
For F-26: http://koji.fedoraproject.org/koji/taskinfo?taskID=15291487

[Bug 1367976] Review Request: rubygem-contracts - Contracts for Ruby

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367976

Mamoru TASAKA  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1365872

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1365872
[Bug 1365872] rubygem-aruba 0.14.1 is available

[Bug 1367976] Review Request: rubygem-contracts - Contracts for Ruby

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367976

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #1 from Vít Ondruch  ---
I'll take this for a review.

[Bug 1367976] Review Request: rubygem-contracts - Contracts for Ruby

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367976

--- Comment #2 from Vít Ondruch  ---
Generally, the package looks ok => I APPROVE the package.

Nevertheless, there are few nits I'd like to clarify:

* Integration test suite
  - Have you tried to execute the integration test suite?

* Keeping the integration test suite around
  - You remove quite a lot of stuff from the package, including the test suite.
    Nevertheless, you keep around the test suite (features folder). I am
    wondering what is the reason for this?

[Bug 1367976] Review Request: rubygem-contracts - Contracts for Ruby

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367976

--- Comment #3 from Mamoru TASAKA  ---
Thank you for initial comments!

* Integration test suite
  - Well, there is "rspec spec/" in spec file, do you mean other
    test suite here?

* > you keep around the test suite (features folder)
  - Well, I think "features" directory explains the "feature" of this
    gem, i.e. quite similar with "examples".
    For example, "features/basics/simple_example.feature" explains the
    basic usage of this gem.

[Bug 1367976] Review Request: rubygem-contracts - Contracts for Ruby

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367976

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #4 from Vít Ondruch  ---
(In reply to Mamoru TASAKA from comment #3)
> Thank you for initial comments!

I said I approve the package but forgot to set review+, sorry ...
> Integration test suite
> Well, there is "rspec spec/" in spec file, do you mean other
> test suite here?
> > you keep around the test suite (features folder)
> Well, I think "features" directory explains the "feature" of this
> gem, i.e. quite similar with "examples".
> For example, "features/basics/simple_example.feature" explains the
> basic usage of this gem.

Actually, these two bullets are more or less one bullet then, since the
features directory contains the test suite in question if I am not mistaken.
That should be executable using Cucumber. In theory, calling "cucumber" command
should be enough to execute it.

[Bug 1367976] Review Request: rubygem-contracts - Contracts for Ruby

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367976

--- Comment #5 from Mamoru TASAKA  ---
Okay, thank you. I will look at features/ directory later. And thank you for
approving!

[Bug 1367976] Review Request: rubygem-contracts - Contracts for Ruby

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367976

--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-contracts

[Bug 1367976] Review Request: rubygem-contracts - Contracts for Ruby

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367976

Mamoru TASAKA  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |NEXTRELEASE
        Last Closed|                            |2016-09-10 05:19:11

--- Comment #7 from Mamoru TASAKA  ---
Imported into rawhide. thank you!