Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227048
Summary: Review Request: dom2-core-tests-0.0.1-0.20040405.1jpp - DOM Conformance Test Suite Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rafaels@redhat.com QAContact: fedora-package-review@redhat.com
Spec URL: http://people.redhat.com/rafaels/specs/dom2-core-tests-0.0.1-0.20040405.1jpp... SRPM URL: ftp://jpackage.hmdc.harvard.edu/JPackage/1.7/generic/SRPMS.free/dom2-core-tests-0.0.1-0.20040405.1jpp.src.rpm Description: The DOM Test Suites (DOM TS) will consist of a number of tests for each level of the DOM specification. The tests will be represented in an XML grammar which ensures that tests can easily be ported from the description format to a number of specific language bindings. This grammar will be specified in XML Schema and DTD form. The grammar will be automatically generated from the DOM specifications themselves, to ensure stability and correctness.
Javadoc for dom2-core-tests.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dom2-core-tests-0.0.1-0.20040405.1jpp - DOM Conformance Test Suite
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227048
tbento@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |tbento@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dom2-core-tests-0.0.1-0.20040405.1jpp - DOM Conformance Test Suite
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227048
tbento@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|tbento@redhat.com |vivekl@redhat.com Flag| |fedora-review-
------- Additional Comments From tbento@redhat.com 2007-02-12 13:22 EST ------- ============================== RPMLINT OUTPUT FOR SOURCE RPM: ==============================
W: dom2-core-tests non-standard-group Text Processing/Markup/XML W: dom2-core-tests invalid-license W3C Software License W: dom2-core-tests rpm-buildroot-usage %prep rm -rf $RPM_BUILD_ROOT W: dom2-core-tests mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 42) W: dom2-core-tests class-path-in-manifest /dom2-core-tests-20040405.jar
=============================== RPMLINT OUTPUT FOR BINARY RPMS: ===============================
dom2-core-tests-0.0.1-0.20040405.1jpp.noarch.rpm: ------------------------------------------------- W: dom2-core-tests non-standard-group Text Processing/Markup/XML W: dom2-core-tests invalid license W3C Software license W: dom2-core-tests no-documentation
dom2-core-tests-javadoc-00,01-0.20040405-1jpp.noarch.rpm: --------------------------------------------------------- W: dom2-core-tests-javadoc non-standard-group Development/Documentation W: dom2-core-tests-javadoc invalid-license W3C Software License W: dom2-core-tests-javadoc dangerous-command-in-%post rm w: dom2-core-tests-javadoc dangerous-command-in-%postun rm
- Fix %Release tag.
- Remove %Vendor and &Distribution.
- Add "-%(%{__id_u} -n)" to the end of %BuildRoot.
- In the future, when adding gcj support, remove %BuildArch.
- Change the changelog entry format. Ralph's email should read "r.apel@r-apel.de".
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dom2-core-tests-0.0.1-0.20040405.1jpp - DOM Conformance Test Suite
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227048
------- Additional Comments From vivekl@redhat.com 2007-02-13 00:03 EST ------- (In reply to comment #1)
============================== RPMLINT OUTPUT FOR SOURCE RPM: ==============================
W: dom2-core-tests non-standard-group Text Processing/Markup/XML
Ignoring since groups can apparently be arbitrary
W: dom2-core-tests invalid-license W3C Software License
http://www.opensource.org/licenses/W3C.php suggests license is OSI approved Using W3C License in this field
W: dom2-core-tests rpm-buildroot-usage %prep rm -rf $RPM_BUILD_ROOT
Removed
W: dom2-core-tests mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 42)
Fixed
W: dom2-core-tests class-path-in-manifest /dom2-core-tests-20040405.jar
Ignoring since these are mandated by package build process
=============================== RPMLINT OUTPUT FOR BINARY RPMS: ===============================
dom2-core-tests-0.0.1-0.20040405.1jpp.noarch.rpm:
W: dom2-core-tests non-standard-group Text Processing/Markup/XML
Ignoring since groups can apparently be arbitrary
W: dom2-core-tests invalid license W3C Software license
See above
W: dom2-core-tests no-documentation
There doesnt seem to be anything in the build directory to use for doc, can we waive this?
dom2-core-tests-javadoc-00,01-0.20040405-1jpp.noarch.rpm:
W: dom2-core-tests-javadoc non-standard-group Development/Documentation
Ignore as above
W: dom2-core-tests-javadoc invalid-license W3C Software License
Changed to W3C License
W: dom2-core-tests-javadoc dangerous-command-in-%post rm w: dom2-core-tests-javadoc dangerous-command-in-%postun rm
Removed the use of post and postun scripts
- Fix %Release tag.
Fixed
Remove %Vendor and &Distribution.
Add "-%(%{__id_u} -n)" to the end of %BuildRoot.
In the future, when adding gcj support, remove %BuildArch.
Fixed
- Change the changelog entry format. Ralph's email should read
I think the guidelines are more particular about the location of ENVR in the changelog
The SRPM is at: http://tequila-sunrise.ath.cx/rpmreviews/F7/dom2-core-tests/dom2-core-tests-...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dom2-core-tests-0.0.1-0.20040405.1jpp - DOM Conformance Test Suite
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227048
vivekl@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|vivekl@redhat.com |tbento@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dom2-core-tests-0.0.1-0.20040405.1jpp - DOM Conformance Test Suite
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227048
tbento@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|tbento@redhat.com |vivekl@redhat.com
------- Additional Comments From tbento@redhat.com 2007-02-13 17:16 EST ------- (In reply to comment #2)
(In reply to comment #1)
============================== RPMLINT OUTPUT FOR SOURCE RPM: ==============================
W: dom2-core-tests non-standard-group Text Processing/Markup/XML
Ignoring since groups can apparently be arbitrary
W: dom2-core-tests invalid-license W3C Software License
http://www.opensource.org/licenses/W3C.php suggests license is OSI approved Using W3C License in this field
W: dom2-core-tests rpm-buildroot-usage %prep rm -rf $RPM_BUILD_ROOT
Removed
W: dom2-core-tests mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 42)
Fixed
W: dom2-core-tests class-path-in-manifest /dom2-core-tests-20040405.jar
Ignoring since these are mandated by package build process
=============================== RPMLINT OUTPUT FOR BINARY RPMS: ===============================
dom2-core-tests-0.0.1-0.20040405.1jpp.noarch.rpm:
W: dom2-core-tests non-standard-group Text Processing/Markup/XML
Ignoring since groups can apparently be arbitrary
W: dom2-core-tests invalid license W3C Software license
See above
W: dom2-core-tests no-documentation
There doesnt seem to be anything in the build directory to use for doc, can we waive this?
dom2-core-tests-javadoc-00,01-0.20040405-1jpp.noarch.rpm:
W: dom2-core-tests-javadoc non-standard-group Development/Documentation
Ignore as above
W: dom2-core-tests-javadoc invalid-license W3C Software License
Changed to W3C License
W: dom2-core-tests-javadoc dangerous-command-in-%post rm w: dom2-core-tests-javadoc dangerous-command-in-%postun rm
Removed the use of post and postun scripts
- Fix %Release tag.
Fixed
Remove %Vendor and &Distribution.
Add "-%(%{__id_u} -n)" to the end of %BuildRoot.
In the future, when adding gcj support, remove %BuildArch.
Fixed
- Change the changelog entry format. Ralph's email should read
I think the guidelines are more particular about the location of ENVR in the changelog.
Great. I think there may be a minor bug in %changelog because rpmlint now generates the following warning when run on dom2-core-tests-0.0.1-0.1.20040405.1jpp.1.i386.rpm: W: dom2-core-tests incoherent-version-in-changelog 1:0.0.1-0.1.20040405.1jpp.1.fc7 1:0.0.1-0.1.20040405.1jpp.1 Could you have a look at this?
Also, there seem to be a couple of lines with more than 80 characters. I didn't know this was a must, which is why I didn't mention anything previously. Could you also have a look at that?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dom2-core-tests-0.0.1-0.20040405.1jpp - DOM Conformance Test Suite
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227048
------- Additional Comments From vivekl@redhat.com 2007-02-13 18:19 EST ------- (In reply to comment #3)
Great. I think there may be a minor bug in %changelog because rpmlint now generates the following warning when run on dom2-core-tests-0.0.1-0.1.20040405.1jpp.1.i386.rpm: W: dom2-core-tests incoherent-version-in-changelog 1:0.0.1-0.1.20040405.1jpp.1.fc7 1:0.0.1-0.1.20040405.1jpp.1 Could you have a look at this?
I think you might have tried to rebuild the srpm without a rpmbuild --define "%dist .fc7" which is why it complained.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dom2-core-tests-0.0.1-0.20040405.1jpp - DOM Conformance Test Suite
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227048
vivekl@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|vivekl@redhat.com |tbento@redhat.com Flag|fedora-review- |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dom2-core-tests-0.0.1-0.20040405.1jpp - DOM Conformance Test Suite
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227048
overholt@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dom2-core-tests-0.0.1-0.20040405.1jpp - DOM Conformance Test Suite
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227048
tbento@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|tbento@redhat.com |vivekl@redhat.com
------- Additional Comments From tbento@redhat.com 2007-02-15 12:40 EST ------- (In reply to comment #4)
(In reply to comment #3)
Great. I think there may be a minor bug in %changelog because rpmlint now generates the following warning when run on dom2-core-tests-0.0.1-0.1.20040405.1jpp.1.i386.rpm: W: dom2-core-tests incoherent-version-in-changelog 1:0.0.1-0.1.20040405.1jpp.1.fc7 1:0.0.1-0.1.20040405.1jpp.1 Could you have a look at this?
I think you might have tried to rebuild the srpm without a rpmbuild --define "%dist .fc7" which is why it complained.
Sorry about that, you are right. But there is still a warning in one of the binary rpms: W: dom2-core-tests no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files.
Everything else looks a-okay to me.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dom2-core-tests-0.0.1-0.20040405.1jpp - DOM Conformance Test Suite
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227048
------- Additional Comments From vivekl@redhat.com 2007-02-15 16:06 EST ------- (In reply to comment #5)
W: dom2-core-tests no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files.
Everything else looks a-okay to me.
I think this can be ignored. I looked in the build root and there is nothing appropriate to add...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dom2-core-tests-0.0.1-0.20040405.1jpp - DOM Conformance Test Suite
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227048
tbento@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dom2-core-tests-0.0.1-0.20040405.1jpp - DOM Conformance Test Suite
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227048
vivekl@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|vivekl@redhat.com |dbhole@redhat.com
------- Additional Comments From vivekl@redhat.com 2007-03-02 17:59 EST ------- Reassigning to package owner to be built into rawhide.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dom2-core-tests-0.0.1-0.20040405.1jpp - DOM Conformance Test Suite
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227048
dbhole@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From dbhole@redhat.com 2007-03-06 17:31 EST ------- New Package CVS Request ======================= Package Name: dom2-core-tests-0.0.1-0.1.20040405.1jpp.1 Short Description: DOM Conformance Test Suite Owners: dbhole@redhat.com Branches: FC-7
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dom2-core-tests-0.0.1-0.20040405.1jpp - DOM Conformance Test Suite
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227048
dennis@ausil.us changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From dennis@ausil.us 2007-03-07 14:11 EST ------- branched
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dom2-core-tests-0.0.1-0.20040405.1jpp - DOM Conformance Test Suite
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227048
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium
dbhole@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |WONTFIX OtherBugsDependingO|163776 | nThis| |
------- Additional Comments From dbhole@redhat.com 2007-04-25 14:39 EST ------- This package was needed by maven2, but that is no longer the case.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dom2-core-tests-0.0.1-0.20040405.1jpp - DOM Conformance Test Suite
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227048
dbhole@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Keywords| |Reopened Resolution|WONTFIX |
------- Additional Comments From dbhole@redhat.com 2007-04-25 15:26 EST ------- On second thought, I think I will keep this open. Although it is non-critical, it should really be added into Fedora at some point..
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dom2-core-tests-0.0.1-0.20040405.1jpp - DOM Conformance Test Suite
https://bugzilla.redhat.com/show_bug.cgi?id=227048
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora
a.badger@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |a.badger@gmail.com
------- Additional Comments From a.badger@gmail.com 2007-10-13 04:33 EST ------- ping?
This package was approved and a cvs branch was created for it but the source was never checked into the repository or a package built. You can go ahead and do this if you'd like; it's all set up and awaiting your initial checkin.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dom2-core-tests-0.0.1-0.20040405.1jpp - DOM Conformance Test Suite
https://bugzilla.redhat.com/show_bug.cgi?id=227048
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide
dbhole@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |DEFERRED
------- Additional Comments From dbhole@redhat.com 2008-02-28 16:25 EST ------- This package is not required at this time. I see no reason to pull it in and increase maintenance burden. Therefore I am closing this bug.
package-review@lists.fedoraproject.org