[Bug 2076615] New: Review Request: rust-is-terminal - Test whether a given stream is a terminal
https://bugzilla.redhat.com/show_bug.cgi?id=2076615
Bug ID: 2076615 Summary: Review Request: rust-is-terminal - Test whether a given stream is a terminal Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/rust-is-terminal.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-is-terminal-0.1.0-1.fc36.src.rpm
Description: Test whether a given stream is a terminal.
Fedora Account System Username: decathorpe
Note: I need version 0.1.0 of this package as a dependency of rust-wasmtime-cli / rust-wasi-cap-std-sync. Building this package might also require to enable the "local" repo, since some dependencies might not be in mirrored rawhide repositories yet.
https://bugzilla.redhat.com/show_bug.cgi?id=2076615
Carmelo Sarta carmelo.sarta.main@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |carmelo.sarta.main@gmail.co | |m Status|NEW |POST Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |carmelo.sarta.main@gmail.co | |m Flags| |fedora-review+
--- Comment #1 from Carmelo Sarta carmelo.sarta.main@gmail.com --- rust2rpm package, fedora-review is correct:
- The specfile is sane. - License is correct - Builds successfully in mock - No rpmlint errors - %check section passes - The latest version is packaged - The package complies with the Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- Add package to release-monitoring.org - Add package to Koschei. - Give rust-sig privileges on package - Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. (rhbz#BUG_ID)
Let me know if you can open an issue upstream in order to update the dependency of wasi-cap-std-sync for this crate.
https://bugzilla.redhat.com/show_bug.cgi?id=2076615
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Thanks for the review!
Let me know if you can open an issue upstream in order to update the dependency of wasi-cap-std-sync for this crate.
The wasmtime project is a bit difficult to contribute to, because its developed as a giant monorepo with dozens of crates. They usually pretty agressively bump versions of their dependencies, so it will only be a matter of time that they will require a new version of is-terminal as well, I think. I will then update the package for this crate, as required.
https://pagure.io/releng/fedora-scm-requests/issue/44230 https://pagure.io/releng/fedora-scm-requests/issue/44231 https://pagure.io/releng/fedora-scm-requests/issue/44232 https://pagure.io/releng/fedora-scm-requests/issue/44233
https://bugzilla.redhat.com/show_bug.cgi?id=2076615
--- Comment #3 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-is-terminal
https://bugzilla.redhat.com/show_bug.cgi?id=2076615
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2022-05-05 20:11:00
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Built for all current Fedora releases:
https://bodhi.fedoraproject.org/updates/FEDORA-2022-7b0c69b463 https://bodhi.fedoraproject.org/updates/FEDORA-2022-b0e776403c https://bodhi.fedoraproject.org/updates/FEDORA-2022-2852c49eed https://bodhi.fedoraproject.org/updates/FEDORA-2022-7fd92c637e
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com