[Bug 427738] New: Review Request: dropbear - SSH2 server and client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.




https://bugzilla.redhat.com/show_bug.cgi?id=427738

           Summary: Review Request: dropbear - SSH2 server and client
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: nobody(a)fedoraproject.org
        ReportedBy: buytenh(a)wantstofly.org
         QAContact: extras-qa(a)fedoraproject.org
                CC: [e-mail],notting(a)redhat.com


Spec URL: http://www.wantstofly.org/~buytenh/fedora-packages/dropbear.spec

SRPM URL: http://www.wantstofly.org/~buytenh/fedora-packages/dropbear-0.50-1.src.rpm

Description:
Dropbear is a relatively small SSH 2 server and client.  Dropbear
is particularly useful for "embedded"-type Linux (or other Unix)
systems, such as wireless routers.

This is my first package.  I am looking for a sponsor.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 427738] Review Request: dropbear - SSH2 server and client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client


https://bugzilla.redhat.com/show_bug.cgi?id=427738


buytenh(a)wantstofly.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |177841
              nThis|                            |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 427738] Review Request: dropbear - SSH2 server and client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client


https://bugzilla.redhat.com/show_bug.cgi?id=427738


tcallawa(a)redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody(a)fedoraproject.org    |tcallawa(a)redhat.com




------- Additional Comments From tcallawa(a)redhat.com  2008-01-07 10:34 EST -------
Taking this one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 427738] Review Request: dropbear - SSH2 server and client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client


https://bugzilla.redhat.com/show_bug.cgi?id=427738





------- Additional Comments From tcallawa(a)redhat.com  2008-01-07 10:57 EST -------
Only problems that I see:

- Please put the full URL path to the Sources (where possible).

- dropbear.src: W: strange-permission dropbear.init 0755

Should be easy enough to fix, just make sure the perms are -x on that file
before making the SRPM.

- dropbear.x86_64: W: file-not-utf8 /usr/share/doc/dropbear-0.50/CHANGES

Just add these lines in %setup:

# convert to UTF-8
iconv -f iso-8859-1 -t utf-8 -o CHANGES{.utf8,}
mv CHANGES{.utf8,}

- dropbear.x86_64: W: service-default-enabled /etc/rc.d/init.d/dropbear
  dropbear.x86_64: W: no-reload-entry /etc/rc.d/init.d/dropbear

Do you intend for this service to be enabled by default? Also, since the init
file is custom, please add the reload function. It can be as simple as calling
"stop, start".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 427738] Review Request: dropbear - SSH2 server and client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client


https://bugzilla.redhat.com/show_bug.cgi?id=427738





------- Additional Comments From buytenh(a)wantstofly.org  2008-01-10 11:07 EST -------
Thank you for the review.  I have uploaded 0.50-2 (which incorporates
all your review comments) to:

http://www.wantstofly.org/~buytenh/fedora-packages/dropbear-0.50-2.src.rpm

I hope I've fixed everything in this version.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 427738] Review Request: dropbear - SSH2 server and client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client


https://bugzilla.redhat.com/show_bug.cgi?id=427738


tcallawa(a)redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




------- Additional Comments From tcallawa(a)redhat.com  2008-01-14 14:26 EST -------
Good:

- rpmlint checks return:

dropbear.src:81: W: macro-in-%changelog setup
dropbear.src: W: mixed-use-of-spaces-and-tabs (spaces: line 82, tab: line 1)

Both of these are trivial, but you really shouldn't use macros in %changelog,
because rpm will try to evaluate them. Safe to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (MIT) OK, text in %doc, matches source 
- spec file legible, in am. english
- source matches upstream (97f31bbe1d36f156ec895de97ecc1d400da5f0e5)
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED. Go ahead and request sponsorship, as described here:
http://fedoraproject.org/wiki/PackageMaintainers/Join#head-a601c13b0950a8...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 427738] Review Request: dropbear - SSH2 server and client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client


https://bugzilla.redhat.com/show_bug.cgi?id=427738


buytenh(a)wantstofly.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?




------- Additional Comments From buytenh(a)wantstofly.org  2008-01-14 16:17 EST -------
New Package CVS Request
=======================
Package Name: dropbear
Short Description: SSH2 server and client
Owners: buytenh
Branches: F-8
InitialCC:
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 427738] Review Request: dropbear - SSH2 server and client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client


https://bugzilla.redhat.com/show_bug.cgi?id=427738


kevin(a)tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+




------- Additional Comments From kevin(a)tummy.com  2008-01-14 16:49 EST -------
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 427738] Review Request: dropbear - SSH2 server and client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client


https://bugzilla.redhat.com/show_bug.cgi?id=427738


buytenh(a)wantstofly.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 427738] Review Request: dropbear - SSH2 server and client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client


https://bugzilla.redhat.com/show_bug.cgi?id=427738


tibbs(a)math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|177841                      |
              nThis|                            |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 427738] Review Request: dropbear - SSH2 server and client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client


https://bugzilla.redhat.com/show_bug.cgi?id=427738


lkundrak(a)redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lkundrak(a)redhat.com
             Status|CLOSED                      |ASSIGNED
           Keywords|                            |Reopened
         Resolution|NEXTRELEASE                 |




------- Additional Comments From lkundrak(a)redhat.com  2008-03-08 05:19 EST -------
I would like to see this in EPEL.
Lennert: I'd be happy if you could maintain it; would you?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 427738] Review Request: dropbear - SSH2 server and client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client


https://bugzilla.redhat.com/show_bug.cgi?id=427738


buytenh(a)wantstofly.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs+                 |fedora-cvs?




------- Additional Comments From buytenh(a)wantstofly.org  2008-03-08 05:33 EST -------
Package Change Request
======================
Package Name: dropbear
New Branches: EL-4 EL-5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 427738] Review Request: dropbear - SSH2 server and client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client


https://bugzilla.redhat.com/show_bug.cgi?id=427738


kevin(a)tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+




------- Additional Comments From kevin(a)tummy.com  2008-03-08 14:34 EST -------
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 427738] Review Request: dropbear - SSH2 server and client

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dropbear - SSH2 server and client


https://bugzilla.redhat.com/show_bug.cgi?id=427738


tcallawa(a)redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |WORKSFORME




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.