Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=276201
Summary: Review Request: gt5 - A diff-capable 'du-browser' Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mszpak@wp.pl QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://timeoff.wsisiz.edu.pl/rpms/gt5/gt5.spec SRPM URL: http://timeoff.wsisiz.edu.pl/rpms/gt5/gt5-1.3d-2.src.rpm Description: Allows to check what takes the most of your hard disk space and track its changes.
It's a very small program (in fact a script), but was very useful for me, so I decided to make a package for Fedora.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gt5 - A diff-capable 'du-browser'
https://bugzilla.redhat.com/show_bug.cgi?id=276201
------- Additional Comments From mszpak@wp.pl 2007-09-04 10:50 EST ------- Ehh, those links weren't to the newest version of a package.
Spec URL: http://timeoff.wsisiz.edu.pl/rpms/gt5/gt5.spec SRPM URL: http://timeoff.wsisiz.edu.pl/rpms/gt5/gt5-1.3d-3.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gt5 - A diff-capable 'du-browser'
https://bugzilla.redhat.com/show_bug.cgi?id=276201
------- Additional Comments From mszpak@wp.pl 2007-09-04 11:45 EST ------- Ehh, a package has been waiting for 4 months and in the meantime an author sneakily released a new version ;)
Spec URL: http://timeoff.wsisiz.edu.pl/rpms/gt5/gt5.spec SRPM URL: http://timeoff.wsisiz.edu.pl/rpms/gt5/gt5-1.4.0-1.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gt5 - A diff-capable 'du-browser'
https://bugzilla.redhat.com/show_bug.cgi?id=276201
opensource@till.name changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource@till.name
------- Additional Comments From opensource@till.name 2007-09-09 08:19 EST ------- #sed is considered the minimum build environment #see: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions #Requires: sed
Sed being in the minumum build environment only affects BuildRequires but not Requires. But for building this packages, sed is not needed, so either you should add Requires: sed to the spec. Also the package requires a console web browser[1] for running, but I do not know how to ensure this with Requires. I will ask on a mailing list. Maybe you should require gzip and coreutils, too, then you should really have all requirements stated explicitly.
[1] to be precise: one out of "links links2 elinks lynx w3m" needs to be installed
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gt5 - A diff-capable 'du-browser'
https://bugzilla.redhat.com/show_bug.cgi?id=276201
------- Additional Comments From mszpak@wp.pl 2007-09-11 14:52 EST ------- I thought they can be omitted in both sections. Thanks for point it out.
I saw your thread on the mailing list and hopefully some generic provider will be added in some future version of Fedora. I added a note in description about required console web browser.
Updated version: Spec URL: http://timeoff.wsisiz.edu.pl/rpms/gt5/gt5.spec SRPM URL: http://timeoff.wsisiz.edu.pl/rpms/gt5/gt5-1.4.0-2.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gt5 - A diff-capable 'du-browser'
https://bugzilla.redhat.com/show_bug.cgi?id=276201
------- Additional Comments From panemade@gmail.com 2007-09-18 12:47 EST ------- change source URL to http://downloads.sourceforge.net/%%7Bname%7D/%%7Bname%7D-%%7Bversion%7D.tar....
you can change %defattr(0644,root,root,0755) to %defattr(-,root,root,-)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gt5 - A diff-capable 'du-browser'
https://bugzilla.redhat.com/show_bug.cgi?id=276201
------- Additional Comments From mszpak@wp.pl 2007-09-18 16:31 EST ------- (In reply to comment #5)
change source URL to http://downloads.sourceforge.net/%%7Bname%7D/%%7Bname%7D-%%7Bversion%7D.tar....
Why not. I'll do it in the next version.
you can change %defattr(0644,root,root,0755) to %defattr(-,root,root,-)
My version is safer IMHO. For example there were problems in (at least) FC6 where due to some coincidences, permissions for files in /usr/share/app/ allowed access for root only (600). I see no cons of my solution.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gt5 - A diff-capable 'du-browser'
https://bugzilla.redhat.com/show_bug.cgi?id=276201
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Flag| |needinfo?
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-10-24 09:25 EST ------- Who is reviewing this package now?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gt5 - A diff-capable 'du-browser'
https://bugzilla.redhat.com/show_bug.cgi?id=276201
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Flag|needinfo? |
------- Additional Comments From panemade@gmail.com 2007-10-24 09:50 EST ------- Mamoru, You proceed with this review. Would like to only CC member for this review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gt5 - A diff-capable 'du-browser'
https://bugzilla.redhat.com/show_bug.cgi?id=276201
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@ioa.s.u-tokyo.ac.jp
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-10-24 11:02 EST ------- Well,
* For this package it is better that you install gt5 script and man files by yourself using "install -p". This can easily keep timestamps and removes unneeded patch. * For F-8+, text browser provides "text-www-browser" virtial Provides, so for F-8+, this package should require "text-www-browser". * "INSTALL" file is for people who want to "install" this package by themselves and not needed for rpm users.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gt5 - A diff-capable 'du-browser'
https://bugzilla.redhat.com/show_bug.cgi?id=276201
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Status|NEW |ASSIGNED Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gt5 - A diff-capable 'du-browser'
https://bugzilla.redhat.com/show_bug.cgi?id=276201
------- Additional Comments From mszpak@wp.pl 2007-10-27 12:42 EST ------- I made suggested changes, but I'm not really sure that a version with direct use of install command is so much better.
Updated files: Spec URL: http://timeoff.wsisiz.edu.pl/rpms/gt5/gt5.spec SRPM URL: http://timeoff.wsisiz.edu.pl/rpms/gt5/gt5-1.4.0-4.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gt5 - A diff-capable 'du-browser'
https://bugzilla.redhat.com/show_bug.cgi?id=276201
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-10-28 03:16 EST ------- Okay.
--------------------------------------------------------------------- This package (gt5) is APPROVED by me ---------------------------------------------------------------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gt5 - A diff-capable 'du-browser'
https://bugzilla.redhat.com/show_bug.cgi?id=276201
mszpak@wp.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From mszpak@wp.pl 2007-10-29 07:33 EST ------- New Package CVS Request ======================= Package Name: gt5 Short Description: A diff-capable 'du-browser' Owners: szpak Branches: FC-6 F-7 F-8 InitialCC: Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gt5 - A diff-capable 'du-browser'
https://bugzilla.redhat.com/show_bug.cgi?id=276201
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gt5 - A diff-capable 'du-browser'
https://bugzilla.redhat.com/show_bug.cgi?id=276201
mszpak@wp.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From mszpak@wp.pl 2007-10-31 16:52 EST ------- Imported, built and submitted for testing. Thanks for your help.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla