[Bug 1426949] New: Review Request: golang-github-fsnotify-fsnotify - Cross-platform file system notifications for Go.
https://bugzilla.redhat.com/show_bug.cgi?id=1426949
Bug ID: 1426949 Summary: Review Request: golang-github-fsnotify-fsnotify - Cross-platform file system notifications for Go. Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: fred@fredericolima.com.br QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://fredlima.fedorapeople.org/packaging/golang-github-fsnotify-fsnotify.... SRPM URL: https://fredlima.fedorapeople.org/packaging/golang-github-fsnotify-fsnotify-...
Description: Cross-platform file system notifications for Go.
Fedora Account System Username: fredlima
This library is used by tools like Hugo (http://gohugo.io/).
https://bugzilla.redhat.com/show_bug.cgi?id=1426949
Frederico Lima fred@fredericolima.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Priority|unspecified |medium
https://bugzilla.redhat.com/show_bug.cgi?id=1426949
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1426972
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1426972 [Bug 1426972] Review Request: hugo - A Fast and Flexible Static Site Generator built with love in GoLang
https://bugzilla.redhat.com/show_bug.cgi?id=1426949
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |athoscribeiro@gmail.com Assignee|nobody@fedoraproject.org |athoscribeiro@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1426949
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Athos Ribeiro athoscribeiro@gmail.com --- Hi Fred,
There is a problem with rpmlint: golang-github-fsnotify-fsnotify-devel.noarch: W: summary-ended-with-dot C Cross-platform file system notifications for Go.
Note that the summary section should end WITHOUT a dot, while the description section should end WITH one. Pay attention to that whenever using gofed to produce your spec files.
Please, fix those before uploading.
Package looks good. Approved!
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: golang-github-fsnotify-fsnotify-devel-1.4.2-1.fc26.noarch.rpm
golang-github-fsnotify-fsnotify-unit-test-devel-1.4.2-1.fc26.x86_64.rpm golang-github-fsnotify-fsnotify-1.4.2-1.fc26.src.rpm golang-github-fsnotify-fsnotify-devel.noarch: W: summary-ended-with-dot C Cross-platform file system notifications for Go. golang-github-fsnotify-fsnotify.src: W: summary-ended-with-dot C Cross-platform file system notifications for Go. 3 packages and 0 specfiles checked; 0 errors, 2 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory golang-github-fsnotify-fsnotify-devel.noarch: W: summary-ended-with-dot C Cross-platform file system notifications for Go. 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
Requires -------- golang-github-fsnotify-fsnotify-unit-test-devel (rpmlib, GLIBC filtered): golang-github-fsnotify-fsnotify-devel
golang-github-fsnotify-fsnotify-devel (rpmlib, GLIBC filtered): golang(golang.org/x/sys/unix)
Provides -------- golang-github-fsnotify-fsnotify-unit-test-devel: golang-github-fsnotify-fsnotify-unit-test-devel golang-github-fsnotify-fsnotify-unit-test-devel(x86-64)
golang-github-fsnotify-fsnotify-devel: golang(github.com/fsnotify/fsnotify) golang-github-fsnotify-fsnotify-devel
Source checksums ---------------- https://github.com/fsnotify/fsnotify/archive/v1.4.2.tar.gz : CHECKSUM(SHA256) this package : 4a1fd9beeb0496b9cf6084ac83654ece19188e9b2ffa041652d1071d4b225415 CHECKSUM(SHA256) upstream package : 4a1fd9beeb0496b9cf6084ac83654ece19188e9b2ffa041652d1071d4b225415
https://bugzilla.redhat.com/show_bug.cgi?id=1426949
Frederico Lima fred@fredericolima.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |golang-github-fsnotify-fsno |golang-github-fsnotify-fsno |tify - Cross-platform file |tify - Cross-platform file |system notifications for |system notifications for Go |Go. |
https://bugzilla.redhat.com/show_bug.cgi?id=1426949
--- Comment #2 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-fsnotify-fs...
https://bugzilla.redhat.com/show_bug.cgi?id=1426949
--- Comment #3 from Fedora Update System updates@fedoraproject.org --- golang-github-fsnotify-fsnotify-1.4.2-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-be13ea67cf
https://bugzilla.redhat.com/show_bug.cgi?id=1426949
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1426949
Jan Chaloupka jchaloup@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jchaloup@redhat.com
--- Comment #4 from Jan Chaloupka jchaloup@redhat.com --- We already have the package in the distro [1]. Just the import prefix got changed. As both provides different prefix "github.com/fsnotify/fsnotify" vs. "github.com/go-fsnotify/fsnotify". However, later we should obsolete one of them once there is no project importing "github.com/go-fsnotify/fsnotify".
[1] https://koji.fedoraproject.org/koji/packageinfo?packageID=20974
https://bugzilla.redhat.com/show_bug.cgi?id=1426949
Jan Chaloupka jchaloup@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fred@fredericolima.com.br Flags| |needinfo?(fred@fredericolim | |a.com.br)
--- Comment #5 from Jan Chaloupka jchaloup@redhat.com --- Frederico, think you could build the package for f25 branch as well?
https://bugzilla.redhat.com/show_bug.cgi?id=1426949
--- Comment #6 from Athos Ribeiro athoscribeiro@gmail.com --- Hello Jan,
I failed looking for the package in another namespace. Maybe we could add a check on gofed to also look for packages with the same suffix and trigger a warning on that?
https://bugzilla.redhat.com/show_bug.cgi?id=1426949
--- Comment #7 from Jan Chaloupka jchaloup@redhat.com --- I am already building an infrastructure that can provide that information. Still, it is not finished and fully running. Meantime, it has to be checked manually.
https://bugzilla.redhat.com/show_bug.cgi?id=1426949
Frederico Lima fred@fredericolima.com.br changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(fred@fredericolim | |a.com.br) |
--- Comment #8 from Frederico Lima fred@fredericolima.com.br --- (In reply to Jan Chaloupka from comment #5)
Frederico, think you could build the package for f25 branch as well?
sure!
https://bugzilla.redhat.com/show_bug.cgi?id=1426949
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- golang-github-fsnotify-fsnotify-1.4.2-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-be13ea67cf
https://bugzilla.redhat.com/show_bug.cgi?id=1426949
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-06-11 12:15:22
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- golang-github-fsnotify-fsnotify-1.4.2-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com