Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Software-License Packages that provide templated software licenses
https://bugzilla.redhat.com/show_bug.cgi?id=461307
Summary: Review Request: perl-Software-License Packages that provide templated software licenses Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: berrange@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://berrange.fedorapeople.org/review/perl-Software-License/perl-Software-... SRPM URL: http://berrange.fedorapeople.org/review/perl-Software-License/perl-Software-... Description:
This new package is a requirement to upgrade perl-Module-CPANTS-Analyse to latest upstream release
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461307
Daniel Berrange berrange@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |461303
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461307
--- Comment #1 from Daniel Berrange berrange@redhat.com 2008-09-06 06:29:42 EDT --- Updated SRPM to fix a missing BuildRequires, and fix description. Spec file at same URL as before
http://berrange.fedorapeople.org/review/perl-Software-License/perl-Software-...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461307
Bug 461307 depends on bug 461303, which changed state.
Bug 461303 Summary: Review Request: perl-Data-Section - Read multiple hunks of data out of your DATA section https://bugzilla.redhat.com/show_bug.cgi?id=461303
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461307
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cweyl@alumni.drew.edu
--- Comment #2 from Chris Weyl cweyl@alumni.drew.edu 2008-09-13 04:21:48 EDT --- The explicit requires in the specfile should be dropped; they're duplicating the autogenerated requires:
====> requires for perl-Software-License-0.008-2.fc9.noarch.rpm perl >= 0:5.006 perl(:MODULE_COMPAT_5.10.0) perl(Data::Section) perl(Data::Section) >= 0.000 perl(Software::License::Artistic_1_0) perl(Software::License::GPL_1) perl(Sub::Install) perl(Sub::Install) >= 0.000 perl(Text::Template) perl(Text::Template) >= 0.000 perl(base) perl(strict) perl(warnings)
Scratch build looks good. ==> http://koji.fedoraproject.org/koji/taskinfo?taskID=824276
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461307
--- Comment #3 from Daniel Berrange berrange@redhat.com 2008-09-20 14:07:10 EDT --- Updated package dropping the redundant Requires: tags
http://berrange.fedorapeople.org/review/perl-Software-License/perl-Software-...
Specfile in same URL as before
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461307
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Flag| |fedora-review+
--- Comment #4 from Jason Tibbitts tibbs@math.uh.edu 2008-10-01 13:54:40 EDT --- The Source: URL seems incorrect; at least, I get 404 when trying to download it. Not sure what's up there, but I found the package at: http://search.cpan.org/CPAN/authors/id/R/RJ/RJBS/Software-License-%%7Bversio...
I don't see that this should hold up approval of this package, though; it may simply be an error at CPAN. I guess you can switch to the more complicated URL or bug CPAN to fix the issue; either way works for me, and if nothing changes then the automated source-fetching report will start bugging you.
After fixing that:
* source files match upstream: d5e2f5aca8813132eb3fd7306e56f0c9b2863625c7d545ab606c5b25d499b05d Software-License-0.008.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(Software::License) = 0.008 perl(Software::License::AGPL_3) perl(Software::License::Apache_1_1) perl(Software::License::Apache_2_0) perl(Software::License::Artistic_1_0) perl(Software::License::Artistic_2_0) perl(Software::License::BSD) perl(Software::License::FreeBSD) perl(Software::License::GFDL_1_2) perl(Software::License::GPL_1) perl(Software::License::GPL_2) perl(Software::License::GPL_3) perl(Software::License::LGPL_2_1) perl(Software::License::LGPL_3_0) perl(Software::License::MIT) perl(Software::License::Mozilla_1_0) perl(Software::License::Mozilla_1_1) perl(Software::License::Perl_5) perl(Software::License::QPL_1_0) perl(Software::License::Sun) perl(Software::License::Zlib) perl(Software::LicenseUtils) perl-Software-License = 0.008-3.fc10 = perl >= 0:5.006 perl(:MODULE_COMPAT_5.10.0) perl(Data::Section) perl(Software::License::Artistic_1_0) perl(Software::License::GPL_1) perl(Sub::Install) perl(Text::Template) perl(base) perl(strict) perl(warnings)
* %check is present and all tests pass: All tests successful. Files=2, Tests=8, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.06 cusr 0.01 csys = 0.09 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package.
APPROVED!
The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461307
--- Comment #5 from Daniel Berrange berrange@redhat.com 2008-10-02 06:06:31 EDT --- Odd that it source tar.gz doesn't exist there - it is certainly supposed to. I'll change the URL to point to the alternate location indexed by author instead of by module.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461307
Daniel Berrange berrange@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #6 from Daniel Berrange berrange@redhat.com 2008-10-02 06:07:41 EDT --- New Package CVS Request ======================= Package Name: perl-Software-License Short Description: Package that provides templated software licenses Owners: berrange Branches: F-9 InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461307
--- Comment #7 from Huzaifa S. Sidhpurwala huzaifas@redhat.com 2008-10-03 01:57:39 EDT --- cvs done
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461307
Huzaifa S. Sidhpurwala huzaifas@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461307
Daniel Berrange berrange@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
--- Comment #8 from Daniel Berrange berrange@redhat.com 2008-10-03 11:57:28 EDT --- Built into rawhide..
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461307
Daniel Berrange berrange@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #9 from Daniel Berrange berrange@redhat.com 2010-06-24 08:37:49 EDT --- Package Change Request ====================== Package Name: perl-Software-License New Branches: EL-6 Owners: berrange
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461307
--- Comment #10 from Jason Tibbitts tibbs@math.uh.edu 2010-06-26 11:53:56 EDT --- CVS done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461307
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461307
Paul Howarth paul@city-fan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |paul@city-fan.org
--- Comment #11 from Paul Howarth paul@city-fan.org 2012-03-05 10:15:26 EST --- Hi Daniel,
can we have an EL-5 branch for this package please? I have a patch to get the test suite to work with Test::More < 0.88 as found in EL-5. I (pghmcfc) would be happy to maintain this branch if you're not interested.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461307
Daniel Berrange berrange@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #12 from Daniel Berrange berrange@redhat.com 2012-03-06 06:44:51 EST --- Package Change Request ====================== Package Name: perl-Software-License New Branches: EL-5 Owners: berrange
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461307
--- Comment #13 from Paul Howarth paul@city-fan.org 2012-03-06 07:14:04 EST --- Created attachment 567931 --> https://bugzilla.redhat.com/attachment.cgi?id=567931 Patch to get test suite to work with Test::More < 0.88
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461307
--- Comment #14 from Jon Ciesla limburgher@gmail.com 2012-03-06 08:02:21 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461307
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2012-03-18 08:47:12 EDT --- perl-Software-License-0.103004-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Software-License-0.103004-2.el5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461307
--- Comment #16 from Fedora Update System updates@fedoraproject.org 2012-04-02 14:28:22 EDT --- perl-Software-License-0.103004-2.el5 has been pushed to the Fedora EPEL 5 stable repository.
package-review@lists.fedoraproject.org