Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908090
Bug ID: 908090 Summary: Review Request: xgraph - XGraph with animation Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Reporter: trpost@katamail.com
Spec URL: http://sagitter.fedorapeople.org/xgraph/xgraph.spec SRPM URL: http://sagitter.fedorapeople.org/xgraph/xgraph-12.1-2.fc18.src.rpm
Description: XGraph with animation is a modification of the popular XGraph plotting program written by David Harrison at UC Berkeley. It does animation of data sets, supports zooming regions with a mouse and taking numerical derivatives.
Fedora Account System Username: sagitter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908090
Antonio Trande trpost@katamail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |908088
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908090
Antonio Trande trpost@katamail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|908088 |177841 (FE-NEEDSPONSOR)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908090
Antonio Trande trpost@katamail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |908088
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908090
--- Comment #1 from Antonio Trande trpost@katamail.com --- Koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4931204
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908090
--- Comment #2 from Michael Schwendt mschwendt@gmail.com ---
http://kojipkgs.fedoraproject.org//work/tasks/1205/4931205/build.log
gcc -DHAVE_CONFIG_H -I. -Wall -g -MT xgraph.o -MD -MP -MF .deps/xgraph.Tpo -c -o xgraph.o xgraph.c
Can you make it build with global %optflags?
warning: operation on 'param_temp_ptr' may be undefined warning: cast from pointer to integer of different size
Many times. Scary. I just realized the software is from 1999, Debian's patch is
200K already, so I had to comment on this. ;-)
http://bugs.debian.org/cgi-bin/pkgreport.cgi?pkg=xgraph;dist=unstable
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908090
--- Comment #3 from Antonio Trande trpost@katamail.com --- Hi Michael.
(In reply to comment #2)
http://kojipkgs.fedoraproject.org//work/tasks/1205/4931205/build.log
gcc -DHAVE_CONFIG_H -I. -Wall -g -MT xgraph.o -MD -MP -MF .deps/xgraph.Tpo -c -o xgraph.o xgraph.c
Can you make it build with global %optflags?
make fails:
... configure: creating ./config.status config.status: creating Makefile config.status: creating autoconf.h config.status: executing depfiles commands + export CFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic + CFLAGS=-O2 /var/tmp/rpm-tmp.domHUw: line 51: export: `-g': not a valid identifier /var/tmp/rpm-tmp.domHUw: line 51: export: `-pipe': not a valid identifier /var/tmp/rpm-tmp.domHUw: line 51: export: `-Wall': not a valid identifier /var/tmp/rpm-tmp.domHUw: line 51: export: `-Wp,-D_FORTIFY_SOURCE=2': not a valid identifier /var/tmp/rpm-tmp.domHUw: line 51: export: `-fexceptions': not a valid identifier /var/tmp/rpm-tmp.domHUw: line 51: export: `-fstack-protector': not a valid identifier /var/tmp/rpm-tmp.domHUw: line 51: export: `--param=ssp-buffer-size=4': not a valid identifier /var/tmp/rpm-tmp.domHUw: line 51: export: `-m64': not a valid identifier /var/tmp/rpm-tmp.domHUw: line 51: export: `-mtune=generic': not a valid identifier error: Bad exit status from /var/tmp/rpm-tmp.domHUw (%build)
RPM build errors: Bad exit status from /var/tmp/rpm-tmp.domHUw (%build)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908090
--- Comment #4 from Antonio Trande trpost@katamail.com --- (In reply to comment #3)
Hi Michael.
(In reply to comment #2)
http://kojipkgs.fedoraproject.org//work/tasks/1205/4931205/build.log
gcc -DHAVE_CONFIG_H -I. -Wall -g -MT xgraph.o -MD -MP -MF .deps/xgraph.Tpo -c -o xgraph.o xgraph.c
Can you make it build with global %optflags?
make fails:
No, I'm wrong. :P
http://koji.fedoraproject.org/koji/taskinfo?taskID=4933428
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908090
Susi Lehtola susi.lehtola@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |susi.lehtola@iki.fi
--- Comment #5 from Susi Lehtola susi.lehtola@iki.fi --- Does it work with make install DESTDIR=%{buildroot} instead of %makeinstall? https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908090
--- Comment #6 from Michael Schwendt mschwendt@gmail.com ---
%make_install DESTDIR=$RPM_BUILD_ROOT
Probably there's some confusion. Using %make_install is okay. It's mentioned in those guidelines, too. With it, appending DESTDIR=… is not necessary, however. Check out: rpm --eval %make_install
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908090
--- Comment #7 from Antonio Trande trpost@katamail.com --- Some minor changes.
Spec URL: http://sagitter.fedorapeople.org/xgraph/xgraph.spec SRPM URL: http://sagitter.fedorapeople.org/xgraph/xgraph-12.1-2.fc18.src.rpm
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908090
Michael Schwendt mschwendt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) |
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=908090
Antonio Trande anto.trande@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed| |2013-04-02 09:28:23
--- Comment #8 from Antonio Trande anto.trande@gmail.com --- I agree with (ascend) upstream maintainer to don't include xgraph as Ascend dependency because it is a very old software not essential for Ascend use.
I leave .spec/src rpm available anyway.
package-review@lists.fedoraproject.org