[Bug 522732] New: Review Request: perl-Text-Diff-Parser - Parse patch files containing unified and standard diffs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Text-Diff-Parser - Parse patch files containing unified and standard diffs

https://bugzilla.redhat.com/show_bug.cgi?id=522732

Summary: Review Request: perl-Text-Diff-Parser - Parse patch
                    files containing unified and standard diffs
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL:
http://people.parinux.org/~seyman/fedora/perl-Text-Diff-Parser/perl-Text-Dif...
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-Text-Diff-Parser/perl-Text-Dif...
Description:
Text::Diff::Parser parses diff files and patches. It allows you to access
the changes to a file in a standardized way, even if multiple patch
formats are used.

[Bug 522732] Review Request: perl-Text-Diff-Parser - Parse patch files containing unified and standard diffs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=522732

--- Comment #1 from Emmanuel Seyman   2009-09-11 11:43:09 EDT ---
Upstream has released a new version, fixing a bug I reported.

Spec URL:
http://people.parinux.org/~seyman/fedora/perl-Text-Diff-Parser/perl-Text-Dif...
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-Text-Diff-Parser/perl-Text-Dif...

[Bug 522732] Review Request: perl-Text-Diff-Parser - Parse patch files containing unified and standard diffs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=522732

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review+

--- Comment #2 from Jason Tibbitts   2009-09-23 00:18:35 EDT ---
Builds fine and rpmlint is silent.

Note that a test is skipped because of a missing build dependency
(Pod::Coverage).  POD coverage is generally a maintainer check anyway, so I
don't think it's a big deal, but you run the POD checks so I figured you might
want to run the coverage checks too.

* source files match upstream.  sha256sum:                           
   3d69fa8eb97405a6bd398d0d9305a0aaa0f83cfa176a8660ab58674282cc0266
   Text-Diff-Parser-0.1001.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.                                                              
* description is OK.                                                          
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(Text::Diff::Parser) = 0.1001
   perl(Text::Diff::Parser::Change)
   perl-Text-Diff-Parser = 0.1001-1.fc12
  =
   perl >= 0:5.00404
   perl(:MODULE_COMPAT_5.10.0)
   perl(Carp)
   perl(IO::File)
   perl(strict)
   perl(vars)
   perl(warnings)

* %check is present and all tests pass:
   All tests successful.
   Files=7, Tests=58,  0 wallclock secs ( 0.05 usr  0.02 sys +  0.36 cusr  0.06 
   csys =  0.49 CPU)

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

The package review process needs reviewers!  If you haven't done any package
reviews recently, please consider doing one.

[Bug 522732] Review Request: perl-Text-Diff-Parser - Parse patch files containing unified and standard diffs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=522732

Emmanuel Seyman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #3 from Emmanuel Seyman   2009-09-23 03:10:08 EDT ---
(In reply to comment #2)
> APPROVED

Thanks, Jason. Requesting CVS.

New Package CVS Request
=======================
Package Name: perl-Text-Diff-Parser
Short Description: Parse patch files containing unified and standard diffs
Owners: eseyman
Branches: F-10 F-11 F-12
InitialCC: perl-sig

[Bug 522732] Review Request: perl-Text-Diff-Parser - Parse patch files containing unified and standard diffs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=522732

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #4 from Kevin Fenzi   2009-09-24 00:35:14 EDT ---
cvs done.

[Bug 522732] Review Request: perl-Text-Diff-Parser - Parse patch files containing unified and standard diffs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=522732

--- Comment #5 from Fedora Update System   2009-09-24 04:52:02 EDT ---
perl-Text-Diff-Parser-0.1001-1.fc10 has been submitted as an update for Fedora
10.
http://admin.fedoraproject.org/updates/perl-Text-Diff-Parser-0.1001-1.fc10

[Bug 522732] Review Request: perl-Text-Diff-Parser - Parse patch files containing unified and standard diffs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=522732

--- Comment #6 from Fedora Update System   2009-09-24 04:52:08 EDT ---
perl-Text-Diff-Parser-0.1001-1.fc11 has been submitted as an update for Fedora
11.
http://admin.fedoraproject.org/updates/perl-Text-Diff-Parser-0.1001-1.fc11

[Bug 522732] Review Request: perl-Text-Diff-Parser - Parse patch files containing unified and standard diffs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=522732

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |ON_QA

--- Comment #7 from Fedora Update System   2009-09-25 16:11:23 EDT ---
perl-Text-Diff-Parser-0.1001-1.fc11 has been pushed to the Fedora 11 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Text-Diff-Parser'.  You
can provide feedback for this update here:
http://admin.fedoraproject.org/updates/F11/FEDORA-2009-9930

[Bug 522732] Review Request: perl-Text-Diff-Parser - Parse patch files containing unified and standard diffs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=522732

--- Comment #8 from Fedora Update System   2009-09-25 16:14:42 EDT ---
perl-Text-Diff-Parser-0.1001-1.fc10 has been pushed to the Fedora 10 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Text-Diff-Parser'.  You
can provide feedback for this update here:
http://admin.fedoraproject.org/updates/F10/FEDORA-2009-9956

[Bug 522732] Review Request: perl-Text-Diff-Parser - Parse patch files containing unified and standard diffs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=522732

--- Comment #9 from Fedora Update System   2009-09-30 20:02:56 EDT ---
perl-Text-Diff-Parser-0.1001-1.fc10 has been pushed to the Fedora 10 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 522732] Review Request: perl-Text-Diff-Parser - Parse patch files containing unified and standard diffs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=522732

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |0.1001-1.fc10
         Resolution|                            |ERRATA

[Bug 522732] Review Request: perl-Text-Diff-Parser - Parse patch files containing unified and standard diffs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=522732

--- Comment #10 from Fedora Update System   2009-09-30 20:05:30 EDT ---
perl-Text-Diff-Parser-0.1001-1.fc11 has been pushed to the Fedora 11 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 522732] Review Request: perl-Text-Diff-Parser - Parse patch files containing unified and standard diffs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=522732

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|0.1001-1.fc10               |0.1001-1.fc11