9:09 p.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1570463
Bug ID: 1570463
Summary: Review Request: libbtbb - A Bluetooth baseband
decoding library
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: sergey.avseyev(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: https://avsej.fedorapeople.org/libbtbb/0/libbtbb.spec
SRPM URL:
https://avsej.fedorapeople.org/libbtbb/0/libbtbb-2017.03.R2-1.fc29.src.rpm
Description: This is the Bluetooth baseband decoding library, forked from the
GR-Bluetooth project. It can be used to extract Bluetooth packet and piconet
information from Ubertooth devices as well as GR-Bluetooth/USRP.
Fedora Account System Username: avsej
Build URL:
https://copr.fedorainfracloud.org/coprs/avsej/ubertooth/build/741946/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:12 p.m.
New subject: [Bug 1570463] Review Request:
libbtbb - A Bluetooth baseband decoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1570463
Sergey Avseyev <sergey.avseyev(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jsmith.fedora(a)gmail.com
--- Comment #1 from Sergey Avseyev <sergey.avseyev(a)gmail.com> ---
*** Bug 1102795 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:19 p.m.
New subject: [Bug 1570463] Review Request:
libbtbb - A Bluetooth baseband decoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1570463
Sergey Avseyev <sergey.avseyev(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |1570464
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1570464
[Bug 1570464] Review Request: ubertooth - A Bluetooth wireless development
platform for experimentation
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:40 p.m.
New subject: [Bug 1570463] Review Request:
libbtbb - A Bluetooth baseband decoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1570463
--- Comment #2 from Sergey Avseyev <sergey.avseyev(a)gmail.com> ---
Spec URL: https://avsej.fedorapeople.org/libbtbb/1/libbtbb.spec
SRPM URL:
https://avsej.fedorapeople.org/libbtbb/1/libbtbb-2017.03.R2-1.fc29.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=26505049
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:33 p.m.
New subject: [Bug 1570463] Review Request:
libbtbb - A Bluetooth baseband decoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1570463
Robert-André Mauchin <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
CC| |zebob.m(a)gmail.com
Assignee|nobody(a)fedoraproject.org |zebob.m(a)gmail.com
Flags| |fedora-review+
--- Comment #3 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
- Use %global, not %define:
%global POSTYEAR 2017
%global POSTMONTH 03
%global POSTNUM 2
Package otherwise aprroved.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later)", "Unknown or generated", "*No
copyright*
BSD (3 clause)", "BSL (v1.0)", "GPL (v2 or later) (with incorrect
FSF
address)", "BSD (unspecified)", "*No copyright* GPL (v2 or
later)".
107 files have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/libbtbb/review-libbtbb/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[!]: Spec use %global instead of %define unless justified.
Note: %define requiring justification: %define POSTYEAR 2017, %define
POSTMONTH 03, %define POSTNUM 2
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: libbtbb-2017.03.R2-1.fc29.x86_64.rpm
libbtbb-devel-2017.03.R2-1.fc29.x86_64.rpm
libbtbb-debuginfo-2017.03.R2-1.fc29.x86_64.rpm
libbtbb-debugsource-2017.03.R2-1.fc29.x86_64.rpm
libbtbb-2017.03.R2-1.fc29.src.rpm
libbtbb.x86_64: W: spelling-error Summary(en_US) baseband -> base band,
base-band, baseboard
libbtbb.x86_64: W: spelling-error %description -l en_US baseband -> base band,
base-band, baseboard
libbtbb.x86_64: W: spelling-error %description -l en_US piconet -> phonetic
libbtbb.x86_64: W: shared-lib-calls-exit /usr/lib64/libbtbb.so.1.0
exit(a)GLIBC_2.2.5
libbtbb.x86_64: W: no-documentation
libbtbb-devel.x86_64: W: only-non-binary-in-usr-lib
libbtbb-devel.x86_64: W: no-documentation
libbtbb-debugsource.x86_64: W: no-documentation
libbtbb.src: W: spelling-error Summary(en_US) baseband -> base band, base-band,
baseboard
libbtbb.src: W: spelling-error %description -l en_US baseband -> base band,
base-band, baseboard
libbtbb.src: W: spelling-error %description -l en_US piconet -> phonetic
5 packages and 0 specfiles checked; 0 errors, 11 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:54 p.m.
New subject: [Bug 1570463] Review Request:
libbtbb - A Bluetooth baseband decoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1570463
--- Comment #4 from Sergey Avseyev <sergey.avseyev(a)gmail.com> ---
Thanks for review, I've updated spec with %global
Spec URL: https://avsej.fedorapeople.org/libbtbb/2/libbtbb.spec
SRPM URL:
https://avsej.fedorapeople.org/libbtbb/2/libbtbb-2017.03.R2-1.fc29.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=26522514
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:36 p.m.
New subject: [Bug 1570463] Review Request:
libbtbb - A Bluetooth baseband decoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1570463
--- Comment #5 from Gwyn Ciesla <limburgher(a)gmail.com> ---
(fedrepo-req-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/libbtbb
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:18 p.m.
New subject: [Bug 1570463] Review Request:
libbtbb - A Bluetooth baseband decoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1570463
Sergey Avseyev <sergey.avseyev(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |CLOSED
Resolution|--- |RAWHIDE
Last Closed| |2018-04-23 18:18:14
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:31 p.m.
New subject: [Bug 1570463] Review Request:
libbtbb - A Bluetooth baseband decoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1570463
--- Comment #6 from Fedora Update System <updates(a)fedoraproject.org> ---
libbtbb-2017.03.R2-1.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-dd6a9215bb
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:31 p.m.
New subject: [Bug 1570463] Review Request:
libbtbb - A Bluetooth baseband decoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1570463
--- Comment #7 from Fedora Update System <updates(a)fedoraproject.org> ---
libbtbb-2017.03.R2-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-6a1ebdbb00
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:38 a.m.
New subject: [Bug 1570463] Review Request:
libbtbb - A Bluetooth baseband decoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1570463
--- Comment #8 from Fedora Update System <updates(a)fedoraproject.org> ---
libbtbb-2017.03.R2-1.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-6a1ebdbb00
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:14 p.m.
New subject: [Bug 1570463] Review Request:
libbtbb - A Bluetooth baseband decoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1570463
--- Comment #9 from Fedora Update System <updates(a)fedoraproject.org> ---
libbtbb-2017.03.R2-1.fc28 has been pushed to the Fedora 28 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-dd6a9215bb
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:17 p.m.
New subject: [Bug 1570463] Review Request:
libbtbb - A Bluetooth baseband decoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1570463
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|RAWHIDE |ERRATA
--- Comment #10 from Fedora Update System <updates(a)fedoraproject.org> ---
libbtbb-2017.03.R2-1.fc28 has been pushed to the Fedora 28 stable repository.
If problems still persist, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:35 a.m.
New subject: [Bug 1570463] Review Request:
libbtbb - A Bluetooth baseband decoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1570463
--- Comment #11 from Fedora Update System <updates(a)fedoraproject.org> ---
libbtbb-2017.03.R2-1.fc27 has been pushed to the Fedora 27 stable repository.
If problems still persist, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2222
days inactive
2231
days old
package-review@lists.fedoraproject.org
13 comments
1 participants
participants (1)
-
bugzilla＠redhat.com