[Bug 2060218] New: Review Request: python-socksio - Client-side sans-I/O SOCKS proxy implementation

https://bugzilla.redhat.com/show_bug.cgi?id=2060218

Bug ID: 2060218
           Summary: Review Request: python-socksio - Client-side sans-I/O
                    SOCKS proxy implementation
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedor...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedor...

Description:
Client-side sans-I/O SOCKS proxy implementation. Supports SOCKS4, SOCKS4A, and
SOCKS5.  socksio is a sans-I/O library similar to h11 or h2, this means the
library itself does not handle the actual sending of the bytes through the
network, it only deals with the implementation details of the SOCKS protocols
so you can use it in any I/O library you want.

Fedora Account System Username: carlwgeorge

[Bug 2060218] Review Request: python-socksio - Client-side sans-I/O SOCKS proxy implementation

https://bugzilla.redhat.com/show_bug.cgi?id=2060218

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
              Flags|                            |fedora-review+
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]

--- Comment #1 from Neal Gompa  ---
Review notes:

[x]: Package follows Fedora Python Packaging Guidelines
[x]: Package builds and installs
[x]: No serious issues from rpmlint
[x]: License is correctly identified and installed

PACKAGE APPROVED.

[Bug 2060218] Review Request: python-socksio - Client-side sans-I/O SOCKS proxy implementation

https://bugzilla.redhat.com/show_bug.cgi?id=2060218

--- Comment #2 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-socksio

[Bug 2060218] Review Request: python-socksio - Client-side sans-I/O SOCKS proxy implementation

https://bugzilla.redhat.com/show_bug.cgi?id=2060218

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #3 from Fedora Update System  ---
FEDORA-2022-cba8cebc87 has been submitted as an update to Fedora 37.
https://bodhi.fedoraproject.org/updates/FEDORA-2022-cba8cebc87

[Bug 2060218] Review Request: python-socksio - Client-side sans-I/O SOCKS proxy implementation

https://bugzilla.redhat.com/show_bug.cgi?id=2060218

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2022-03-03 19:40:06

--- Comment #4 from Fedora Update System  ---
FEDORA-2022-cba8cebc87 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2060218] Review Request: python-socksio - Client-side sans-I/O SOCKS proxy implementation

https://bugzilla.redhat.com/show_bug.cgi?id=2060218

Fabian Affolter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2037405

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2037405
[Bug 2037405] python-httpcore-0.14.7 is available

[Bug 2060218] Review Request: python-socksio - Client-side sans-I/O SOCKS proxy implementation

https://bugzilla.redhat.com/show_bug.cgi?id=2060218

Miro Hrončok  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Miro Hrončok  ---
> [x]: License is correctly identified and installed

But it is not identified, only installed.

/usr/lib/python3.10/site-packages/socksio-1.0.0.dist-info/LICENSE is included
in the package but not marked as license.

Also, the manual buildrequires for flit-core is redundant, it is marked as
[build-system] requirement in pyproject.toml.

-> https://src.fedoraproject.org/rpms/python-socksio/pull-request/1

[Bug 2060218] Review Request: python-socksio - Client-side sans-I/O SOCKS proxy implementation

https://bugzilla.redhat.com/show_bug.cgi?id=2060218

--- Comment #6 from Carl George 🤠  ---
Thanks for catching that Miro.

f37: https://bodhi.fedoraproject.org/updates/FEDORA-2022-f83ebab632
f36: https://bodhi.fedoraproject.org/updates/FEDORA-2022-02047dc2cf
epel9: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-2ef16287a1