https://bugzilla.redhat.com/show_bug.cgi?id=1770278
Bug ID: 1770278 Summary: Review Request: vimiv-qt - An image viewer with vim-like keybindings Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: sanjay.ankur@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://ankursinha.fedorapeople.org/vimiv-qt/vimiv-qt.spec SRPM URL: https://ankursinha.fedorapeople.org/vimiv-qt/vimiv-qt-0.3.0-1.fc32.src.rpm
Description: Vimiv is an image viewer with vim-like keybindings. It is written in python3 using the Qt5 toolkit and is free software, licensed under the GPL.
The initial GTK3 version of vimiv will no longer be maintained.
- Simple library browser - Thumbnail mode - Basic image editing - Command line with tab completion - Complete customization with style sheets
Fedora Account System Username: ankursinha
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
J. Scheurich mufti11@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mufti11@web.de
--- Comment #1 from J. Scheurich mufti11@web.de --- There are errors during the package build:
$ pmbuild -ba vimiv-qt.spec ... ... make: Entering directory '/home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs' Running Sphinx v1.8.4 making output directory... building [mo]: targets for 0 po files that are out of date building [html]: targets for 19 source files that are out of date updating environment: 19 added, 0 changed, 0 removed reading sources... [100%] screenshots /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/documentation/commands.rst:20: WARNING: Problems with "include" directive path: InputError: [Errno 2] No such file or directory: 'documentation/commands_desc.rstsrc'. /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/documentation/configuration/keybindings.rst:37: WARNING: Problems with "include" directive path: InputError: [Errno 2] No such file or directory: 'documentation/configuration/keybindings_table.rstsrc'. /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/documentation/configuration/plugins.rst:26: WARNING: Problems with "include" directive path: InputError: [Errno 2] No such file or directory: 'documentation/configuration/default_plugins.rstsrc'. /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/documentation/configuration/settings.rst:17: WARNING: Problems with "include" directive path: InputError: [Errno 2] No such file or directory: 'documentation/configuration/settings_table.rstsrc'. /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/documentation/configuration/statusbar.rst:33: WARNING: Problems with "include" directive path: InputError: [Errno 2] No such file or directory: 'documentation/configuration/status_modules.rstsrc'. WARNING: autodoc: failed to import module 'imutils' from module 'vimiv'; the following exception was raised: cannot import name '_c_manipulate' from 'vimiv.imutils' (/home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/vimiv/imutils/__init__.py) WARNING: autodoc: failed to import module 'imutils.immanipulate' from module 'vimiv'; the following exception was raised: cannot import name '_c_manipulate' from 'vimiv.imutils' (/home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/vimiv/imutils/__init__.py) /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/index.rst:: WARNING: image file not readable: _static/vimiv/vimiv_banner_800.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/index.rst:: WARNING: image file not readable: _static/scrots/image_light.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/index.rst:: WARNING: image file not readable: _static/scrots/thumbnail_light.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/index.rst:: WARNING: image file not readable: _static/scrots/library_dark.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/index.rst:: WARNING: image file not readable: _static/scrots/command_dark.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/manpage/vimiv.1.rst:10: WARNING: Problems with "include" directive path: InputError: [Errno 2] No such file or directory: 'manpage/synopsis.rstsrc'. /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/manpage/vimiv.1.rst:23: WARNING: Problems with "include" directive path: InputError: [Errno 2] No such file or directory: 'manpage/options.rstsrc'. /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/screenshots.rst:: WARNING: image file not readable: _static/scrots/image_dark.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/screenshots.rst:: WARNING: image file not readable: _static/scrots/thumbnail_dark.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/screenshots.rst:: WARNING: image file not readable: _static/scrots/library_dark.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/screenshots.rst:: WARNING: image file not readable: _static/scrots/command_dark.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/screenshots.rst:: WARNING: image file not readable: _static/scrots/image_light.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/screenshots.rst:: WARNING: image file not readable: _static/scrots/thumbnail_light.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/screenshots.rst:: WARNING: image file not readable: _static/scrots/library_light.png /home/mufti/rpmbuild/BUILD/vimiv-qt-0.3.0/docs/screenshots.rst:: WARNING: image file not readable: _static/scrots/command_light.png looking for now-outdated files... none found pickling environment... done checking consistency... done preparing documents... done /usr/lib/python3.7/site-packages/sphinx/builders/html.py:138: RemovedInSphinx20Warning: builder.css_files is deprecated. Please use app.add_stylesheet() instead. ret += other writing output... [100%] screenshots generating indices... genindex py-modindex writing additional pages... search copying static files... WARNING: logo file '_static/vimiv/vimiv.png' does not exist done copying extra files... done dumping search index in English (code: en) ... done dumping object inventory... done build succeeded, 23 warnings.
The HTML pages are in _build/html. ...
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
--- Comment #2 from J. Scheurich mufti11@web.de --- [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path.
vimiv-qt-0.3.0$ find . -name '*.so*' ./build/lib.linux-x86_64-3.7/vimiv/imutils/_c_manipulate.cpython-37m-x86_64-linux-gnu.so
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
--- Comment #3 from J. Scheurich mufti11@web.de ---
License: GPLv3+
vimiv-qt-0.3.0$ find . -type f | xargs grep license ... ./docs/_build/html/_static/doctools.js: * :license: BSD, see LICENSE for details. ./docs/_build/html/_static/underscore.js:// Underscore is freely distributable under the MIT license. ./docs/_build/html/_static/bootswatch-2.3.2/cyborg/bootstrap.min.css: * http://www.apache.org/licenses/LICENSE-2.0 ./docs/_build/html/_static/bootswatch-2.3.2/readable/bootstrap.min.css: * http://www.apache.org/licenses/LICENSE-2.0 ./docs/_build/html/_static/bootswatch-2.3.2/journal/bootstrap.min.css: * http://www.apache.org/licenses/LICENSE-2.0 ... more references to the apache 2 license ... ./docs/_build/html/_static/basic.css: * :license: BSD, see LICENSE for details. ./docs/_build/html/_static/bootstrap-3.3.6/js/bootstrap.js: * Licensed under the MIT license ./docs/_build/html/_static/bootstrap-3.3.6/js/bootstrap.min.js: * Licensed under the MIT license ./docs/_build/html/_static/jquery-3.2.1.js: * Released under the MIT license ./docs/_build/html/_static/jquery-3.2.1.js: * https://jquery.org/license ./docs/_build/html/_static/jquery-3.2.1.js: * Released under the MIT license ./docs/_build/html/_static/jquery-3.2.1.js: * http://jquery.org/license ./docs/_build/html/_static/searchtools.js: * :license: BSD, see LICENSE for details. ./docs/_build/html/_static/searchtools.js: * :license: BSD, see LICENSE for details. ./docs/_build/html/_static/js/jquery-1.11.0.min.js:/*! jQuery v1.12.4 | (c) jQuery Foundation | jquery.org/license */ ./docs/_build/html/_static/jquery.js:/*! jQuery v3.2.1 | (c) JS Foundation and other contributors | jquery.org/license */ ./docs/_build/html/_static/websupport.js: * :license: BSD, see LICENSE for details.
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
--- Comment #4 from J. Scheurich mufti11@web.de --- !]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 7075840 bytes in /usr/share
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
--- Comment #5 from J. Scheurich mufti11@web.de --- Rpmlint ------- Checking: vimiv-qt-0.3.0-1.fc32.x86_64.rpm vimiv-qt-doc-0.3.0-1.fc32.x86_64.rpm vimiv-qt-debuginfo-0.3.0-1.fc32.x86_64.rpm vimiv-qt-debugsource-0.3.0-1.fc32.x86_64.rpm vimiv-qt-0.3.0-1.fc32.src.rpm vimiv-qt-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/vimiv-q$ 5 packages and 0 specfiles checked; 0 errors, 1 warnings.
...
Rpmlint (installed packages) --. vimiv-qt-doc.x86_64: W: description-shorter-than-summary ... imiv-qt-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/vimiv-qt-doc/html/objects.inv
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
--- Comment #6 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- - The package builds correctly on rawhide. Here's a scratch build, for example: https://koji.fedoraproject.org/koji/taskinfo?taskID=38865749
- They aren't shared objects, they are compiled python libraries, so that particular guidelines does not apply to them. - The stuff in %{_datadir} are the icons, so it doesn't make sense to move them to a subpackage. - I removed the the documentation. We include the man page for the application, and the docs are available online. - I improved the description of the doc sub package to make it longer than the summary.
The tests required pytest-bdd which is not yet in Fedora, so they can't be run at the moment.
Spec/srpm updated in place.
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
--- Comment #7 from J. Scheurich mufti11@web.de --- You should use something like
License: GPLv3+ and ASL 2.0 and BSD and MIT
as license tag
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
--- Comment #8 from J. Scheurich mufti11@web.de --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C-/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/python3.8/site- packages/vimiv(vimiv), /usr/lib64/python3.8/site- packages/vimiv/__pycache__(vimiv) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
===== SHOULD items =====
Generic: [-]: Uses parallel make %{?_smp_mflags} macro. [?]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 7075840 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: vimiv-qt-0.3.0-1.fc32.x86_64.rpm vimiv-qt-doc-0.3.0-1.fc32.x86_64.rpm vimiv-qt-debuginfo-0.3.0-1.fc32.x86_64.rpm vimiv-qt-debugsource-0.3.0-1.fc32.x86_64.rpm vimiv-qt-0.3.0-1.fc32.src.rpm vimiv-qt-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/vimiv-qt-doc/html/objects.inv 5 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (debuginfo) ------------------- Checking: vimiv-qt-debuginfo-0.3.0-1.fc32.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). vimiv-qt-debuginfo.x86_64: W: invalid-url URL: https://karlch.github.io/vimiv-qt/ <urlopen error [Errno -2] Name or service not known> vimiv-qt-doc.x86_64: W: description-shorter-than-summary vimiv-qt-doc.x86_64: W: invalid-url URL: https://karlch.github.io/vimiv-qt/ <urlopen error [Errno -2] Name or service not known> vimiv-qt-doc.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/vimiv-qt-doc/html/objects.inv vimiv-qt-debugsource.x86_64: W: invalid-url URL: https://karlch.github.io/vimiv-qt/ <urlopen error [Errno -2] Name or service not known> vimiv-qt.x86_64: W: invalid-url URL: https://karlch.github.io/vimiv-qt/ <urlopen error [Errno -2] Name or service not known> 4 packages and 0 specfiles checked; 0 errors, 6 warnings.
Unversioned so-files -------------------- vimiv-qt: /usr/lib64/python3.8/site-packages/vimiv/imutils/_c_manipulate.cpython-38-x86_64-linux-gnu.so
Source checksums ---------------- https://github.com/karlch/vimiv-qt/archive/v0.3.0/vimiv-qt-0.3.0.tar.gz : CHECKSUM(SHA256) this package : c14e5a96ecb97b0c3b6961589c2d509dc0785539c13636dea6674146a1e8af75 CHECKSUM(SHA256) upstream package : c14e5a96ecb97b0c3b6961589c2d509dc0785539c13636dea6674146a1e8af75
Requires -------- vimiv-qt (rpmlib, GLIBC filtered): /usr/bin/python3 hicolor-icon-theme libc.so.6()(64bit) python(abi) python3-piexif python3.8dist(pyqt5) python3.8dist(setuptools) rtld(GNU_HASH)
vimiv-qt-doc (rpmlib, GLIBC filtered):
vimiv-qt-debuginfo (rpmlib, GLIBC filtered):
vimiv-qt-debugsource (rpmlib, GLIBC filtered):
Provides -------- vimiv-qt: application() application(vimiv.desktop) metainfo() metainfo(vimiv.appdata.xml) mimehandler(image/bmp) mimehandler(image/gif) mimehandler(image/jp2) mimehandler(image/jpeg) mimehandler(image/jpeg2000) mimehandler(image/jpx) mimehandler(image/png) mimehandler(image/svg) mimehandler(image/tiff) python-vimiv-qt python3.8dist(vimiv) python3dist(vimiv) vimiv vimiv-qt vimiv-qt(x86-64)
vimiv-qt-doc: vimiv-qt-doc vimiv-qt-doc(x86-64)
vimiv-qt-debuginfo: debuginfo(build-id) vimiv-qt-debuginfo vimiv-qt-debuginfo(x86-64)
vimiv-qt-debugsource: vimiv-qt-debugsource vimiv-qt-debugsource(x86-64)
Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18 Command line :/bin/fedora-review -n vimiv-qt Buildroot used: fedora-rawhide-{{ target_arch }} Active plugins: Generic, Shell-api, Python, C/C++ Disabled plugins: Perl, Haskell, R, Java, SugarActivity, PHP, fonts, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
--- Comment #9 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- (In reply to J. Scheurich from comment #7)
You should use something like
License: GPLv3+ and ASL 2.0 and BSD and MIT
as license tag
Hrm, can you please list what files these licenses cover please? Licensecheck doesn't find them:
$ licensecheck -r . | sed '/UNKNOWN/ d' ./README.md: *No copyright* GPL (v3 or later) ./docs/conf.py: GENERATED FILE ./docs/description.rst: *No copyright* GNU General Public License ./misc/vimiv.1: *No copyright* GNU General Public License GENERATED FILE ./docs/documentation/getting_started.rst: *No copyright* GENERATED FILE ./vimiv/imutils/_file_handler.py: GENERATED FILE ./vimiv/utils/thumbnail_manager.py: GENERATED FILE
Grepping the source for MIT/BSD/ASL doesn't seem to return anything either.
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
--- Comment #10 from J. Scheurich mufti11@web.de --- I found this licsense statements in this way:
vimiv-qt-0.3.0$ find . -type f | xargs grep license ... ./docs/_build/html/_static/doctools.js: * :license: BSD, see LICENSE for details. ./docs/_build/html/_static/underscore.js:// Underscore is freely distributable under the MIT license. ./docs/_build/html/_static/bootswatch-2.3.2/cyborg/bootstrap.min.css: * http://www.apache.org/licenses/LICENSE-2.0 ./docs/_build/html/_static/bootswatch-2.3.2/readable/bootstrap.min.css: * http://www.apache.org/licenses/LICENSE-2.0 ./docs/_build/html/_static/bootswatch-2.3.2/journal/bootstrap.min.css: * http://www.apache.org/licenses/LICENSE-2.0 ... more references to the apache 2 license ... ./docs/_build/html/_static/basic.css: * :license: BSD, see LICENSE for details. ./docs/_build/html/_static/bootstrap-3.3.6/js/bootstrap.js: * Licensed under the MIT license ./docs/_build/html/_static/bootstrap-3.3.6/js/bootstrap.min.js: * Licensed under the MIT license ./docs/_build/html/_static/jquery-3.2.1.js: * Released under the MIT license ./docs/_build/html/_static/jquery-3.2.1.js: * https://jquery.org/license ./docs/_build/html/_static/jquery-3.2.1.js: * Released under the MIT license ./docs/_build/html/_static/jquery-3.2.1.js: * http://jquery.org/license ./docs/_build/html/_static/searchtools.js: * :license: BSD, see LICENSE for details. ./docs/_build/html/_static/searchtools.js: * :license: BSD, see LICENSE for details. ./docs/_build/html/_static/js/jquery-1.11.0.min.js:/*! jQuery v1.12.4 | (c) jQuery Foundation | jquery.org/license */ ./docs/_build/html/_static/jquery.js:/*! jQuery v3.2.1 | (c) JS Foundation and other contributors | jquery.org/license */ ./docs/_build/html/_static/websupport.js: * :license: BSD, see LICENSE for details.
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
--- Comment #11 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Those are from the doc sub-package, but we've removed that. So these shouldn't show up any more. Can you please check with the newest spec/srpm?
Spec URL: https://ankursinha.fedorapeople.org/vimiv-qt/vimiv-qt.spec SRPM URL: https://ankursinha.fedorapeople.org/vimiv-qt/vimiv-qt-0.3.0-1.fc32.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
--- Comment #12 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Are you still having issues setting the flags @mufti? If that was sorted, please complete this review.
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
--- Comment #13 from J. Scheurich mufti11@web.de --- After mailing to infrastructure, i was able to set the review flag.
Are there furter actions needed ?
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
--- Comment #14 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Weird---the flag is not set.
you need to:
- assign the ticket to yourself (click "take" in the "Assignee" field---you should do this when you start the review to let others know that you are working on this ticket) - set the status to "POST" (you should have set this to "ASSIGNED" when you started the review) - set the fedora-review flag to "+" (you should have set this to ? when you started the review).
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #15 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- This is all documented here: https://fedoraproject.org/wiki/Package_Review_Process
Please go through these pages.
I have cc'd eclipseo, your sponsor, who should be able to help you learn the required skills and processes necessary for package maintenance tasks.
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
J. Scheurich mufti11@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- QA Contact|extras-qa@fedoraproject.org |mufti11@web.de
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
J. Scheurich mufti11@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |mufti11@web.de
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
--- Comment #16 from J. Scheurich mufti11@web.de --- I am unable to set the status to POST.
When i click edit, the browser jumps to additional comments.
I will send a mail to infrastructur.
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
--- Comment #17 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- (In reply to J. Scheurich from comment #16)
I am unable to set the status to POST.
When i click edit, the browser jumps to additional comments.
I will send a mail to infrastructur.
Ah, no, it jumps to the bottom of the page where you can set the status using the "status" drop down.
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
J. Scheurich mufti11@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
--- Comment #18 from Ankur Sinha (FranciscoD) sanjay.ankur@gmail.com --- Can you please set the fedora-review flag to "+" too? One cannot request a repository without it (a review is not considered complete and approved without it).
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
J. Scheurich mufti11@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|mufti11@web.de |nobody@fedoraproject.org QA Contact|mufti11@web.de |extras-qa@fedoraproject.org Flags| |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
J. Scheurich mufti11@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |mufti11@web.de
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
--- Comment #20 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/vimiv-qt
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- FEDORA-2019-cfb26630d1 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-cfb26630d1
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- vimiv-qt-0.3.0-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-e541ab8c87
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- vimiv-qt-0.3.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-cfb26630d1
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2019-12-02 01:13:00
--- Comment #24 from Fedora Update System updates@fedoraproject.org --- vimiv-qt-0.3.0-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1770278
--- Comment #25 from Fedora Update System updates@fedoraproject.org --- vimiv-qt-0.3.0-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com