[Bug 550369] New: Review Request: spill - A segregated package install logical linker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: spill - A segregated package install logical linker

https://bugzilla.redhat.com/show_bug.cgi?id=550369

Summary: Review Request: spill - A segregated package install
                    logical linker
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/spill.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/spill-0.8-1.fc12.src.rpm

Project URL: http://www.rc0.org.uk/spill

Description:
spill is a program for creating set of symbolic links from one directory
hierarchy which point to corresponding filenames in a separate directory
hierarchy. It's primary use is to allow packages built from source to be
installed in separate directory trees, which are all linked together under
a common directory tree (e.g. /usr/local) to reduce the length of the PATH
environment variable.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1890668

rpmlint output:
[fab@localhost i686]$ rpmlint spill*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

[fab@localhost SRPMS]$ rpmlint spill-0.8-1.fc12.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[Bug 550369] Review Request: spill - A segregated package install logical linker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=550369

Thomas Spura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review+

--- Comment #1 from Thomas Spura   2009-12-24 18:52:50 EDT ---
Review:

Good:
- license ok
- %files ok
- %doc ok
- permissions ok
- parallel make
- name ok
- url ok
- buildroot ok
- no BR/R ok
- no *.la
- no libs
- rpmlint clean

Comment:
Is there a reason, why not using %makeinstall?
from
https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_m...

"%makeinstall is a kludge that can work with Makefiles that don't make use of
the DESTDIR variable"

There is no DESTDIR variable, and %makeinstall works (only wrong permissions,
that can be fixed after that or/and complained upstream.)

Doing the install like this is ok, too; but I prefer %makeinstall in this
case...

So please consider changing to %makeinstall :)

#################################################

APPROVED

[Bug 550369] Review Request: spill - A segregated package install logical linker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=550369

--- Comment #2 from Fabian Affolter  2010-02-09 04:43:13 EST ---
Thanks for the review.  I will switch to %makeinstall.

[Bug 550369] Review Request: spill - A segregated package install logical linker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=550369

Fabian Affolter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #3 from Fabian Affolter  2010-02-09 04:44:04 EST ---
New Package CVS Request
=======================
Package Name: spill
Short Description: A segregated package install logical linker
Owners: fab
Branches: F-11 F-12
InitialCC:

[Bug 550369] Review Request: spill - A segregated package install logical linker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=550369

--- Comment #4 from Jason Tibbitts  2010-02-09 16:05:27 EST ---
CVS done (by process-cvs-requests.py).

[Bug 550369] Review Request: spill - A segregated package install logical linker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=550369

--- Comment #5 from Fedora Update System  2010-03-15 16:44:06 EDT ---
spill-0.8-2.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/spill-0.8-2.fc12

[Bug 550369] Review Request: spill - A segregated package install logical linker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=550369

--- Comment #6 from Fedora Update System  2010-03-15 16:44:11 EDT ---
spill-0.8-2.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/spill-0.8-2.fc13

[Bug 550369] Review Request: spill - A segregated package install logical linker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=550369

--- Comment #7 from Fedora Update System  2010-03-15 16:44:16 EDT ---
spill-0.8-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/spill-0.8-2.fc11

[Bug 550369] Review Request: spill - A segregated package install logical linker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=550369

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |ON_QA

--- Comment #8 from Fedora Update System  2010-03-16 19:14:31 EDT ---
spill-0.8-2.fc13 has been pushed to the Fedora 13 testing repository.  If
problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update spill'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/spill-0.8-2.fc13

[Bug 550369] Review Request: spill - A segregated package install logical linker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=550369

--- Comment #9 from Fedora Update System  2010-03-16 19:16:37 EDT ---
spill-0.8-2.fc12 has been pushed to the Fedora 12 testing repository.  If
problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update spill'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/spill-0.8-2.fc12

[Bug 550369] Review Request: spill - A segregated package install logical linker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=550369

--- Comment #10 from Fedora Update System  2010-03-16 19:25:20 EDT ---
spill-0.8-2.fc11 has been pushed to the Fedora 11 testing repository.  If
problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update spill'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/spill-0.8-2.fc11

[Bug 550369] Review Request: spill - A segregated package install logical linker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=550369

--- Comment #11 from Fedora Update System  2010-03-29 22:13:10 EDT ---
spill-0.8-2.fc11 has been pushed to the Fedora 11 stable repository.  If
problems still persist, please make note of it in this bug report.

[Bug 550369] Review Request: spill - A segregated package install logical linker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=550369

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |spill-0.8-2.fc11
         Resolution|                            |ERRATA

[Bug 550369] Review Request: spill - A segregated package install logical linker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=550369

--- Comment #12 from Fedora Update System  2010-03-29 22:22:06 EDT ---
spill-0.8-2.fc12 has been pushed to the Fedora 12 stable repository.  If
problems still persist, please make note of it in this bug report.

[Bug 550369] Review Request: spill - A segregated package install logical linker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=550369

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|spill-0.8-2.fc11            |spill-0.8-2.fc12

[Bug 550369] Review Request: spill - A segregated package install logical linker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=550369

--- Comment #13 from Fedora Update System  2010-04-09 00:13:08 EDT ---
spill-0.8-2.fc13 has been pushed to the Fedora 13 stable repository.  If
problems still persist, please make note of it in this bug report.

[Bug 550369] Review Request: spill - A segregated package install logical linker

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=550369

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|spill-0.8-2.fc12            |spill-0.8-2.fc13