https://bugzilla.redhat.com/show_bug.cgi?id=1361941
Bug ID: 1361941 Summary: Review Request: kf5-akonadi-mime - The Akonadi Mime Library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rdieter@math.unl.edu QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-akonadi-mime.spec SRPM URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-akonadi-mime-16.07.80-1.f... Description: The Akonadi Mime Library Fedora Account System Username: rdieter
https://bugzilla.redhat.com/show_bug.cgi?id=1361941
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |656997 (kde-reviews) Alias| |kf5-akonadi-mime
--- Comment #1 from Rex Dieter rdieter@math.unl.edu --- split out from: Obsoletes: kf5-akonadi (aka kdepimlibs)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1361941
--- Comment #2 from Rex Dieter rdieter@math.unl.edu --- Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=15088032
https://bugzilla.redhat.com/show_bug.cgi?id=1361941
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com Assignee|nobody@fedoraproject.org |ngompa13@gmail.com
--- Comment #3 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=1361941
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1361941
--- Comment #4 from Neal Gompa ngompa13@gmail.com --- naming: OK
sources: OK d71e7a5f06d5d1374822904af797c491770175b5 akonadi-contacts-16.07.80.tar.xz
license: OK
URL: OK
macros: OK
scriptlets: !!
I notice you have scriptlets for update-mime-database. According to the guidelines, you should not be using those for Fedora 24 and later: https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSn...
Please guard them out appropriately.
https://bugzilla.redhat.com/show_bug.cgi?id=1361941
--- Comment #5 from Neal Gompa ngompa13@gmail.com --- Bah, wrong source in pastebin.
Sources: OK afefed0a6ffd35a92f6d45fa51330a5def1a9f01 akonadi-mime-16.07.80.tar.xz
https://bugzilla.redhat.com/show_bug.cgi?id=1361941
--- Comment #6 from Rex Dieter rdieter@math.unl.edu --- Thanks, but doesn't the scriptlets page also say "should" not "must", so it shouldn't be a review blocker?
(I'll be happy to fix it regardless, just pointing out the semantics that it shouldn't stall the review process)
https://bugzilla.redhat.com/show_bug.cgi?id=1361941
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #7 from Neal Gompa ngompa13@gmail.com --- If you plan to fix it when you upload, then I have no problem approving.
Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1361941
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-akonadi-mime
https://bugzilla.redhat.com/show_bug.cgi?id=1361941
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |RAWHIDE Last Closed| |2016-09-03 09:35:30
--- Comment #9 from Rex Dieter rdieter@math.unl.edu --- imported
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla