[Bug 226032] New: Merge Review: libjpeg

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226032

Summary: Merge Review: libjpeg
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: libjpeg

http://cvs.fedora.redhat.com/viewcvs/devel/libjpeg/
Initial Owner: [e-mail]

[Bug 226032] Merge Review: libjpeg

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libjpeg

https://bugzilla.redhat.com/show_bug.cgi?id=226032

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2007-08-31 13:12 EST -------
Please find an updated spec file and a patch to the current spec file containing
some suggested changes and fixes :
http://thias.fedorapeople.org/merge-review/libjpeg/

- Use original IJG source URL and switch to official gz (no bz2 in sight...).
- Move "make test" to %%check section.
- Include install patch to support DESTDIR and fix man pages location.

It could also make sense to split off the binaries and their man pages into a
"tools" sub-package, or maybe "-n jpeg-tools" to not contain "lib" in the name.

[Bug 226032] Merge Review: libjpeg

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libjpeg

https://bugzilla.redhat.com/show_bug.cgi?id=226032

------- Additional Comments From [e-mail]  2007-08-31 13:23 EST -------
Possibly another detail : Does linking statically also require the headers?
Probably, and in which case, we need to either :
- Have the static sub-package require the devel sub-package
- Also include the headers in the static sub-package

[Bug 226032] Merge Review: libjpeg

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libjpeg

https://bugzilla.redhat.com/show_bug.cgi?id=226032

------- Additional Comments From [e-mail]  2007-09-12 07:24 EST -------
Ping? It would be nice to get this package cleaned up for Fedora 8.

[Bug 226032] Merge Review: libjpeg

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libjpeg

https://bugzilla.redhat.com/show_bug.cgi?id=226032

------- Additional Comments From [e-mail]  2007-10-22 11:14 EST -------
Too late for Fedora 8... ping again?

[Bug 226032] Merge Review: libjpeg

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226032

Matthias Saou  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?([e-mail])

--- Comment #5 from Matthias Saou   2008-12-22 17:13:57 EDT ---
I've updated the modified spec file and patch against the latest libjpeg from
CVS, still found here :
http://thias.fedorapeople.org/merge-review/libjpeg/

[Bug 226032] Merge Review: libjpeg

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226032

--- Comment #6 from Robert Scheck   2009-01-13 16:55:24 EDT ---
Tom, can you please show up at this bug report?

[Bug 226032] Merge Review: libjpeg

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226032

Tom Lane  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?([e-mail])   |

--- Comment #7 from Tom Lane   2009-01-13 18:25:26 EDT ---
I haven't been too excited about this because hacking on those 1998-vintage
makefiles is just putting lipstick on a pig :-(.  I am hopeful that the
sourceforge project will produce an update sometime soon and then we'll have an
upstream that is worth cleaning up.

BTW, the ftp.uu.net address *is* the original, well-published, and still
functional URL.  Let's not have any historical revisionism in the specfile.

[Bug 226032] Merge Review: libjpeg

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226032

--- Comment #8 from Matthias Saou   2009-01-14 08:21:25 EDT ---
(In reply to comment #7)
> BTW, the ftp.uu.net address *is* the original, well-published, and still
> functional URL.  Let's not have any historical revisionism in the specfile.

My bad, I had to hunt down a working URL when I saw that there was no .tar.bz2
there, but that has been resolved since.

As for the makefile change, the one I suggest is trivial and (IMHO) clean. It
just sets the paths to the usual Fedora values and adds a $(DESTDIR).

I've just has a look at the sf.net project, and the latest files in CVS don't
look much different, so it seems like you have high hopes... I'd suggest
cleaning up the package as much as possible now, and if things ever get better
later, then great, but if they don't, we'll at least have the package in a
somewhat cleaner state.

[Bug 226032] Merge Review: libjpeg

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226032

--- Comment #9 from Matthias Saou   2009-12-08 12:50:31 EDT ---
I still vote for the porcine beautifying :-)
http://libjpeg.cvs.sourceforge.net/viewvc/libjpeg/libjpeg/
Only a handful of changes in the last 3 years, and none that look anything like
cleanups or refactoring, the vintage makefiles seem here to stay.

[Bug 226032] Merge Review: libjpeg

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226032

Peter Lemenkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
                 CC|                            |[e-mail]
         Resolution|                            |NOTABUG
        Last Closed|                            |2012-03-31 04:49:30

--- Comment #10 from Peter Lemenkov  2012-03-31 04:49:30 EDT ---
Time to close this ticket since libjpeg was retired (in the favour of
libjpeg-turbo).