Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726
Summary: Review Request: xmoto-edit - X-Moto level editor Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: limb@jcomserv.net QAContact: fedora-package-review@redhat.com
Spec URL: http://zanoni.jcomserv.net/extras/xmoto-exit/xmoto-edit.spec SRPM URL: http://zanoni.jcomserv.net/extras/xmoto-exit/xmoto-edit-0.2.4-1.src.rpm Description: Level editor or xmoto. With the last release, this was split out of the upstream tarball. The spec is basically a modified xmoto.spec. rpmlint is clean for srpm, rpm and debuginfo.
I am already sponsored.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726
------- Additional Comments From limb@jcomserv.net 2007-03-02 10:21 EST ------- Oops, bad URLs: Spec URL: http://zanoni.jcomserv.net/extras/xmoto-edit/xmoto-edit.spec SRPM URL: http://zanoni.jcomserv.net/extras/xmoto-edit/xmoto-edit-0.2.4-1.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726
mr.ecik@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mr.ecik@gmail.com
------- Additional Comments From mr.ecik@gmail.com 2007-03-02 12:27 EST ------- What's the %{_mandir}/mang/xmoto-edit.6.gz? Why not to use man6 instead?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726
------- Additional Comments From limb@jcomserv.net 2007-03-02 12:57 EST ------- Looks like a typo. Should be man6. I see it in xmoto, too. I'll fix both. Should provide that back here? Do you see anything else out of sorts?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726
------- Additional Comments From limb@jcomserv.net 2007-03-02 13:01 EST ------- On second look, it's set that way in the Makefile. Should I patch it and send it upstream?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726
------- Additional Comments From mr.ecik@gmail.com 2007-03-02 13:11 EST ------- (In reply to comment #3)
Do you see anything else out of sorts?
I haven't even chcecked whether package's working, but at first sight I see that you ought to remove X-Fedora category and, if it exists, get rid of Application category as well. Also, if you put icons in %{_datadir}/icons/ hicolor you should add Requires: hicolor-icon-theme (some time ago it was discussed on list). Later I'm going to try to build this package and hopefully make the full review.
(In reply to comment #4)
On second look, it's set that way in the Makefile. Should I patch it and send it upstream?
IMHO you should.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726
------- Additional Comments From limb@jcomserv.net 2007-03-02 13:46 EST ------- I've created the patch and removed X-Fedora. I'll send the patch upstream after approval.
Spec URL: http://zanoni.jcomserv.net/extras/xmoto-edit/xmoto-edit.spec SRPM URL: http://zanoni.jcomserv.net/extras/xmoto-edit/xmoto-edit-0.2.4-2.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726
mr.ecik@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO AssignedTo|nobody@fedoraproject.org |mr.ecik@gmail.com Flag| |fedora-review?, | |needinfo?(limb@jcomserv.net)
------- Additional Comments From mr.ecik@gmail.com 2007-03-02 18:40 EST ------- REVIEW: ** it seems that package has some unneeded dependencies, it built fine in mock with: SDL_mixer-devel, libGL-devel, libjpeg-devel, zlib-devel and libpng-devel. So you can get rid of curl-devel, ode-devel, lua-devel, libGLU-devel and replace bzip2-devel with zlib-devel (if there's something wrong with this set of dependencies, please let me know)
** does it make sense not to require main xmoto package? I understand that there's no need xmoto to be installed to make levels for it, but there's a "Play Level" button in xmoto-edit which ends up with very ugly "sh: xmoto: command not found". Thus add xmoto dependency.
** also, you have to add versioned xmoto dependency because of that: "file /usr/ bin/xmoto-edit from install of xmoto-edit-0.2.4-2.fc7 conflicts with file from package xmoto-0.2.2-2.fc6". Now I don't know whether it would be better to have xmoto >= 0.2.4 dependency or xmoto = %{version}. If xmoto and xmoto-edit versions always match, the second solution will be much more sane.
** rpmlint complain about W: xmoto-edit mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) so get rid of that
** [ecik@ecik ~]$ desktop-file-validate /usr/share/applications/fedora-xmoto- edit.desktop /usr/share/applications/fedora-xmoto-edit.desktop: warning: The 'Application' category is not defined by the desktop entry specification. Please use one of "AudioVideo", "Audio", "Video", "Development", "Education", "Game", "Graphics", "Network", "Office", "Settings", "System", "Utility" instead
So just get rid of Application category in your desktop file. Install the newest rawhide version of desktop-file utils if you can't see this error on your desktop-file-validate.
** There's /usr/share/xmoto-edit/xmoto.bin file which contains a lot of binary (?) data. Is it arch-dependent? If so, you cannot put this file in %{_datadir}. Unfortunetaly, I'm unable to identify what kind of data it is, maybe you know something more?
** Desktop file contains "Comment=Xmoto LEvel Editor" - just change LEvel→Level
Other things seems ok.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726
limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(limb@jcomserv.net)|
------- Additional Comments From limb@jcomserv.net 2007-03-10 14:43 EST ------- I've cleaned up the BR, spaces and tabs. I added the xmoto %{version} R. I fixed the .desktop file. I also took a quick look at the xmoto.bin. It's actually not binary, it's ascii xml, and doesn't look arch-dependant to me.
Spec URL: http://zanoni.jcomserv.net/extras/xmoto-edit/xmoto-edit.spec SRPM URL: http://zanoni.jcomserv.net/extras/xmoto-edit/xmoto-edit-0.2.4-3.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726
------- Additional Comments From limb@jcomserv.net 2007-03-10 14:58 EST ------- In my cleanup, I broke the post and postun scripts. My bash-fu is insufficent. What should I do?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726
mr.ecik@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Flag| |needinfo?(limb@jcomserv.net)
------- Additional Comments From mr.ecik@gmail.com 2007-03-11 08:01 EST ------- (In reply to comment #9)
In my cleanup, I broke the post and postun scripts. My bash-fu is
insufficent.
What should I do?
Post new spec with fixed post* scripts. However, I noticed another issue related with manpage. Is it compressed by Makefile or by rpm? I'm asking because it looks broken:
[ecik@ecik ~]$ man xmoto-edit
gunzip: /usr/share/man/man6/xmoto-edit.6.gz: invalid compressed data--crc error
gunzip: /usr/share/man/man6/xmoto-edit.6.gz: invalid compressed data--length error
And this manpage isn't readable, e.g.: "XMOTO-EDIT-.iwvel editfor fo xmohyp, a 2D mohyacros plat fom gram"
If it's automatically created by makefile then turn off that and let rpm do this thing.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726
limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(limb@jcomserv.net)|
------- Additional Comments From limb@jcomserv.net 2007-03-11 12:10 EST ------- Spec URL: http://zanoni.jcomserv.net/extras/xmoto-edit/xmoto-edit.spec SRPM URL: http://zanoni.jcomserv.net/extras/xmoto-edit/xmoto-edit-0.2.4-4.src.rpm
Fixed the scripts.
The man page comes compressed right out of the tarball, before ./configure even. It's still unreadable. Should I notify upstream and onmit for now?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726
------- Additional Comments From mr.ecik@gmail.com 2007-03-20 13:41 EST ------- (In reply to comment #11)
The man page comes compressed right out of the tarball, before ./configure
even.
It's still unreadable. Should I notify upstream and onmit for now?
Sorry that you had to wait... Yes, it is obviously the best solution. Get rid of the man page and I'll be able to aprove this package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726
------- Additional Comments From limb@jcomserv.net 2007-03-20 14:00 EST ------- I've actually got a fixed version from upstream, but they're not willing to do an entire release just to push it out. Should I just do a SOURCEN: URL://to-upstream-svn-web-viewer?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726
------- Additional Comments From mr.ecik@gmail.com 2007-03-20 14:08 EST ------- (In reply to comment #13)
I've actually got a fixed version from upstream, but they're not willing to do an entire release just to push it out. Should I just do a SOURCEN: URL://to-upstream-svn-web-viewer?
Sounds good.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726
------- Additional Comments From limb@jcomserv.net 2007-03-20 14:26 EST ------- Spec URL: http://zanoni.jcomserv.net/extras/xmoto-exit/xmoto-edit.spec SRPM URL: http://zanoni.jcomserv.net/extras/xmoto-exit/xmoto-edit-0.2.4-6.src.rpm
Fixed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726
mr.ecik@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From mr.ecik@gmail.com 2007-03-20 14:39 EST ------- Looks good. Approved.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726
limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From limb@jcomserv.net 2007-03-20 14:47 EST ------- New Package CVS Request ======================= Package Name: xmoto-edit Short Description: x-moto level editor Owners: limb@jcomserv.net Branches: FC-5 FC-6 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230726
limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From limb@jcomserv.net 2007-03-21 10:08 EST ------- Build. Thank you.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/show_bug.cgi?id=230726
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
------- Additional Comments From vegard.nossum@gmail.com 2008-03-07 09:53 EST ------- Hello. xmoto-edit runs fine, but it is not possible to play games from within the editor. When F4 is pressed within the editor, xmoto should start the level currently being edited. When I press F4, this appears on the console:
syntax error : Invalid option "-level" X-Moto 0.3.4 usage: xmoto [options] options: ...
It seems that this option should be --level instead (it is listed in xmoto help screen).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/show_bug.cgi?id=230726
------- Additional Comments From limb@jcomserv.net 2008-03-07 10:13 EST ------- A. Thank you for bringing this to my attention.
B. Please file a new bug, this does not belong on the review bug.
C. What version of Fedora is this? The review bug is for rawhide, but your error mentions xmoto 0.3.4, and the version in rawhide is 0.4.1.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/show_bug.cgi?id=230726
------- Additional Comments From vegard.nossum@gmail.com 2008-03-07 10:57 EST ------- (In reply to comment #20)
A. Thank you for bringing this to my attention.
B. Please file a new bug, this does not belong on the review bug.
Sorry, I found the link on your Fedora Wiki page and didn't know what review meant.
C. What version of Fedora is this? The review bug is for rawhide, but your error mentions xmoto 0.3.4, and the version in rawhide is 0.4.1.
It's Fedora 8.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmoto-edit - X-Moto level editor
https://bugzilla.redhat.com/show_bug.cgi?id=230726
------- Additional Comments From limb@jcomserv.net 2008-03-07 11:25 EST ------- I see. Click here and fill out what you can. ..
https://bugzilla.redhat.com/enter_bug.cgi?product=Fedora
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla